From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D1FE187FFA for ; Mon, 20 Jan 2025 07:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737357716; cv=none; b=NabdihxkR52TgMjfMvweiO41kh/iwr0Gk+4lj6lM7Q1bz0CF6uDpZJ/nByKpCqoMsKUvkkrs7JHl0kAsbbsFa4SsJQlm4WX27VXqK+J22NereRtesrQ5b9Hz8qvBH6AyQL3gcX3ChuOIZtiguPFcpEp75GhH/c8Rt1oL2OR0vWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737357716; c=relaxed/simple; bh=W79KDljWS80LjKAcYj+ppHTJAJw83LWP1tQB5kijGR4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P2zJUaPm0swauuq7u2f8jN2Lkg7MhaR8pPsIDtbOhMTs8PlIpD2/xdcHW54REonWxyeUa1Bc3hGWWQCytgg6RN8qWAuvsCZI2bhQg7F60A49eC8qUV9kMoFCkIuGLDEHrcw/bEDhPBa27UYEm/DfZINYMJqqnN0YVDlP0hLmz6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aHetKGDH; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aHetKGDH" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4363ae65100so44559615e9.0 for ; Sun, 19 Jan 2025 23:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737357713; x=1737962513; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pHsq3uOy5eJ5dVbh8dVdNYReOLOhPHBDenlW0oUhiJ0=; b=aHetKGDHFN1BnPXE5p1UG42wLsjsVQP65iijSDmDrEGxe21AS6UT3GI9KqT58aw07B AbZlG6hVrnEL7t+QnAs76xExiTTSBgi1dL4ov+AcxxofV0AdkwB0tMAlK/xk10jqaVbn e17wI8l6xEwcFEgC+NFnmYGpucpPylGV5E1/Bce4znjmltIJIBBUt1UUcPw8BUPTk7vU 4+aDPg3sPbwldq/8RNAxZp/MB1a4cY1eHalBAdcVRoU7hBAEn5QJ4RoJJOEHgAuvXrYH fdfX3/4IFIziG4WK9HlXGMC0Yjv+zN1BmTpLp0sx13SIOasZ5kgJk6voCXFd1O9ftU3f Z6cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737357713; x=1737962513; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pHsq3uOy5eJ5dVbh8dVdNYReOLOhPHBDenlW0oUhiJ0=; b=ZTInjjA8NfOXevXqLEFlAN5g4jkW6PBAqF4tC73IZ0NwcR5Fsxj9qb+8qGQ+VJ4WN9 Rg4WgIjNMWvlKVcQqYqln2/u+TUA7aQsu0ADI/pPPFSY6g8KWZAwWWAnSozxOn3DaFX/ 7+hyLLchJxXvm/2H4Qrp8eiNHj9+dNuVZVYaDT5Lb7jP0yykaj5a5FwPuBae1IABMuvR LSvtMsIMRgfYeGzZbfQM8VcmIkDqyCz8CkoTvizncMFaeMMuWWED9WaAyqn1dSPr9X4U pFFzJ7d59/0ncCa6WUPCtHEC1uDKO3+G4j4knaFtvZ4iGxW1AjpGHFdyC4w2VP/zfqk7 kJCA== X-Forwarded-Encrypted: i=1; AJvYcCVBI5Jnq2yLx55HeYxr63cCZonS7IIQjJQJrkUCRRylnQOr8eZm2yY52hzDRtni9oCAoc31B7HSU47QJtU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1KvOkyhRjTn5imjARhK7ETOFq0GoEu7xC1LZAwAGQF/+JcH/L G1ekoRBihbIWQol+WEBpXQNefBcABdt1sp2oydFiN5aEcZUNFhcXepWFRWs7LsQ= X-Gm-Gg: ASbGnctESNWl32k3cICE5+xZPygZ8jVkZ5NukSZbXuZ2XN5S9GvzAluauiVvJv7ULWS EqooBPfrCD3GssBEdZXRdnug1c+QCAEwFxF/D4IMQhKxElZO/tT9Os+GxH6bi6Y+8xKdTuaETTM HNfbiiraF8EFUtuDqSHlHnbJSvbuuqqhJpc6Uxp5O1Wl9v1aCcE3QD3L3ifdAKUYicivwRWy8zu 7fk5mexJ2DgsoRBjSqNvVfBcAyOi9S/pp4iJCNyPj6lEjzGs+LU6axPJN49I54/AfRGDx3S5pw= X-Google-Smtp-Source: AGHT+IFxoEn538osLb1odgajYw9fSAUZgF6WvPtYoUG5YWbbVnrdjB5k6/fOChqeptiWxLNN08rLeg== X-Received: by 2002:a05:600c:35c3:b0:434:f131:1e71 with SMTP id 5b1f17b1804b1-438913cf2e0mr106268555e9.8.1737357713032; Sun, 19 Jan 2025 23:21:53 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf32222d1sm9595035f8f.38.2025.01.19.23.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 23:21:52 -0800 (PST) Date: Mon, 20 Jan 2025 10:21:49 +0300 From: Dan Carpenter To: Su Hui Cc: boris.brezillon@collabora.com, steven.price@arm.com, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, mary.guillemard@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/panthor: avoid garbage value in panthor_ioctl_dev_query() Message-ID: <01bf1bd2-2764-41a1-85aa-962f1197387f@stanley.mountain> References: <20250119025828.1168419-1-suhui@nfschina.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250119025828.1168419-1-suhui@nfschina.com> On Sun, Jan 19, 2025 at 10:58:29AM +0800, Su Hui wrote: > 'priorities_info' is uninitialized, and the uninitialized value is copied > to user object when calling PANTHOR_UOBJ_SET(). Using memset to initialize > 'priorities_info' to avoid this garbage value problem. > > Fixes: f70000ef2352 ("drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query") > Signed-off-by: Su Hui Reviewed-by: Dan Carpenter How did you find this bug? regards, dan carpenter