From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753087AbdBGELN (ORCPT ); Mon, 6 Feb 2017 23:11:13 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:32794 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788AbdBGEKP (ORCPT ); Mon, 6 Feb 2017 23:10:15 -0500 Subject: Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup To: James Bottomley , Dan Williams , Christoph Hellwig References: <20170204070936.GE12121@yexl-desktop> <20170205091314.GA3042@lst.de> <1486426467.2474.122.camel@HansenPartnership.com> CC: kernel test robot , Bart Van Assche , "Martin K. Petersen" , Jan Kara , Omar Sandoval , Omar Sandoval , LKML , Jens Axboe , LKP , linux-scsi , From: Jens Axboe Message-ID: <01c338e2-2a30-610d-b7fa-00cb3ce2cf86@fb.com> Date: Mon, 6 Feb 2017 21:09:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1486426467.2474.122.camel@HansenPartnership.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: SN1PR01CA0013.prod.exchangelabs.com (10.165.224.23) To MWHPR15MB1197.namprd15.prod.outlook.com (10.175.2.139) X-MS-Office365-Filtering-Correlation-Id: 8ca1ce51-85b1-4d22-5362-08d44f0f2d92 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1197; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;3:WTRggR3erlE78RcYgUjskTkSPFVrS6Vb6xBhRRJ6MsoBpb//h3pry8c+fvmvp7Gjuvl9xIhXCEyljxa5gXSj5NpD4afdD60oKCGcsARvArhqydFHl4ZwUYKpMssOydlH4h2ywDUBzcJT0XzBLNGo99l0tE7sLk/V5HR/V1BYwNndB6jiOiN8F6KTe2lIUaSs1XkCtAOnfpJ/pqVlPw65GHUlD43JW0wLrixkzKBwSjh8dZAdkJTqbThHLyQd3QGNkQMPbl5YjWt84TOaTIPt1Q==;25:ClQQYjl/HnWbOgL8BB37jJXhnN/BvWtNmuK1PB9mmCDHs5HMyakG/g5muy0CY78H3DbN0HFecD72klhxpXTRgE1o17JgXo3RgFCLK96MsdbOkeRjiFZBtjlGo9JqF3/X2QxywJQtpujBxsoVggaVUVkx8GRCeHYFEt0Wy5kJHImBrzijxi8ahh8EeLlttzDM/kqViruhBhPJZZMPsWZd3f/WZb6GUsg/q9uplB+7OhasD1E8NUgdww+XWN2jAqHsprByzDT3S3a90cAhC91U2Wc0yfHroAbY77tK54QZSU5O0kx3ibzXMSfTkew+htRQ4tv3zM/8B06NrVY8YrBQ8L7ed4CkHIJvacDW2stE6QpIjtxomTfkmBt1AHVDrHyTiWW1cul0AdjRxh+KAO4g8iLegBwTwBzCOujEhFHVJ/ebe/PifdqZBtRzYQHbka9gIiBOEn5aNEW4kk/BPbkSBA== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;31:zDdVfOi0sfKqWPLO20/GicuesGhdZ+bjRZsr1FYSXa5bOFl748A54C1NxhEFLwW/PzGysQc6FGYpUvL3sxiq4OBIqNHHbwEGXil5H0BMqZ/nXRGI32L7W3qWtKj5yYWiayzuWzrJyGpIy96Ma8wYZ2n0CGjE8Hg2Zymso1JO9kjxA8igWP5iy/fcBDOOQ+Q4wFOlWALeaw15NWM/uE1ymX73vUbItT7VQVWPIjG43c+TvP11fKmFtACu4D2pS6+S;20:PFBpEPRqzvBGxERNHbNDYM+IaDN7pur0+sI/EKh3EUv9cbge3xkeyk1ZJj4VgLhgpRrz9F6wnFk6W0WMgPOzyqS7wP24V3DrciP0R7ULMZ20W6SaQzn2SXVWtl7l9y0AdHsH07lgnmO66mwk9DteShxhLmfwY3IxnP8nQpq1uQRGwAY0BuoV9GXD7cqoh/oewG0ewrHSVRPtHDRA2Ug/c0RnYSBYPvWCl2HRIq27+B7ijPuhwPgQmgjofblQQ5tjbkDjDhchEazN+nbo1VQm0Av2Nzu6Q1tj//8lJXkzdWJetsDrb+j4ha9zk84vwNYCzYJjIPQBRXWRcWs8Gp0wrEGuV2T1iMqTP6aMF07qyDmgLKlcyc9VGIugN1G3JGoRfgjqbn0eRaf4axEqcI9MyJYZ+Sf8XChd5v0rKNA7Ehus67iNtCJyPsL84Xs8uEpzwdwL0CiCJtHNza7JockjYwNXami28LjoClwxBd3uQD9lpb+OtQPv6Hckm54gFLC+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(20170203043)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123558025)(20161123564025)(6072148);SRVR:MWHPR15MB1197;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1197; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;4:eQNXhl6MtlgETBLQIMTb4D9QEv3gWSmQYi1mADd6++1CKvASac0fEm5X8OAde4RW7Ge8N483axmYF1fDO16sLdjjvp50/+UO4UAitzfIRXLgzxhbM0Hr92ohXLp8vCSXhyzuL0XDNPjOv+Jz5WbUdGMxczxqGRkHu8x0DKtlCnGWIRh7J/641XbsfkmohJ2X+3mhfd6gG6g7KX96VKrgp0GBTZEuzeAV16Xr+vmTCdZPI0GdZ64ZDhgVpD7iNh1gvEi/tuW96GEMLas6BECCdIFWc5qAtQviB16e5t6J8/RyTskmv30sUgO2VLE5sjzLpc9yp06e3Oqv+M5hH2hKp6EsHEDc2ObomizelKT92EY+wbEdwOdzgYY8rZ7TyRTjo3Y6VO0B7qVMPyZb5XZjG+v6w4ibAtv01kuKx2H/HXYG+cxypW3ztHLIqH4Kuo4a+oQeZ55HM8Lga9VM5PNGwUVqPJkBkYr/dTvg/6h79mDhvcgbu+i4SDh7Uf0JeV85krOLyfyF8cOUUQYo1HtLXPe330Y4zKSibHycG1IDXibkqlDG4JhihnsafUQ8MxQBUBbwtzdJ9THZoE6GwZKuQJrJUZz6ANKl/NtOqY7+IouZxK8X85Ga9B170micDE3m X-Forefront-PRVS: 0211965D06 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39410400002)(39830400002)(39450400003)(24454002)(43234003)(189002)(377454003)(377424004)(199003)(4001350100001)(83506001)(97736004)(230700001)(54906002)(6246003)(2950100002)(53546003)(229853002)(36756003)(65806001)(65956001)(47776003)(66066001)(90366009)(7736002)(8656002)(77096006)(7416002)(305945005)(2906002)(6486002)(6666003)(189998001)(5660300001)(4326007)(25786008)(65826007)(33646002)(8676002)(86362001)(81166006)(31696002)(81156014)(76176999)(117156001)(3846002)(54356999)(50986999)(6116002)(93886004)(92566002)(101416001)(5890100001)(23676002)(38730400002)(68736007)(42186005)(31686004)(50466002)(106356001)(64126003)(53936002)(105586002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1197;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjE1TUIxMTk3OzIzOkx6YU9JZ0wyT0RJcUlMb0J4YU1Wa0MzQmJO?= =?utf-8?B?RENiQjBlUGY5M3dKcHAxUzcxU3JjQ2Vma2drL0R1bXhvOEtIeUxRbk4xTlla?= =?utf-8?B?ZlZoM05MUkpLeEE0ZFZDeVlBUzNXOXVpNmdmeU5UUVAraktiNTU4U0t5bHpQ?= =?utf-8?B?V1FFRG1PWlI4NEVlM3ZkeTNhQVlaVCtrZmdVS2NBQ3F3R042dXVDZmxYelFt?= =?utf-8?B?VWsxR1dobWNPT1dNcEJNTFdrWG80SE1YMkdzSVBqYk9Fbmc3dDcrYitzbW9E?= =?utf-8?B?L2ZYSnFGbWlhckVZbWZ4OFo5L05HZ05rN2JWK2VsU09WZXk4akhlcnkvUTBK?= =?utf-8?B?Ymt2T2RjdXY2WGZwS3lyeDFLZ2o1Mk5VMFhOMExWZzFEdFJwMHVCdmF0ODN1?= =?utf-8?B?RGRTajlnQVNWK0NCNHkrZ0tMd2JZQVhNSVdKWWJpTXdJdFljZng5MUlDMS9R?= =?utf-8?B?a3BpbkwzMjRjZGxkeGhuY0lWbDhKSTNMSkN2eGVLT0ppMkdtZ2ltdEI4QnFU?= =?utf-8?B?MVd2UloySUVMUUtKcFlYdWJyRzZXT3RMSlVHVHhUR3ovbUovYVk4dW9RUkIw?= =?utf-8?B?d0ZRVXEySmw5MkZPUHNQbmJ4YXRWaGh1R3JCZDFGYUdja0hjT2hBa3NJZENz?= =?utf-8?B?elBuUW1JcHVDUVRXbEpWWklvZDg0RlZuZWRUQnN6UWdhSHhSQXdKRllIelJP?= =?utf-8?B?c1RyYzZ5aVRNaDBGS0F0T3VBN01SR2ZZOHVmMWMvQ0xPMGc2SkZmSXQzOWR3?= =?utf-8?B?QTJGUGlvT1dFWExMUEUrVm1kcnVtV1A0NmxMa3R2ZnFJdXdTMGVyRDFIY0Zn?= =?utf-8?B?cVhoLzBlV0d0QXlMYmRGUlI5VWlBbDRYdXI4eVVOZzJDT3oxa2s2d01kL2dw?= =?utf-8?B?U2tCOFNtd3Q3ZDZZcWx5blZLRlJHVmFtV0VmaVRvLzZJaExZS1pKdC9DakFU?= =?utf-8?B?SUtBT3VMWEFFUmdjanViUE5VVmR0UDQraE5haGJCN0ZSNU0vV3lDYmVMTGt0?= =?utf-8?B?N29BdU9BSGkzemxlV2dCU0IrcHBVYk5uRzVEWjRRWjkzbUpoTTVlSllIaHdl?= =?utf-8?B?azJ5TEZqOUVXQ1dJOTNENFhxWGpuVWh6UVdQa29ha2YvUEFkZUdTUnpBN1I5?= =?utf-8?B?aVFubS9qdHpFa0J5YzV3WGdQcEc2VVNBS2pIT3NvS0U5RFh4ZW4vVUZVV1Ur?= =?utf-8?B?cUZIQmZrOUVQS3Y1eCtOOHRJd0hkN3Z5QzdqbVZibUdLVXNPWG04Rlcycm04?= =?utf-8?B?T2h6MHdYR0dZVmZudmNaTlJOTTVSdjlHMkNRYWtWUWJoRXIyZ2ZEa0JKdFhM?= =?utf-8?B?NlI3S3hZQUY5Q1E0aU82ZWlZcng0a0t0R0xWRk1wVURDd0IvMGJ5QkhBT1FS?= =?utf-8?B?cGpuNmNMeHp2WWdBTFJUanFpOHlwQ1NZbm5nUWtGUFhpMm0rUUxYbnN5UmJQ?= =?utf-8?B?ZSszQXJ1NzJyWnRnZHdVTUhpU0dWREVrQVZFTG9BeFZpSTZDdk11dGNGVXJh?= =?utf-8?B?T3Y2Q2Y3NzhFYldyM3AwRXBEc3lyZzZGZ01Ha2l4RjdsTVl6dm1kOE5lSTFv?= =?utf-8?B?bVkvQ3BObFVNMUIvUytEQy9SL0lHa09SMUZtaEZCOFF1dGxpdDBuZStaY21G?= =?utf-8?B?dFZGWHVhMG1kc1E3WEUzNnNYTXNRVDBmU01HSTFUSGdmUHJnVWNXVHhVemlG?= =?utf-8?B?Rnh5MzRFcm5RQnBKeHNLd25OU3I5QTBqSWh3MDZxN20zZGVwSXpZNWtaTWJC?= =?utf-8?B?Y2FMWXozZVV1WG4rME1GMm9SK2VXTWVLZ2ExQTVGckl3bnNTTjFzRmxTZ0xF?= =?utf-8?B?RzJzVk9uKzNFTDRpTWRCTGRZeHowTnRMZ21FNGlkUkRvU2pLSmVINklKQjVk?= =?utf-8?B?aE4rOThCVEczbUl4S3pUaGgrck5pZXY5TWRiK00zLy9KUzRVeFlLTldWTHpU?= =?utf-8?B?RlFIdWV1V21McU1VQXU0Ynh1WDJDYSt2Wml4WkdIeE8vVWtjMnM2UmRFb1Z5?= =?utf-8?B?Z0RjTUppc1hpQ3JVZ28wdWVBK3pmSjc0MDFISERzai8rWUQ5NmJqc1czMDhN?= =?utf-8?B?YUZYSkJMalZLVmpUd2s4VkRjODVTT3BBZGphemFXNDBTL0orc1AzOFNoVEFJ?= =?utf-8?Q?40ouUtdGxx51d/AxoQ8bX9Vl71/yVfdkRO9pQE/fIXCI?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;6:VHGfxtWCMG+q3CnS7xuIqwQdD4VVdPIJktGU5zz6AOAbTvgoFaevanVK1z2/se2+DkAlp9LayV36Byc1i8CBcTf/uTPJZXeM6VJkEBS4NJZW5aPD//heea+PyvgarHXxtKyxqIv4YNLWvj9BmWYUeInJjqZsZPgej54vnTtAYZbBTvJ+LBhwKoDrRQwtkS27KT6gnbH4Mi/KMMBEbjWapbHYA/y+SG9pN1IsDaY9JAXn2LhN6EzOc7ugJXN0XPKUtmovzvSxsxrF5Yt7SOzRqcfd6WRehnu4TUfywO4mFVBBAr4BaYr6qBr9x9v2nLWXBbf2dBof/MqYtF2e5KxGV9qWQ8Nn31H5YMY/T53Hiry8MXTuPJpwb2+1PA0b1zZhbSWgEil483rg3n0CHO8Row==;5:/ITnZT3g0HXBSWzLiv4XzYTdDNgfsyqFlxSmM7mMFotJoQ0d00K9GARh/Pea2B8O2Xgiv91ynUFdHsnwXR+oQohVpdW9Q8sAEeU2IDxuLrd0hw+7fnEKNjh6L05gWzpN7EQSjQ7g2tx6OCd3owSZ+Q==;24:Sjt4uP3RL1/3fraA2aV2Mtl1NROGpWOsha5r3mBtbsBelikrH2xkIgxSVYxc9Ja30Q+ed0DUekXLjgn9pchLiT7dpecMmvlBo3e+SxoNygo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;7:tG0gL1NhOmUA6b97SSP6QUYuUCh0eCk8GO7MoqNn8CHu8b+fo42yEfAbKvuLzNwtWloDab6Kb3lpaNYQ4nLWx3CvJ+ofbBycphVwnDAoqDkRmp3wO6fFjprWXQQmp/JNvZN4zoOXrWcG9wZyeOePCI+Im60j5+QbJuFyncY/QeVJICbdjBsweOctHRZZzjMhYHywX6P3M7Pu2mjFMDmcaLKRSdSHac5d21w+ETJfsDP+d5XBViOJBDEM1OEp5OZwHtNafMN/dpMHX0LP80pw/zzWJUJrI9gbNRf5Totd0+zt3oA/kcubT2DYY3dAq6rhE5Rqn5R3CpYpnxiVW5e1IebW4dALwl52QztUwMTJTOCbyf7XYvEEG5cshnOipG07NgH4D5NeUgrvPSfd9jyfu2t28V1qr47gO7FczmYs3X/Y0Ryp1++CpLQOLDXhHghrr5hCBvxXSkwE0MRgC0HIJoUw2GWjeijk4VKIutoBFS4tbX0WvsEK88zJj9CKZVCOK+Uo+vVhDR0WRFJNYIvTEQ==;20:aWgdtDoBrFCywEhTqTkjC3MBrNvB4gzuBtUN6QTQvmu3Iboe6/OQZD1SuBetT8Ips3eFuQ2hs8FHrC033mO9yUVEKPNz6OF51mXU+/oyRxKkqe/wPH//2f76QIPfeEymkYYFd3rXL34oVFAiD9YqLQx+62X2vuSPNyst3kD2jjM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2017 04:09:53.9421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1197 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-07_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2017 05:14 PM, James Bottomley wrote: > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: >> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote: >>> Dan, >>> >>> can you please quote your emails? I can't find any content >>> inbetween all these quotes. >> >> Sorry, I'm using gmail, but I'll switch to attaching the logs. >> >> So with help from Xiaolong I was able to reproduce this, and it does >> not appear to be a regression. We simply change the failure output of >> an existing bug. Attached is a log of the same test on v4.10-rc7 >> (i.e. without the recent block/scsi fixes), and it shows sda being >> registered twice. >> >> "[ 6.647077] kobject (d5078ca4): tried to init an initialized >> object, something is seriously wrong." >> >> The change that "scsi, block: fix duplicate bdi name registration >> crashes" makes is to properly try to register sdb since the sda devt >> is still alive. However that's not a fix because we've managed to >> call blk_register_queue() twice on the same queue. > > OK, time to involve others: linux-scsi and linux-block cc'd and I've > inserted the log below. > > James > > --- > > [ 5.969672] scsi host0: scsi_debug: version 1.86 [20160430] > [ 5.969672] dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0 > [ 5.971895] scsi 0:0:0:0: Direct-Access Linux scsi_debug 0186 PQ: 0 ANSI: 7 > [ 6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB) > [ 6.026965] sd 0:0:0:0: [sda] Write Protect is off > [ 6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08 > [ 6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA > [ 6.486962] sd 0:0:0:0: [sda] Attached SCSI disk > [ 6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache > [ 6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0 > [ 6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB) > [ 6.546964] sd 0:0:0:0: [sda] Write Protect is off > [ 6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08 > [ 6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA > [ 6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong. So sda is probed twice, and hilarity ensues when we try to register it twice. I can't reproduce this, using scsi_debug and with scsi_async enabled. This is running linux-next? What's your .config? -- Jens Axboe