From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28D12223322 for ; Sat, 10 Jan 2026 15:41:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768059678; cv=none; b=Oql1L3/oWldhYoA6tBAF0O0bx5WtpM3c96PxJ6sD3ChGOHujGgcCSIwh50EzHIZHJ4dKQsulkXtvWa29uUorlcWaEX+upGlBzzvfbcup6Bo8Jq31HnAJBO6FVsXuxN9eutbFkAIsbxTITcaXdrex0IzNgeSYMxdGQF4HPVdzpu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768059678; c=relaxed/simple; bh=iO/IflfT75xoH4Y/3knSkdA4MdvILEkF6mEChUu/B+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=habQd+VBEfR6uLOm0P1giiNv6vJFSpLQhNGDsGj6cN1RytGvpNnIyJlUKtFQSM6nqg/vahJ0orfpV4M/0eA+A+yyIld+mHAwZoR3NmbbYYaT4AHNGEyKw6sAU3u9GB+snhEG5R+vymQd3fCDQxtR1szSzF4w+GzKJjRYBeK0xdg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=cAZlr1/q; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=wNsGH+7G; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=cAZlr1/q; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=wNsGH+7G; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="cAZlr1/q"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="wNsGH+7G"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="cAZlr1/q"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="wNsGH+7G" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2D3F55BCF9; Sat, 10 Jan 2026 15:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1768059675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DMaASs04EH1I7HUqtZvbF7q1RZcgi+PtUryM4O8whrk=; b=cAZlr1/q6mvAbPN7LBM8pdU8zIRaw0pLkwrT65nKFHaa5sUtuP9gkcR4wlHqaDhk7DXAmo EjDC7ALn5UoCRdoZympBKtXSgd2ssOcPL3SX2Ir84BQV1MyTjGP5LWJOGGnh5TFFsN1IZx AzRnj6kuIRBFKZODCY5hDzPluoh4oa4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1768059675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DMaASs04EH1I7HUqtZvbF7q1RZcgi+PtUryM4O8whrk=; b=wNsGH+7GfFgmC33WbycxXp23WRqqV4aK/Lt9vtpwZc66eG9E4DQ0MZURT/g36t8zct7tRj hzUH5YR8uNjbFWAg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1768059675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DMaASs04EH1I7HUqtZvbF7q1RZcgi+PtUryM4O8whrk=; b=cAZlr1/q6mvAbPN7LBM8pdU8zIRaw0pLkwrT65nKFHaa5sUtuP9gkcR4wlHqaDhk7DXAmo EjDC7ALn5UoCRdoZympBKtXSgd2ssOcPL3SX2Ir84BQV1MyTjGP5LWJOGGnh5TFFsN1IZx AzRnj6kuIRBFKZODCY5hDzPluoh4oa4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1768059675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DMaASs04EH1I7HUqtZvbF7q1RZcgi+PtUryM4O8whrk=; b=wNsGH+7GfFgmC33WbycxXp23WRqqV4aK/Lt9vtpwZc66eG9E4DQ0MZURT/g36t8zct7tRj hzUH5YR8uNjbFWAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F3E5B3EA63; Sat, 10 Jan 2026 15:41:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wxerOhpzYmlFPgAAD6G6ig (envelope-from ); Sat, 10 Jan 2026 15:41:14 +0000 Message-ID: <01cf95d7-4e38-43c6-80ef-c990f66f1e26@suse.cz> Date: Sat, 10 Jan 2026 16:41:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/19] slab: remove cpu (partial) slabs usage from allocation paths Content-Language: en-US To: Chris Mason , Roman Gushchin Cc: Andrew Morton , Christoph Lameter , David Rientjes , Harry Yoo , Uladzislau Rezki , "Liam R. Howlett" , Suren Baghdasaryan , Sebastian Andrzej Siewior , Alexei Starovoitov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, bpf@vger.kernel.org, kasan-dev@googlegroups.com, Petr Tesarik , "Paul E . McKenney" References: <20251024142927.780367-1-clm@meta.com> <28e6827e-f689-45d9-b2b5-804a8aafad2e@suse.cz> <9a00f5c2-7c9b-44c3-a2ac-357f46f25095@meta.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <9a00f5c2-7c9b-44c3-a2ac-357f46f25095@meta.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[18]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux-foundation.org,gentwo.org,google.com,oracle.com,gmail.com,linutronix.de,kernel.org,kvack.org,vger.kernel.org,lists.linux.dev,googlegroups.com,suse.com]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: On 1/10/26 14:20, Chris Mason wrote: > On 1/9/26 3:16 AM, Vlastimil Babka wrote: >> On 10/24/25 16:29, Chris Mason wrote: >>> On Thu, 23 Oct 2025 15:52:32 +0200 Vlastimil Babka wrote: > > [ ... ] > >> By the way, there was another bug in this patch, causing a severe memory >> leak, which the AI unfortunately didn't flag. Petr reported it during >> performance testing and it took me more than a day to find it. Oh well :) >> >> Wonder if things got better since then perhaps, and your or Roman's tools >> would find it today? :) > > Yes and no. It didn't find the leak until I changed the prompt to say: > "there is a leak, find it". I'll see if I can improve things... Thanks. Hmm even if it has to be done like this, it could be a substantial time saver vs finding the leak myself. >> diff --git a/mm/slub.c b/mm/slub.c >> --- a/mm/slub.c >> +++ b/mm/slub.c > > [ ... ] > >> @@ -3592,54 +3549,53 @@ static void *get_partial_node(struct kmem_cache *s, >> else if (!spin_trylock_irqsave(&n->list_lock, flags)) >> return NULL; >> list_for_each_entry_safe(slab, slab2, &n->partial, slab_list) { >> + >> + struct freelist_counters old, new; >> + >> if (!pfmemalloc_match(slab, pc->flags)) >> continue; >> >> if (IS_ENABLED(CONFIG_SLUB_TINY) || kmem_cache_debug(s)) { >> - void *object = alloc_single_from_partial(s, n, slab, >> + object = alloc_single_from_partial(s, n, slab, >> pc->orig_size); >> - if (object) { >> - partial = slab; >> - pc->object = object; >> + if (object) >> break; >> - } >> continue; >> } >> >> + /* >> + * get a single object from the slab. This might race against >> + * __slab_free(), which however has to take the list_lock if >> + * it's about to make the slab fully free. >> + */ >> + do { >> + old.freelist = slab->freelist; >> + old.counters = slab->counters; >> + >> + new.freelist = get_freepointer(s, old.freelist); >> + new.counters = old.counters; >> + new.inuse++; >> + >> + } while (!__slab_update_freelist(s, slab, &old, &new, "get_partial_node")); >> + >> + object = old.freelist; >> + if (!new.freelist) >> + remove_partial(n, slab); > > Is there a missing break statement here? The debug path above breaks out > of the loop after successfully allocating an object, but this non-debug > path continues iterating through the partial list. Each iteration overwrites > the object variable, so previously allocated objects would be leaked. > > The commit message says "Now we only want to return a single object" which > matches the debug path behavior, but the non-debug path appears to allocate > from every matching slab in the list. > >> } >> spin_unlock_irqrestore(&n->list_lock, flags); >> - return partial; >> + return object; >> } >