From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=115.124.30.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794836107; b=CPJQLtzgR87S/hpApyuwW4fpH4KVwu6Etb4hV+xZojKk0hEAuag8HpnVu3EJLdzrWI+J fy8DC57HVkbMckk9HtYY2BRFYNgg1offYuU5heysFkJ6QS829UizJ0QtzpfczqU3UlZf9 gMuhQBuLSykrns8H7DJ7JQMVy8yU+tYnlm+f9LkWPllO6I01i6nzFppSLVrT4E/1giRfO VosSzlVWxrNimxQyzrwlqvZRIwhRsrOm2JaypQHCEascbtogLjRpNnrwy37jvI7kfmGOc +KM6NWJZt4jt2YqUS3JaiX9GRC7ksOP4GuBRVfaKoBVp2BGqmIKxbKYyRo+PyI+RVNw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794836107; h=DMARC-Filter:DKIM-Signature:X-Alimail-AntiSpam:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=VTdh+RQXIjKegFBkHqeV/SunRho35ClvmITrODAwJgE=; b=GNGa/YWSDSE+sKNpPJdolMAvEKVEwQh23W8XXCteK8Wt6qrT6lJt5K0A/cdkLnDgAPYF Hec6erWxTlRVaOM5qIhiV6Uvlh+VBjH/r7EsWBKIb8xDHSFr/LmzxcvDoDXbxUuH9xhtz RleTKMWzffQWzOvT8Tcj8K4C1714bVcgK+rlki7VGVgUG0jpLVkJ3gewfVqAoJk0HlNXn sp05WwdoVbybIKQ/yoXRBAqlvt1tVOv0mA7zVurZU+8MuMS+RZH4BSupUzU2s8e4Qxj6K cy3Yi8vRM+xa0iOccu3t9UsDThS9p+YeeIYB3k4BoVR4+djSsKfL9tegRgdjbZLXG5A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=ODKhTewZ; arc=none smtp.remote-ip=115.124.30.131 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8093606A31C for ; Mon, 16 Nov 2026 13:35:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E8093606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=ODKhTewZ DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1794836096; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=VTdh+RQXIjKegFBkHqeV/SunRho35ClvmITrODAwJgE=; b=ODKhTewZERc1NGVZvep3c5vaMLOOzI/ARU7ajdvzjHuYHRTRkvFl+ezcIekIsMGwXeJMZHDPqXWQ02PzHKSSIh5mOoFa5b66kcpQgWAnJbh/AexJHkpqgdmbnB30nn9K8jwvofIzQk5/kfFoF5CT5Z9gEmyWwcwAke2pIkzvkMU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R651e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037033178;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0XEtLy1f_1794836094; Received: from 30.251.68.229(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0XEtLy1f_1794836094 cluster:ay36) by smtp.aliyun-inc.com; Mon, 16 Nov 2026 21:34:55 +0800 Message-ID: <01d59bbc-46d4-4da2-805c-bf540d50eb37@linux.alibaba.com> Date: Mon, 16 Nov 2026 21:34:53 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: synchronize with PTE table reclaim for all folio sizes To: "David Hildenbrand (Arm)" , akpm@linux-foundation.org, ljs@kernel.org Cc: riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, qi.zheng@linux.dev, pfalcato@suse.de, ayushr@modal.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <16bb1a14-04f4-4524-9882-20d452175a3d@kernel.org> <9e66d5f7-ee81-4204-8d62-b06d26a00623@kernel.org> From: Baolin Wang In-Reply-To: <9e66d5f7-ee81-4204-8d62-b06d26a00623@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/16/26 8:03 PM, David Hildenbrand (Arm) wrote: > On 11/16/26 04:44, Baolin Wang wrote: >> >> >> On 11/14/26 1:39 AM, David Hildenbrand (Arm) wrote: >>> On 11/5/26 03:56, Baolin Wang wrote: >>>> Similar to commit 243cf1f67b36 ("mm: memory: fix truncation removing mapped >>>> folios"), the '!pmd_present()' check in page_vma_mapped_walk() can also race >>>> with concurrent page table reclamation via zap_empty_pte_table(). >>>> >>>> page_vma_mapped_walk() is used by many functions including try_to_unmap(), >>>> try_to_migrate(), folio_mkclean(), pfn_mkclean_range(), remove_migration_ptes(), >>>> page_mapped_in_vma(), and mapping_wrprotect_range(). Except for try_to_unmap() >>>> and try_to_migrate(), the other callers do not perform post-walk accounting >>>> checks, so the race has no observable impact on them. >>>> >>>> For migration, the race can cause unnecessary retries. For reclaim via >>>> try_to_unmap(), the race can cause failure to reclaim a folio that is in >>>> fact already unmapped (as shown below), which may lead to unexpected OOM >>>> or increased refaults. >>>> >>>> CPU 0 (reclaim) CPU 1 (MADV_DONTNEED) >>>> -------------------------------- -------------------------------- >>>> folio_lock(F) >>>> try_to_unmap(F, TTU_SYNC) >>>> zap_pte_range(full PMD range) >>>> spin_lock(ptl) >>>> clear PTEs >>>> zap_empty_pte_table() >>>> spin_trylock(pml) >>>> pmd_clear() >>>> spin_unlock(pml) >>>> >>>> page_vma_mapped_walk() >>>> observe !pmd_present(pmde) >>>> nr_pages < HPAGE_PMD_NR >>>> skip synchronization >>>> return false >>>> >>>> try_to_unmap() returns >>>> folio_mapped(F) == true >>>> nr_unmap_fail += folio_nr_pages(F) >>>> tlb_flush_mmu_tlbonly() >>>> tlb_flush_rmaps() >>>> remove F's rmaps >>>> spin_unlock(ptl) >>>> >>>> Commit 243cf1f67b36 ("mm: memory: fix truncation removing mapped folios") >>>> has already moved the PMD clear operation (via zap_empty_pte_table()) to >>>> after tlb_flush_rmaps(). Similarly, page_vma_mapped_walk() also needs to >>>> use sync_with_folio_pmd_zap() to synchronize and avoid memory ordering >>>> issues on weakly ordered CPUs. >>>> >>>> Fixes: 6375e95f381e ("mm: pgtable: reclaim empty PTE page in madvise(MADV_DONTNEED)") >>>> Cc: stable@vger.kernel.org >>>> Suggested-by: David Hildenbrand (Arm) >>>> Signed-off-by: Baolin Wang >>>> --- >>>> mm/page_vma_mapped.c | 5 +---- >>>> 1 file changed, 1 insertion(+), 4 deletions(-) >>>> >>>> diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c >>>> index e6b6170c2f4f..8797467b6f0c 100644 >>>> --- a/mm/page_vma_mapped.c >>>> +++ b/mm/page_vma_mapped.c >>>> @@ -293,10 +293,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) >>>> spin_unlock(pvmw->ptl); >>>> pvmw->ptl = NULL; >>>> } else if (!pmd_present(pmde)) { >>>> - if ((pvmw->flags & PVMW_SYNC) && >>>> - thp_vma_suitable_order(vma, pvmw->address, >>>> - PMD_ORDER) && >>>> - (pvmw->nr_pages >= HPAGE_PMD_NR)) >>>> + if (pvmw->flags & PVMW_SYNC) >>>> sync_with_folio_pmd_zap(mm, pvmw->pmd); >>>> >>>> goto next_pmd; >>> >>> Baolin, how to proceed with that? Are you intending a resend? Including some of >>> the performance impact and ways forward to optimize? >> >> I hope we can merge this fix first if no other objections. As I replied >> to Barry, whether to set TTU_SYNC for small folios should be done in a >> separate patch (this is a pre-existing issue) with proper measurement >> (though it may be hard to measure the actual impact). What do you think? > > Can you update the patch description to include some of the performance aspects > and planned next steps? Sure. However, regarding performance aspects, I'm not sure what kind of testing you expect. Since this fixes a uncommon concurrent race, do you want performance data under that race condition, or impact on common paths like try_to_unmap/try_to_migrate()?