mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Kamal Dasu <kdasu.kdev@gmail.com>,
	broonie@kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] spi: bcm-qspi: check for valid cs before applying chip select
Date: Thu, 27 Jan 2022 10:59:10 -0800	[thread overview]
Message-ID: <01d73e56-346b-a175-6113-db98be6b0a53@gmail.com> (raw)
In-Reply-To: <20220127185359.27322-1-kdasu.kdev@gmail.com>



On 1/27/2022 10:53 AM, Kamal Dasu wrote:
> Apply only valid chip select value. This change fixes case where chip
> select is set to initial value of '-1' during probe and  PM supend and
> subsequent resume can try to use the value with undefined behaviour.
> Also in case where gpio based chip select, the check in
> bcm_qspi_chip_select() shall prevent undefined behaviour on resume.
> 
> Fixes: fa236a7ef240 ("spi: bcm-qspi: Add Broadcom MSPI driver")
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian

  reply	other threads:[~2022-01-27 18:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 18:53 Kamal Dasu
2022-01-27 18:59 ` Florian Fainelli [this message]
2022-01-28 15:59 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01d73e56-346b-a175-6113-db98be6b0a53@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=kdasu.kdev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®