From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDFF39478C for ; Mon, 18 May 2026 20:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779137382; cv=none; b=NW5BoV5fjrLPOFVMB7Ivrgu2249muIdho1/XhC+7XlLuQn7kECiuZsur/0WfRn6/zLdQ22uQAb2eG+/OOKBJBBmplH1BaBd2ing7tXX78wynI6PMoZBoGeVJU1DQ+DgQzj4I3HCaKz2Lrgk1c3LBBMK05cQhtdwvjtystKYIpwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779137382; c=relaxed/simple; bh=RyoGwN7G9vQDOQNVZPxQ+HRgEPGCBHD6qVUWTvQXfgg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uvKrRzJdFcraLhnwAMnzFM5v3Vg5OT9tcXeKogin90ZTYkyRFpO363TRPXKmYlX6QQiY5PzEsPCED4X0iDBkP3rvyyfjINzQYD7wJN3RZaTGvp1CdYnSWXTcg0LTXOSH3UpPaswhXf3HGgCM7509l5qYN8c7xYugNIyrV8GfnGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=S2p2Gpjw; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="S2p2Gpjw" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso37374475e9.1 for ; Mon, 18 May 2026 13:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1779137379; x=1779742179; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l2NTPpzDiFlBQXBmoJbzyiHW1xJm+/TyVqfGW6eXiWI=; b=S2p2GpjwTt4UoRQubG4MKIQk2vZVomn/0DBffu8gVa/lCpwcuI4nz4brOmYXlKV/Uu zjZtLq+csuxH74tbks+6GRVhkyAGFLdQs7ns/EK43zrSjQ0k1woJUxxXgYkwkvPnc5nM phEnexQ25l0Qp5BMDwmo8kSlqS1o7N22d25GHVhJAJQbUtJLGyG74kSEOvqwKNCqCbVf dY6oKNaPb+iavq07bxWSIXUo6p/A1/CVoatSEb5yzZfZIUbWzFeMJsRt6WsQBIU+0mvX B/4dRnNQ1yBihpVVIVrae6YQZHhYnnJvAT4d812J5vkA5by3T/K77QBTXBXM2FDjnTW9 0gUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779137379; x=1779742179; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l2NTPpzDiFlBQXBmoJbzyiHW1xJm+/TyVqfGW6eXiWI=; b=Jr0FAgTCQfZ/6yIB5WXfVqwSAxj85jGWIkE6hW72lrCaEuOcANf1/33ccu+eDesGrS njbYwKKNhd9/MMMZYPrGa4t5psYA+U9siJXKwu/DffnxARwYkbv5kbEZe4/4mklbYlGm PksFg/t9LZHaUEdUHIPhKclZ//T8SdZwfMmlSsftmG07P4fb18BsTED41tYFeX2wTZJq G+CGHOJFqOnBFYyBQ9IPKDpsYVc+o97X8bgVmWBoLY6vhZr0/88KOZke0vMaoljpkOLf KD069bu/xyj4m7VjqfSeftDM48s93E1NaSyd6gK12M63dHfgxW6WHsngoZewr4wj/xEp VBIQ== X-Forwarded-Encrypted: i=1; AFNElJ+XQI//q6Io7Co41ZPIDm4qu5AEvZDiLiWoMZidFZr9BiYDUGcrVLgbZ4xWud4+yLESXEEcDbA0H0yWqdE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3i8oW0EBMPsuaLZgmSDsI6vx0SWCHj6JNQYrrxTRlbeyqyZ7Q U3y+7rJifxHr7WEcErtW+p0KKezEOv5E/SiGnG/Dch7SDXw+uZIw1vmjp8pQpAH9Pg== X-Gm-Gg: Acq92OHrTZ5qLvDMIqqAVVHoQFoOTp7uTdTssBB0R0rYU0IXvXGqR5DXYD1uHzw9Q3n LgBO4hlMfVbPfsOxVFPVrzYKnj6yy9yDPVslk2Lz7237gXM8MHLDAkgSjwag52SHqtqd2vFEVKZ 2m2Fa2KbqU706hUytvULgKwWlAeelkwx0Uu+xfMkaQ49vEi0bBHZgYGLoGasNBb0gAznCLIpbvB 86LDLdYWQqv3cp03VQtKJ9qqDTDgPpVMQ7LR6hevamlEggDolzH4MZ35RyQDxncfghjR2BU3gbs lqubflbFfWZ+LEcEjq6joMhc2E0i5/Id1xws6/Fu7HNWT+6DUjeS97j0ttBxKUQvXMVJmTnqotP +0GoMSbWVL68U4hBWtKOGP2xpREik6n+dcFVYGCYGSvHQ9MItho2J9Nsivy3wyIWSKotmngq0pQ diqa7abzPuAbnZfInM3ifvGj0= X-Received: by 2002:a05:600c:2d81:b0:48f:e518:d110 with SMTP id 5b1f17b1804b1-48fe651d7cemr158815975e9.32.1779137378929; Mon, 18 May 2026 13:49:38 -0700 (PDT) Received: from [10.83.43.186] ([159.134.255.34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe537ccf5sm273208205e9.14.2026.05.18.13.49.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 13:49:38 -0700 (PDT) Message-ID: <01dd7a1d-fac7-4e5a-aeee-cc8dccef41e4@arista.com> Date: Mon, 18 May 2026 21:49:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI/AER: Clear non-fatal errors on AER recovery failure To: Bjorn Helgaas Cc: bhelgaas@google.com, mahesh@linux.ibm.com, oohall@gmail.com, corbet@lwn.net, skhan@linuxfoundation.org, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lukas Wunner References: <20260518202903.GA641158@bhelgaas> Content-Language: en-US From: "Yury M." In-Reply-To: <20260518202903.GA641158@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Current behavior has existed for a long time and I could easily imagine that there is software which relies on the fact that the system is in a non-modified state if AER recovery failed. The software can analyze the system and do cleanup afterwards. Sometimes, if something fails in the system, it is better to have it in a non-modified state. In short, I just wanted to preserve the current logic by default because there is a chance that we have software which relies on the current behavior. On 5/18/26 21:29, Bjorn Helgaas wrote: > [+cc Lukas] > > On Mon, May 18, 2026 at 02:23:36PM +0100, Yury Murashka wrote: >> pci_aer_clear_nonfatal_status() is not called when AER recovery fails. >> If a new AER error is subsequently reported, the AER driver calls >> find_source_device() to find the source of the error. It rescans the >> whole bus and picks the first device reporting an AER error. Because the >> previous error was never cleared, the error is attributed to the wrong >> device and AER recovery is started for the wrong device. >> >> Add a kernel boot parameter pci=aer_clear_on_recovery_failure to clear >> AER error status even when recovery fails, preventing stale errors from >> causing incorrect device identification on subsequent AER events. > Why should we add a kernel parameter for this? How would a user > decide whether to use the parameter? Are there cases where we > find the source of the first error, but we *wouldn't* want to clear > it if recovery fails?