From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB72938FF15 for ; Tue, 13 Jan 2026 13:13:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768310022; cv=none; b=jSQFCqhpLb8/Xu27O/eOWSujesAhxIn26dw4OpwskP+wC/7QkP4veZGvkAQS6CHObnsNZAbbZb/zu2IBPGB6V7Qda3eTRWBeiVehfbDQ4hP0OTaFcuj5QyCuNrDg3/eD1G0FDPNBwMKp2guQOTnOkG0A6dbiGNmtEXOnZM1fcgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768310022; c=relaxed/simple; bh=dk5jbImLcB2x8AUb5RmXedSgI5VU/00aSHRlIsFQACE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=spTfoS1ukRcr3TRMFYANqI1xbQ1WJ6/5Jdu1fLDhyedOcyrBejLj4arQF8CUwVy/c3C1F363/q9Rb23910KUp2G5BMmNIFIrx4f/bazo2Q7We02R/xwxou1bMpdVlQWQtSAeGJ7TmtKIXK49cEeJgqc6PzA3cQiu5/rwE5U4t3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=THginQgt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P8RZB2FN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="THginQgt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P8RZB2FN" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60DA5jNu3798433 for ; Tue, 13 Jan 2026 13:13:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0bwgBAmS/C+0L1XuQ0SYs4qvA/Tw0QYyfHwE2EwIuVs=; b=THginQgtkhUQiSel ux3m7OHK2wyaIn7UdCvPp9UZZ1CkuJB94IKAf8QN43Hv6/SPe31DUBVU8L9jPp64 4ss9W67pMYLJSQXrclEMgRilReHQCs/VCtMUzOgrTOLVNCiRE9ub2yWnLJBiDlJN vqIGjWrgCLKxOF/ayTYm7jqLAzzQB1HI/hPou5TiLHUROxgxjNNGbAJvZxvS0yYQ s19dRCvaBO6QpXdCFYmf6rbFqkY9t5SiHSW0ZzsIDTVTTKkYQNzcPBjaJOMTwWR7 MjY1NxYPMgzJkUyu2XbbOfn62vNGecSZtYhMbs2xbwKmfRBAwA+YA8+cCs0Ove9T tulawg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnm0drhrk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 13:13:37 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-501468a59d6so89941cf.0 for ; Tue, 13 Jan 2026 05:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768310017; x=1768914817; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0bwgBAmS/C+0L1XuQ0SYs4qvA/Tw0QYyfHwE2EwIuVs=; b=P8RZB2FNeS9xea/z6HWJF8tt7jWNSwDV4lkyergRnm+DQn5uWBFpeSPdJ9YcPF+vvh ljq/y/epzQxcyhcL7uUXb5CB5FW5UQD+R/qVbGuN1v/7t3lxtHI3A5j8GZqO+rrjNbvq OvM7Ljrs7A2embMs6NKdFv70ygQJw+oo9VqCFMpyspaBnrgahSdC0vXNMTGeNbSbWUeW 9Y/5dT/WoIelkCjMoH2eY0bNx6zPpsyK/O9ngSlCBR4qQgbpvoa0tCD+OmVrUcx+dYh7 f3Pce5avhPr+c06aTTbCw7/WctSnfv84/0HYTAGHObrunL+ka6hA4/lS5RI5STalrMR/ PKgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768310017; x=1768914817; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0bwgBAmS/C+0L1XuQ0SYs4qvA/Tw0QYyfHwE2EwIuVs=; b=QPomuEQt4075cpgPr8fFGaBTO8DOH5P49io9j6Q5HJ9KBhkgdTNTEFQp3yLYGNI8xs d3+HvnH/bpmSLEUqgfeat3oy6Wv+OJX0m4RA9/ST71/KyYK2m7Aa2BZP52nf8/KFUAyz W72Muyq/ihoUv6cP+U2bvk3wMrMREVt6DMbtUBOHNsQQqd9oZ/1vPegwf3YKIsuQbjfX +P1GZxIsOP475r2RQVdoP2tAaT6ntOLq4F8kdcxy2gzfMwwtqqGmRWxi/n1RPet3dUQK MXStL/AIqXp/AbyK3+qJj5f2E++gFhizTqYKaXZSGTW9oRy2GdyWoK2FRWchmlIfOwCF x8iA== X-Forwarded-Encrypted: i=1; AJvYcCVkJ/8Rdn8X9U0Fwt2eQd4WTgx5vbOmZsnGCGRQh+6GvKCJq6xj9GlO38iFlT/fLIG2M2F8V4rIkci4/CQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxhlIL8xLZpvpzZxZIdqsjx/9ZuE48jBxlXPySynpthLjrtrmFc sMiEMC51t76J70VYgAuLiqRswY977iHUWA6/gTdXsFBFoKM9gyy4jWotdabYCf3vZeEXgEK1cSM wGHZYoAnTpOxKMu9sMuiJW2PnLl0eKYWyajDN837KGB4j0lFmDmlT1PREYCT19vG2sJM= X-Gm-Gg: AY/fxX58ywADeFRB4tuak1ubDNhAuQVMOLKBpJsNiXkFKwjOR/4kbqhrzxIQTeP/qGd YY6rwHj1ZDkfp7VscAki4KHGHdS8X4wpHCQ+ACPkUUg/Jf36VbhHuZJ+VQQeadQirUARQ92H1K1 on/6TTgl3MMzyZP22GcumKI9Tbm1p1YUuIDCr6xAr2gmevXOrE02WPs+qpP99A6hY7jI4G+nJv8 OX4w19F9Q94kC/6YRU1Kt/FLBJrDW+5AQcCURdr6QOu8l8BZtl2BMZqKBSvCndcleFg9PIxhAFU jsDjA4vvgu4IZT7LClWRQBbGMHfu8csS5//6ZGpACl0zV6UekxA7K+sLswY1mAyr4blQGW2y7rJ CPrfIwe/GNBOLtohJe45IPkvGSo9WPqhAGAG7q1a99ujX3P4B1EoP1hjEqwAWsdRned8= X-Received: by 2002:ac8:5d4d:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4ffb4a3c298mr254101021cf.10.1768310016912; Tue, 13 Jan 2026 05:13:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMnv/lcUVT4eP4KfERHWUj9va04jydi2ZLUZKaGU1BHKtNSsfG/3e9UddbuRq0n628WO/yaw== X-Received: by 2002:ac8:5d4d:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4ffb4a3c298mr254100671cf.10.1768310016477; Tue, 13 Jan 2026 05:13:36 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8720e090dasm514513566b.9.2026.01.13.05.13.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 05:13:35 -0800 (PST) Message-ID: <01de4054-eebf-4ef3-ad74-c806b208a848@oss.qualcomm.com> Date: Tue, 13 Jan 2026 14:13:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/3] arm64: dts: qcom: glymur: Add USB related nodes To: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng Cc: Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Wesley Cheng References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BYXVE7t2 c=1 sm=1 tr=0 ts=69664501 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=sYW25ZiEPLqq09AedJsA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: G-FjxCr_R4alVCTYfSj5t6QUg-yNJeCP X-Proofpoint-GUID: G-FjxCr_R4alVCTYfSj5t6QUg-yNJeCP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDExMSBTYWx0ZWRfX0YtujlMXqAKB 9Yo7LMzbrEPUU0Pepfqse1IGpc6g8Z4Wkg2InaWtv1lzYyX3MxpSfYiEFa6QBGR/g3Vyc8bMBZe E6Uu96kg8FVauFqeztR/A7roxffyWLdtdVum1ZXg85OCvJ/EcW4ZcIFTwi/uvwfy9KVP4vjFAGR EInPOL7mj5iEV09JAJl6K6Wg1Tjf8NwxRZCXl9uMnj8TzGlmHChtjq/p7p8mxZlQJa9PMH4DTa9 9/IciGmFsjINNGheWgOC5Vw+p+gReV/pe7WCWtt1hJgaXxD4qoMYIdrvmpTTWtGruM/ronWUIpL QhSlHjN5P1aMcy0Hrcse7ktANzeC1bFOFV8lgPJKjWZbSav1PfJ2PlJOzdgR9geMeDds9qBtIh1 JsUKp5sLGKwNDyl+d/TT8vOH9L9WK3Se82wOTveKaq4VLs4sQqOwfaV/dXaJ6QgJzG55V7CiU6h OU2CM3Gz6CYm20eDzRg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130111 On 1/13/26 1:33 PM, Abel Vesa wrote: > From: Wesley Cheng > > The Glymur USB system contains 3 USB type C ports, 1 USB multiport > controller and a USB 2.0 only controller. This encompasses 5 SS USB QMP > PHYs (3 combo and 2 uni) and 6 M31 eUSB2 PHYs. All controllers are SNPS > DWC3 based, so describe them as flattened DWC3 QCOM nodes. > > Signed-off-by: Wesley Cheng > Co-developed-by: Abel Vesa > Signed-off-by: Abel Vesa > --- [...] > > + usb_mp_hsphy0: phy@fa1000 { > + compatible = "qcom,glymur-m31-eusb2-phy", > + "qcom,sm8750-m31-eusb2-phy"; > + > + reg = <0 0x00fa1000 0 0x29c>; > + #phy-cells = <0>; > + > + clocks = <&tcsr TCSR_USB2_1_CLKREF_EN>; > + clock-names = "ref"; > + > + resets = <&gcc GCC_QUSB2PHY_HS0_MP_BCR>; > + > + status = "disabled"; > + }; > + > + usb_mp_hsphy1: phy@fa2000 { > + compatible = "qcom,glymur-m31-eusb2-phy", > + "qcom,sm8750-m31-eusb2-phy"; > + > + reg = <0 0x00fa2000 0 0x29c>; > + #phy-cells = <0>; > + > + clocks = <&tcsr TCSR_USB2_2_CLKREF_EN>; > + clock-names = "ref"; > + > + resets = <&gcc GCC_QUSB2PHY_HS1_MP_BCR>; > + > + status = "disabled"; > + }; [...] > + usb1_ss0_hsphy: phy@fd3000 { Let's not repeat the mess introduced in hamoa.. Perhaps let's fall back to usb_0 etc.? [...] > + snps,dis_u2_susphy_quirk; > + snps,dis_enblslpm_quirk; > + snps,dis_u3_susphy_quirk; > + snps,usb2-lpm-disable; Other SoCs have a list that's much longer, please consult Wesley if this list is enough Konrad