From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEADE314A95 for ; Thu, 22 Jan 2026 09:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769073315; cv=none; b=FnsiKVnRyaa+5jX/5pUoB2G7RkFWp+xNZ2aEGKOnxi8/MMQkPEZ2HcoEhV1y+8pWIq2LVVjMGQVFZANME6h3h6Uye9GKG/1O9uJb+JnjVp7SF9sTwOTAsp0jv1HPh6SuhBrWbU1q2nIbiy+46IJZuGnMQ7r8hR2EVdF02ZLfGeM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769073315; c=relaxed/simple; bh=mJ0vgCKye1UqxT59lIrROPj3m8+igVctoYmfCDLJ0RQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NoEh9HXCdd6eJPibDuQQi3zfr8Gilk0yW6K4otOubEWNFJfiYZ7HL2U9ryWllH/TZF0lxQUt83A03P2HM4yNPZ2QAPxgLfBKyqvRY+2SOLcKU2WuvyCVspLsvUZqVN8JGssDuPpL2eu+8/i+faB54LnkglreaEHvI0dbdARdP/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cC4DZSlI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TT7K1Ebt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cC4DZSlI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TT7K1Ebt" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M5Gjtg3902293 for ; Thu, 22 Jan 2026 09:15:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hG2JmDsNT8t96Xwz5s7F3bBzVMBIxS6BhytG2Bt0OQ0=; b=cC4DZSlI+K+w/Kpn rDghF6SnzjfNcmklfxBJG/MSbuTl+6fTrAqJcc2hnZ5kSs0YdVIcHyR+BaE5vbJK y1hjw76tFBctX0vgr3T56YXH7VB+rYWgtibAvEobOuZwedevuBMFT8O9zRbgPn7q HFXiGIWTEmylsEP+sywf48qVbZACeJLnY68ZDrLFXYqs4ljlXW39/jUO5bBLVB2l 9FfEutYNm+rVlk1+uDPDy8CNUYLpMO8k/yF+s4ZmjG0ocrj/3osLrR8bCliycfcS 3HPqnbt2H170WkXFxGZAbSJPy05oJHAVBCbaSXP4X0neBSc1qZLZ86iiC2QKIIGA VV7kEQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu4khj77p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 09:15:10 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-88fd7ddba3fso2490656d6.1 for ; Thu, 22 Jan 2026 01:15:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769073310; x=1769678110; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hG2JmDsNT8t96Xwz5s7F3bBzVMBIxS6BhytG2Bt0OQ0=; b=TT7K1EbtwshceIQcXN1e9C2DkFh952EJrqk1+WKZqy2wU+mlD1m4j1Uty805YJI+Ig UUdm1NCNE2F+x4YcN5sJrPk4Wv3qFFiGjwbebgIf5MJn9nb6FKJUMTFjH+O1eAIogXQr fpbSywgY4cjQa6pby9Q3fcRl3TAW/N9ITHFDI1o6XVoMDP7EZDjatjfZb6wZWUOeqskU mRlv/8xskRe8TwUwRabkywkdFGVib6cekcFcHrVYPUUaNRjhfjj+DKoCU/EcBEugEfIk mrM2teA35BSi813NfUfGrbVYhN1EgDmVzUtmYZvifN4viSNldGheIdtBMGQXEQregbKK ppmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769073310; x=1769678110; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hG2JmDsNT8t96Xwz5s7F3bBzVMBIxS6BhytG2Bt0OQ0=; b=Ou+4QNv6xRUm7haPmQ+JTjmj8Y6xea/7PdzClIAx1bYXunzlsnewL5DGN28qe/Eexv Hp3N0Ud7UuRKJtmwc8lL8yLbofcCUX8SeXdqb3cD/efuTtFC5fYhK+YB6r3KtvGDTEBR Uu/3shidOQt7qTiUupM3ItPZSGMMPcz2jI/FVLDU+rDAEKUwApc9+4Hq7eqZPqFQWxP5 QH0x0YQsNREK+Xi2/eJ+5J8Tq57R6drLi2fDOs/akH2vN/iP6RYetFM3gOnxa7iYyxs+ OjhVcQvS57Lejs/SONAoGetV+b2xeG2zww4jozqcGw1m8veuQdxZI0xBPIFBjB3hAfgR M8WA== X-Forwarded-Encrypted: i=1; AJvYcCVWhrozznAmU4rQEsK2yBZ02kD9Rhch12BOyym4nwZut5PnquTFg2YjZW8hVp3R5VJkchDiPL+o5eE5TqQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1OHhtcUaJXoxjdpel1fuKlARYx/MjlZQEtZhNjcHMvQoK5RoU akUFYjL6syudRWoyft4lCnw8lbxu7+KmulxdWsnZcrJ3b6re6Tjv6S5IH82Y/DEcD6WZ/dHciia /daSKaF4Pwc7JCU4ONxqwrF09xpwtdKFxttU7U9HQBCrZSenVQEKIbDXlekNEMy7lM7mhknVTA9 s= X-Gm-Gg: AZuq6aJylINWGebj5t+LGRd4LSZZ97g4cMYcPcp2tTyr2xhXyfa76zCMgwCgpe+5//x +/uQC2WF3R2GB0S2OmrW8eq5brnQyvR/I2FI6FnGi/Ww6EV7We8HVaQRSz9f9QbQ38HmqpevQt5 Xj0+4UMpxBdrcRATwkUCg9XG8e3zrBcflngQnIjLXJg4zO6+Aqf6XCuQirHKn0K+92bH6zqCVmk XMRV9Mq3DuAJs+FFrokUHjpE1CTqumh0dtkd5khxQoIguQx6o0EawmPfl1/yyIDv5qMbDpa2UjL +JENJ23qjVebFt77nA71tn5fHbDDcXsFweS8B0Hl9jlK1XmVjoZL20TMAjLxxEeY/AiAoWp+ke4 MfIr5ef9/gyjQltTfPz6zs31zUJbYtYHUzUTa41mUtkttItsUUNuT+s63cYq8d0sFXRc= X-Received: by 2002:a05:620a:1aa9:b0:8c3:9ae3:1a78 with SMTP id af79cd13be357-8c6a67cc5b2mr2004301085a.11.1769073309692; Thu, 22 Jan 2026 01:15:09 -0800 (PST) X-Received: by 2002:a05:620a:1aa9:b0:8c3:9ae3:1a78 with SMTP id af79cd13be357-8c6a67cc5b2mr2004298785a.11.1769073309034; Thu, 22 Jan 2026 01:15:09 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795168b9bsm1693992766b.16.2026.01.22.01.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 01:15:08 -0800 (PST) Message-ID: <01de9fc2-f60c-4bc0-af61-c070213df29b@oss.qualcomm.com> Date: Thu, 22 Jan 2026 10:15:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: add basic devicetree for Ayaneo Pocket S2 gaming console To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, KancyJoe References: <20260121-topic-sm8650-ayaneo-pocket-s2-base-v1-0-bb3f95f1c085@linaro.org> <20260121-topic-sm8650-ayaneo-pocket-s2-base-v1-3-bb3f95f1c085@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260121-topic-sm8650-ayaneo-pocket-s2-base-v1-3-bb3f95f1c085@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDA2MiBTYWx0ZWRfX83MUBtxrXpq5 f/EDznTwPTsEEbh/nG3qII3yE1T7cy0TmhqE69kbNmOp0UEeR6fO53fLkSSWY/SjgIFv59ZAqSU ni97J1a2eu2FSQAO7iMmbs+RFt9M7qdETuxDvpGWuyOsMS4VxfwV32zZZfW48ZgRMjkM4JGsk2x 98ikXz8qHJkM+24aMKmzcZ2fqY3fpfR47rJFCzS5x6ks2fwR8/ZQibJfSV2Z7hRqEUbX6O0kkhj Z8FEsBzl+u6L9uWZnvbc0nYZGXiP6sHXw3L4K3dY8dd4qLDcsbq47dOJJg+OawmciRIJUw5T+vz 17NJnMHlh7RZgaGUMVfDSyvGBRjCmALPmx3nWb4Xrw+KvulUaUp/FPEKF4Agz3n5snTs4VcEjkb 2IDKJ9LK3JLKNQ76HnUZLjJh3C4oIMxs/KbEa5S+LG3FT7DzSJrx7Sz9Jnlk2SNYAdcIvaf3vj4 TygzocANkuilscGZX9Q== X-Proofpoint-ORIG-GUID: DKfJp4H6qTamxdFvCffOz2okTjBMDw49 X-Authority-Analysis: v=2.4 cv=UOjQ3Sfy c=1 sm=1 tr=0 ts=6971ea9e cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=UqCG9HQmAAAA:8 a=KKAkSRfTAAAA:8 a=BfLt2Qf9Yghiec0bZR0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: DKfJp4H6qTamxdFvCffOz2okTjBMDw49 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-21_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220062 On 1/21/26 5:40 PM, Neil Armstrong wrote: > From: KancyJoe > > Add initial Device Tree for the Ayaneo Pocket S2 gaming console based > on the Qualcomm Snapdragon 8 Gen 3 platform. > > The design is similar to a phone wihout the modem, the game control > is handled via a standalone controller connected to a PCIe USB > controller. > > Display support will be added in a second time. > > Signed-off-by: KancyJoe > Signed-off-by: Neil Armstrong > --- [...] > + fan: pwm-fan { I'd call it fan {} but gray/grey > + status = "okay"; You can drop this line (nothing disables it) > + compatible = "pwm-fan"; > + > + interrupt-parent = <&tlmm>; > + interrupts = <14 IRQ_TYPE_EDGE_FALLING>; interrupts-extended looks neater > + > + pinctrl-0 = <&fan_pwr_active>, > + <&pwm_fan_ctrl_default>, > + <&fan_int_active>; > + pinctrl-1 = <&fan_pwr_sleep>; fan-pwr looks like an EN pin of a GPIO-controlled regulator > + pinctrl-names = "default", > + "sleep"; > + > + pwms = <&pm8550_pwm 3 50000>; > + > + #cooling-cells = <2>; > + cooling-levels = <0 16 32 45 60 80 105 130 155 180 205 230 255>; Does this come from a preexisting map? > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-0 = <&volume_up_n>; > + pinctrl-names = "default"; > + > + key-volume-up { > + label = "Volume Up"; > + linux,code = ; > + gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>; > + debounce-interval = <15>; > + linux,can-disable; > + wakeup-source; > + }; > + }; > + > + pmic-glink { > + compatible = "qcom,sm8650-pmic-glink", > + "qcom,sm8550-pmic-glink", > + "qcom,pmic-glink"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + orientation-gpios = <&tlmm 29 GPIO_ACTIVE_HIGH>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + > + power-role = "dual"; > + data-role = "dual"; > + self-powered; Is this property interpreted at all by our setup? [...] > + sound { > + compatible = "qcom,sm8650-sndcard", "qcom,sm8450-sndcard"; > + model = "SM8650-APS2"; > + audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT", > + "SpkrRight IN", "WSA_SPK2 OUT", > + "IN1_HPHL", "HPHL_OUT", > + "IN2_HPHR", "HPHR_OUT", > + "DMIC1", "MIC BIAS1", > + "DMIC2", "MIC BIAS2", > + "AMIC2", "MIC BIAS2", > + "TX SWR_INPUT1", "ADC2_OUTPUT", > + "TX SWR_INPUT7", "DMIC1_OUTPUT", > + "TX SWR_INPUT8", "DMIC2_OUTPUT"; > + > + wcd-playback-dai-link { > + link-name = "WCD Playback"; > + > + cpu { > + sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>; > + }; > + > + codec { > + sound-dai = <&wcd939x 0>, > + <&swr1 0>, > + <&lpass_rxmacro 0>; > + }; 'co'dec < 'cp'u [...] > + wcd939x: audio-codec { 'a'udio-codec should be way higher [...] > + thermal-zones { > + cpu2-top-thermal { > + trips { > + cpu2_active: cpu2-active { > + temperature = <38000>; > + hysteresis = <2000>; > + type = "active"; This is shaky.. let's perhaps reference each thermal zone that you want to extend with a label.. Or maybe a pair of labels for trips/cooling-maps per zone? [...] > +&pcieport1 { > + pinctrl-0 = <&upd720201_active>; Is this a regulator? > + pinctrl-names = "default"; > + > + /* Renesas μPD720201 PCIe USB3.0 HOST CONTROLLER */ DON'T SCREAM! :P > + usb-controller@0 { > + compatible = "pci1912,0014"; > + reg = <0x10000 0x0 0x0 0x0 0x0>; > + > + pinctrl-0 = <&gamepad_pwr_en>; > + pinctrl-names = "default"; Is there a hub connected to it? Or does it go directly to the aforementioned (game) controller? [...] > +&pm8550_pwm { > + status = "okay"; > + > + multi-led { > + color = ; > + function = LED_FUNCTION_STATUS; > + > + #address-cells = <1>; > + #size-cells = <0>; Would a label="xyz" be useful here? [...] > +&tlmm { > + /* Reserved I/Os for NFC */ > + gpio-reserved-ranges = <32 4>, <36 1>, <38 6>, <74 1>; double space Are they all for NFC, are they all required? [...] > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi > index 07ae74851621..fcd5a1a45803 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi > @@ -3917,7 +3917,7 @@ opp-32000000-4 { > }; > }; > > - pcie@0 { > + pcieport1: pcie@0 { pcie1_port0, please Konrad