From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD48ECE58B for ; Thu, 3 Oct 2019 20:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE08A20862 for ; Thu, 3 Oct 2019 20:20:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R6BpWamP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389006AbfJCUUd (ORCPT ); Thu, 3 Oct 2019 16:20:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:46175 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388922AbfJCUUa (ORCPT ); Thu, 3 Oct 2019 16:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570134028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lJsPH0CXpGipbA9H0dGeQKpG32OggA79MXCAh0eilHM=; b=R6BpWamPHr78X7aS0QdG6b6w9AkQxDLjf7GIoVYxLgeVb1NK7/MW51tgyLsXk+vjd4jLnI XYMsTYseyRzBnHefOnarfxu1BmDlCu3b+8ON0JPyZNBzzUPCBb3a4fdIj8tYcuiJt3ZWzz Rf/nrehDeqjJYr3tcnlduGa5+58Kgxc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-MbC85PlYPPmkuWBdfuyS6w-1; Thu, 03 Oct 2019 16:20:27 -0400 Received: by mail-wr1-f72.google.com with SMTP id z17so1623524wru.13 for ; Thu, 03 Oct 2019 13:20:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=1mbvMx4ggA/oxOpE1MmlWpjLmFJpu3/zVOWw4njUri0=; b=HTFHtX8sBcMUQu3H+VvIBDw/1p3KWFAPwKXjROPFuDtBRv2kyNf3Xr47Rq1HCx+DfI YBOecrVmI+DqBRLez3Ys1Df7AeWjtEiZ1V89CohHIebDkBXhjdbM2bTv6lp6tMUNw2Au XAqEcMsqoMPX4WihTu5Bjf28D/U3qybPAEGtvJRGbDtJipMxelF103l41byuVDerdJIi JUzsTd74TxaS+F3rGgOMDqfconcgR0YnLRU6u4t/CX+/1yUke5q9fF9EG4vW+nIoRk30 uew2hr5TJvb5GTF3hoFWiU+fSLypkSLrf/Essf2VFlH0gkiUqXaD1CsUIstQQPE+pjsV ur4A== X-Gm-Message-State: APjAAAXXIkc8A0Ya+bH5z2HtDMf/5K1ey5q9sEPVeL234q9i+ii15Dth iVB1oHmPF3CM2RE/hkpgFNWZCTMaSl3Deo30nZx6/bKq+0veNBqS7QmE9+V0rulTsRgV7j+XYKu Ljw+bdxD6pmtrLhp9JVT9DeQ7 X-Received: by 2002:a5d:6a09:: with SMTP id m9mr8087612wru.12.1570134025935; Thu, 03 Oct 2019 13:20:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMmbb0nF2zvJZD5BcMQQB8t9k4v9RmHUA6Wx0p477W+n8i5AnC905fNFlzJHR4Ptxz5d/wZg== X-Received: by 2002:a5d:6a09:: with SMTP id m9mr8087595wru.12.1570134025690; Thu, 03 Oct 2019 13:20:25 -0700 (PDT) Received: from shalem.localdomain (2001-1c00-0c14-2800-ec23-a060-24d5-2453.cable.dynamic.v6.ziggo.nl. [2001:1c00:c14:2800:ec23:a060:24d5:2453]) by smtp.gmail.com with ESMTPSA id b22sm3533965wmj.36.2019.10.03.13.20.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2019 13:20:25 -0700 (PDT) To: Stephen Boyd , Greg Kroah-Hartman Cc: Andy Shevchenko , linux-usb , linux-kernel@vger.kernel.org, youling 257 From: Hans de Goede Subject: Problem with "driver core: platform: Add an error message to platform_get_irq*()" commit Message-ID: <01e3d855-c849-ad7f-a6f8-87c806bb488b@redhat.com> Date: Thu, 3 Oct 2019 22:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 Content-Language: en-US X-MC-Unique: MbC85PlYPPmkuWBdfuyS6w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, I've been debugging a new error printed with 5.4-rc1: [ 25.570893] dwc3 dwc3.0.auto: IRQ peripheral not found This is caused by the "driver core: platform: Add an error message to platf= orm_get_irq*()" commit. The dwc3 driver first tries to get the IRQ by 2 different names before fall= ing back to the IRQ at index 0: irq =3D platform_get_irq_byname(dwc3_pdev, "peripheral"); if (irq > 0) goto out; if (irq =3D=3D -EPROBE_DEFER) goto out; irq =3D platform_get_irq_byname(dwc3_pdev, "dwc_usb3"); if (irq > 0) goto out; if (irq =3D=3D -EPROBE_DEFER) goto out; irq =3D platform_get_irq(dwc3_pdev, 0); Together with the mentioned commit, this is causing this new (harmless) error message. We also have had a bug report for this: https://bugzilla.kernel.org/show_bug.cgi?id=3D205037 Which I will close after this mail since the error is harmless, still it is sorta scary looking and we should probable silence it. The best solution I can come up with is adding a new platform_get_irq_byname_optional mirroring platform_get_irq_optional and using that in drivers such as the dwc3 driver. Does anyone have a better suggestion? Regards, Hans