From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbdE3IYU (ORCPT ); Tue, 30 May 2017 04:24:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:49048 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751237AbdE3IYO (ORCPT ); Tue, 30 May 2017 04:24:14 -0400 Subject: Re: [PATCH 5/7] nvmet: implement namespace identify descriptor list To: Johannes Thumshirn , Sagi Grimberg , Keith Busch , Christoph Hellwig Cc: Linux Kernel Mailinglist , Linux NVMe Mailinglist References: From: Hannes Reinecke Message-ID: <01e9be1b-b110-adf4-8c31-11b272bfe920@suse.de> Date: Tue, 30 May 2017 10:24:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2017 10:08 AM, Johannes Thumshirn wrote: > A NVMe Identify NS command with a CNS value of '3' is expecting a list > of Namespace Identification Descriptor structures to be returned to > the host for the namespace requested in the namespace identify > command. > > This Namespace Identification Descriptor structure consists of the > type of the namespace identifier, the length of the identifier and the > actual identifier. > > Valid types are EUI-64, NGUID and UUID which we have saved in our > nvme_ns structure if they have been configured via configfs. If no > value has been assigened to one of these we return an "invalid opcode" > back to the host to maintain backward compatibiliy with older > implementations without Namespace Identify Descriptor list support. > > Signed-off-by: Johannes Thumshirn > --- > drivers/nvme/target/admin-cmd.c | 75 +++++++++++++++++++++++++++++++++++++++++ > include/linux/nvme.h | 14 ++++++++ > 2 files changed, 89 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)