From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52AA637999C for ; Mon, 2 Feb 2026 15:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770045123; cv=none; b=KwJGcxwRgZymYX2iN2lh7aaCw3OO3DOd4x//X3nq3U71UmHGJ2Vfvnjv3K6OX/DyubT2rXagNxOFxxkpUK78CatECDBFS4F3WiNITHxOKM5pePdk7y+RBUM9FcwqGboMfBwP2cqKb06BylxAAsCwrdQUjaYhwB1f9KdaU764lU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770045123; c=relaxed/simple; bh=pCj2ne7t7DkFEsf1NLDwuY6/314P01aVxJWXOtIFe5s=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=XnbLxcuj+rze/RsgiSDNdYm4XIh/yM/ONyWEn85Wpq3BOmn+R0E7GdhsGYL++YGvDBTrd/tvwTFfQdcWhdlqY+jxHxvZpRPeK0x2vWsES2icYH0+w6Xlzsq6GQ6BkOF9Ohcql81hT8md8jYT+AuTK/KLpoR+E6wrmaDuh1/TzT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=qf4gS/Gf; arc=none smtp.client-ip=209.85.161.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="qf4gS/Gf" Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-6611c3b147eso3290588eaf.2 for ; Mon, 02 Feb 2026 07:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770045120; x=1770649920; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=blBZowIYxmGQt/qp8Zqs7qxe8LPuadPVWAo6HXJFncM=; b=qf4gS/GfJ0EpE6hdfJtK6zpPq1hQVklMD5vt3/P0jG90UB8R4dLyxwHjKIWaXNwX7v KVZnmG175E2EGyZ2yelCCY9f/L8pMQ37u2PQM6Ns2PRDb713O/Qhf2t1mCQTXyRWfHPZ SaWL1RRBukFtSDGrt2C7Dv/5oUe8h+NXqNICIyUjC/eFmTootZirD+72NlIGk2Soojaa xsmkRfcsT98P3I2in15Le+rcwuzfoyyV9xIAg9fiVwIPTppS9vFZacTHJbrZRNHKK5I3 uv7xefnMP2e4P9qwprfifWv7q3RJ3QKKHjMfLy6372JFmexS0m3ksWDRGO07n53C7P1x ZI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770045120; x=1770649920; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=blBZowIYxmGQt/qp8Zqs7qxe8LPuadPVWAo6HXJFncM=; b=Nt8vEZJlidjThU0gT2cFyLkHhK94pONTb2ijNI9izYYr3g4b2e2xCKu/7SMDuVC2NZ MZo5n48Nt0eZ9TMDC25xns+SZo4ASa2Jc52D8pMOOOyyVk482c2QFlwSUZHigas0P+uj uHlhJ3w6Kc6KLYeghE4sREkqzIwCCnzCrD4T3YMy1rASBMjPSUK68m4U4hjYQIatgnNc 9g9iSudamYTND0Vi8IgG/lFZmb71vvuhxenpMEtPUq3V9XIY6rbGaBCvh231OnLoaAZi tA9BaBHBWnYh2KxQsAHUJMgYehHGQLTM7F76KAJ5yfD+ashynoz/V8fj408i9Z5HCP/w IE3g== X-Forwarded-Encrypted: i=1; AJvYcCXlqAsO7c2Tt+NehSXckiYhtv8P5sMUO0OhqQEVD7pH6zPgsOyMyGRqbvQ3wo006l56BxA+A077yVTKgyM=@vger.kernel.org X-Gm-Message-State: AOJu0YyrtD4LLxeXmxVwhMPCio11DOInq7a8xwqu3AhzyKxoCIaFX981 16UWaC6z+Bivn3QT4wP3OEWKHW1rNQz14/eoMeILASRVP2bk1UZrbNQfrUQzI51WLKQ= X-Gm-Gg: AZuq6aIKLyjwxiJ0Z5GUigyxFRdOUC7UpDVBUY1nscVD3DkhKOwYOD6LJ6HDIA4IYfd IUFR5G6OvAJqpyBUfoOr8KCf2vqnY04w8eePoRoQ2fVNjeUMinwDvTJfvH4v9DIbXEON/+3RBo8 qjEHbDZPVZpXzDxjLYiB3rb1p8hPG4fs5RaN2R3Pv5vODSHUJjpAEmAkOf95dxi00acuMU8t6bw U6xJS1YrNMEEyudGcin6DMzwHMRqLXsTalkcF3j74T9zI+fet15IMlKM2umGAU8PS05nMPX46lc N4XMay8Dyff/GXzKOPK4z8EJTU4+CW3X1n42D8Y/3iTEougovOkeUeS+85LDQWePgsgKL6/Q42/ 9lI3B3qZKeW6XQiRuJXjchnESqvPoouwywk4DUTdSqhpIyX0VKUsLvCREDXAW3ZGp62PRDBqbnF /27hf0GQh8DBxRuh5c6J8B778vIPP5wP4JqfnV7YLKcBAI3HdJI322RMrj3meo/rN3C7HAQYw= X-Received: by 2002:a05:6820:1621:b0:663:c86:e9e2 with SMTP id 006d021491bc7-6630f043bb8mr5049423eaf.35.1770045120281; Mon, 02 Feb 2026 07:12:00 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:3695:6954:27c2:42ef? ([2600:8803:e7e4:500:3695:6954:27c2:42ef]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-662f99447b5sm10006110eaf.2.2026.02.02.07.11.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 07:11:59 -0800 (PST) Message-ID: <01eb6fc5-4a71-4877-8a62-ef397a1036c9@baylibre.com> Date: Mon, 2 Feb 2026 09:11:58 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: adc: at91_adc: change at91_ts_sample to return void To: Antoniu Miclaus , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260202115733.21382-1-antoniu.miclaus@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260202115733.21382-1-antoniu.miclaus@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/2/26 5:57 AM, Antoniu Miclaus wrote: > The return value of at91_ts_sample() is never checked by its caller. > Change the return type to void to make this explicit. The error > conditions are already logged via dev_err() which provides sufficient > visibility into hardware issues. > > Signed-off-by: Antoniu Miclaus > --- Reviewed-by: David Lechner