From: Dan Murphy <dmurphy@ti.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
<linux-kernel@vger.kernel.org>, <linux-can@vger.kernel.org>,
<wg@grandegger.com>, <sriram.dash@samsung.com>
Subject: Re: [PATCH linux-can/testing] can: tcan4x5x: Disable the INH pin device-state GPIO is unavailable
Date: Wed, 8 Jan 2020 14:47:42 -0600 [thread overview]
Message-ID: <01f16f0f-cfdf-0a3c-48b1-59e0824c83e8@ti.com> (raw)
In-Reply-To: <afa5c681-bbd1-a6f6-2b58-4f24c924144e@pengutronix.de>
Marc
On 12/29/19 10:05 AM, Marc Kleine-Budde wrote:
> On 12/29/19 4:32 PM, Marc Kleine-Budde wrote:
>> On 12/12/19 5:15 PM, Dan Murphy wrote:
>>> static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
>>> {
>>> struct tcan4x5x_priv *tcan4x5x = cdev->device_data;
>>> @@ -383,8 +393,10 @@ static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
>>> tcan4x5x->device_state_gpio = devm_gpiod_get_optional(cdev->dev,
>>> "device-state",
>>> GPIOD_IN);
>>> - if (IS_ERR(tcan4x5x->device_state_gpio))
>>> + if (IS_ERR(tcan4x5x->device_state_gpio)) {
>>> tcan4x5x->device_state_gpio = NULL;
>>> + tcan4x5x_disable_state(cdev);
>>> + }
>> For some reason, this hunk doesn't apply, due to the additional:
>>
>>>> tcan4x5x->power = devm_regulator_get_optional(cdev->dev,
>>>> "vsup");
> ...which was my fault. :) Please have a look at
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/?h=testing
>
> ...if I've collected every m_can related patch.
Is this still relevant or have you pulled this in?
It looks good to me.
Dan
next prev parent reply other threads:[~2020-01-08 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 16:15 Dan Murphy
2019-12-29 15:32 ` Marc Kleine-Budde
2019-12-29 16:05 ` Marc Kleine-Budde
2020-01-08 20:47 ` Dan Murphy [this message]
2020-01-09 9:13 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f16f0f-cfdf-0a3c-48b1-59e0824c83e8@ti.com \
--to=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®