From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 926ADC43334 for ; Fri, 3 Jun 2022 09:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243096AbiFCJhJ (ORCPT ); Fri, 3 Jun 2022 05:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243086AbiFCJhH (ORCPT ); Fri, 3 Jun 2022 05:37:07 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A05BF4C for ; Fri, 3 Jun 2022 02:37:04 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id a2so5622186lfg.5 for ; Fri, 03 Jun 2022 02:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=FW0OcKetvC+lIk9+vSqmJ/X3hAy+zPwOBgA78zc4X9g=; b=gsfcUH8Mjbs6vjWR6OVLef3RXGt1dL0wLj1g24Hf+pBBKPWb7DigyiRPMOzeFr1u5j VOZA2/5b1K5xxYk40BbIxjpkydmyzWhH1U9Btq6iUH6VWU/APWVbYtRtyESOvZaaw51I +EUA96OYgC2x0/HQ2+mkaO0puaMAaviz878cYidQDovK5uqTOX6sxw5W9rpywSwdGh4P gGl4hSzcNXu6sNniK6+bgPD7StWd26qfR987HhPjqOcWcEdWLPnEk+FD5WnLdL3NMY0t WMVCbGaEZQnxTzW4t+EN/4MZ1LuhnhqTNu92C8hJX6PE3fq0uyCQRmc2LuyjkP2lR7qQ eQHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FW0OcKetvC+lIk9+vSqmJ/X3hAy+zPwOBgA78zc4X9g=; b=KFOYFCy8N8429KEzVs3M0//wg2InYmGz0Um7wVuSsDhVN2EyURlgp5D14qsvWcbBK/ 2N662kdo0BocqJyjL94+s++ETQaAm4fij1fVX3UuiWnzlc33BPRXmTiJmMBY2AcQIIYB FoZExg9OOGqOCu8dqhg71P+fSOT4TMgEhmGwN7yIb8xQeTpqQB4Q3m5Q7jQbLrRK/VmC D6Jf555eisifMPlP+E1O6CbZqxgg/M7Fp8tYUomrSs+oYl+3OPnT4M4K+bXeRbWy1wp5 LQIE31d8Su1iNitt17JHFG9XlY48HelMaRGivaOqGUkcHCc4nfvm7iQzPZtK4dVhsw31 axww== X-Gm-Message-State: AOAM533sc7DehzLnHT3gf0qcxp5vmmw4H9rPbIz9AOe9pRndCQLojSw4 AobJXBX4kmf4VNlfj5Z5Us1z8A== X-Google-Smtp-Source: ABdhPJy0JDZdzd64R/DyMNpsWi27+cupEdKSB8cuAXvobGfOOEW9jK6d7eY1QpJq4wPO2tK0VMchUg== X-Received: by 2002:a05:6512:2251:b0:478:fc67:b09f with SMTP id i17-20020a056512225100b00478fc67b09fmr6087124lfu.196.1654249022539; Fri, 03 Jun 2022 02:37:02 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id d16-20020a0565123d1000b0047255d21132sm1494245lfv.97.2022.06.03.02.37.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jun 2022 02:37:02 -0700 (PDT) Message-ID: <01f88e7a-eeef-d538-634d-bb8e7c1272a0@linaro.org> Date: Fri, 3 Jun 2022 12:37:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [v1] drm/msm: add null checks for drm device to avoid crash during probe defer Content-Language: en-GB To: Vinod Polimera , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, vpolimer@quicinc.com, swboyd@chromium.org, kalyant@quicinc.com References: <1654248167-10594-1-git-send-email-quic_vpolimer@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1654248167-10594-1-git-send-email-quic_vpolimer@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/2022 12:22, Vinod Polimera wrote: > During probe defer, drm device is not initialized and an external > trigger to shutdown is trying to clean up drm device leading to crash. > Add checks to avoid drm device cleanup in such cases. > > BUG: unable to handle kernel NULL pointer dereference at virtual > address 00000000000000b8 > > Call trace: > > drm_atomic_helper_shutdown+0x44/0x144 > msm_pdev_shutdown+0x2c/0x38 > platform_shutdown+0x2c/0x38 > device_shutdown+0x158/0x210 > kernel_restart_prepare+0x40/0x4c > kernel_restart+0x20/0x6c > __arm64_sys_reboot+0x194/0x23c > invoke_syscall+0x50/0x13c > el0_svc_common+0xa0/0x17c > do_el0_svc_compat+0x28/0x34 > el0_svc_compat+0x20/0x70 > el0t_32_sync_handler+0xa8/0xcc > el0t_32_sync+0x1a8/0x1ac > > Signed-off-by: Vinod Polimera Fixes ? > --- > drivers/gpu/drm/msm/msm_drv.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 4448536..d62ac66 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -142,6 +142,9 @@ static void msm_irq_uninstall(struct drm_device *dev) > struct msm_drm_private *priv = dev->dev_private; > struct msm_kms *kms = priv->kms; > > + if (!irq_has_action(kms->irq)) > + return; > + Is this part required with https://patchwork.freedesktop.org/patch/485422/?series=103702&rev=1? > kms->funcs->irq_uninstall(kms); > if (kms->irq_requested) > free_irq(kms->irq, dev); > @@ -259,6 +262,7 @@ static int msm_drm_uninit(struct device *dev) > > ddev->dev_private = NULL; > drm_dev_put(ddev); > + priv->dev = NULL; What are you trying to protect here? > > destroy_workqueue(priv->wq); > > @@ -1167,7 +1171,7 @@ void msm_drv_shutdown(struct platform_device *pdev) > struct msm_drm_private *priv = platform_get_drvdata(pdev); > struct drm_device *drm = priv ? priv->dev : NULL; > > - if (!priv || !priv->kms) > + if (!priv || !priv->kms || !drm) > return; > > drm_atomic_helper_shutdown(drm); -- With best wishes Dmitry