From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbeCMNc1 (ORCPT ); Tue, 13 Mar 2018 09:32:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41942 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752817AbeCMNcY (ORCPT ); Tue, 13 Mar 2018 09:32:24 -0400 Subject: Re: virtio-gpu: Hang on shutdown after suspend/resume with virtio From: Christian Borntraeger To: Gerd Hoffmann , kvm list , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" References: <92144051-e8ac-de5d-3fac-87dfd0e8270b@de.ibm.com> Date: Tue, 13 Mar 2018 14:32:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <92144051-e8ac-de5d-3fac-87dfd0e8270b@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18031313-0040-0000-0000-0000043EFFFC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031313-0041-0000-0000-000020E2327E Message-Id: <01fcd61b-1883-1baa-b0c5-c79b4942ed35@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-13_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803130161 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2018 01:41 PM, Christian Borntraeger wrote: > Gerd, > > another thing with virtio-gpu. > > I can successfully do suspend/resume (echo disk > /sys/power/state) on my system. As soon as I have a > virtio-gpu the system hangs on reboot/shutdown: > > e.g. > > crash> bt 1 > PID: 1 TASK: 6bef0000 CPU: 4 COMMAND: "systemd" > #0 [6beef4c0] __schedule at a55d60 > #1 [6beef530] schedule at a563f2 > #2 [6beef548] virtio_gpu_queue_ctrl_buffer_locked at 7ea708 > #3 [6beef650] virtio_gpu_queue_ctrl_buffer at 7ea830 > #4 [6beef680] virtio_gpu_primary_plane_update at 7ed5ee > #5 [6beef710] drm_atomic_helper_commit_planes at 7a2b46 > #6 [6beef760] vgdev_atomic_commit_tail at 7e9dbc > #7 [6beef790] commit_tail at 7a7126 > #8 [6beef7c0] drm_atomic_helper_commit at 7a73fe > #9 [6beef800] restore_fbdev_mode_atomic at 7aa38a > #10 [6beef8a0] drm_fb_helper_pan_display at 7ab7aa > #11 [6beef8f0] fb_pan_display at 74a248 > #12 [6beef928] bit_update_start at 7573c0 > #13 [6beef958] fbcon_switch at 7542b4 > #14 [6beefa50] redraw_screen at 77b2b8 > #15 [6beefaa0] csi_J at 77b476 > #16 [6beefad8] do_con_trol at 77ee12 > #17 [6beefb40] do_con_write at 77f80c > #18 [6beefc10] con_write at 78003c > #19 [6beefc40] n_tty_write at 7662d4 > #20 [6beefce0] tty_write at 761734 > #21 [6beefd48] __vfs_write at 3483cc > #22 [6beefe00] vfs_write at 3486e8 > #23 [6beefe60] sys_write at 3489de > #24 [6beefea8] system_call at a5b6a8 > PSW: 0705100180000000 000003ff8111251c (user space) > GPRS: 0000000000000000 000003ff00000002 000000000000000e 000003ff80deaef0 > 000000000000000a 0000000000000000 000000000000000f 00000000000003ef > 0000000000000000 000000000000000e 000003ff80deaef0 000000000000000a > 000003ff81228f58 000000000000000e 000003ff81112510 000003fffdefedf8 > > > > > Turns out that the virtio-gpu console (via vnc) prints the image loading but then > stops and show no login prompt. (but agetty is running on tty1) So I assume it > already hangs after resume (and I am working on the serial sclp console). > > Does suspend resume works for you with virtio-gpu on x86? If yes, then I would > not to look into the s390 code (virtio-blk and net seems to work fine). Otherwise now > it would be good if you could have a look. I just checked. It seems that virtio-gpu has no freeze/restore callbacks. Is there some work planned to implement the power callbacks for virtio-gpu?