From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Axel Lin'" <axel.lin@gmail.com>, linux-kernel@vger.kernel.org
Cc: "'Ben Dooks'" <ben-linux@fluff.org>,
"'Russell King'" <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH] ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata
Date: Fri, 18 Feb 2011 18:05:54 +0900 [thread overview]
Message-ID: <01ff01cbcf4b$0e162420$2a426c60$%kim@samsung.com> (raw)
In-Reply-To: <1297651767.13143.3.camel@mola>
Axel Lin wrote:
>
> s3c24xx_ts_set_platdata is annotated __init and not used by any module,
> thus don't export it.
> This patch fixes below warning:
>
> WARNING: arch/arm/plat-samsung/built-in.o(__ksymtab+0x90): Section
mismatch
> in reference from the variable __ksymtab_s3c24xx_ts_set_platdata to the
> function .init.text:s3c24xx_ts_set_platdata()
> The symbol s3c24xx_ts_set_platdata is exported and annotated __init
> Fix this by removing the __init annotation of s3c24xx_ts_set_platdata or
drop
> the export.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> arch/arm/plat-samsung/dev-ts.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/dev-ts.c
b/arch/arm/plat-samsung/dev-ts.c
> index 236ef84..3e4bd81 100644
> --- a/arch/arm/plat-samsung/dev-ts.c
> +++ b/arch/arm/plat-samsung/dev-ts.c
> @@ -58,4 +58,3 @@ void __init s3c24xx_ts_set_platdata(struct
> s3c2410_ts_mach_info *pd)
>
> s3c_device_ts.dev.platform_data = npd;
> }
> -EXPORT_SYMBOL(s3c24xx_ts_set_platdata);
> --
> 1.7.2
>
Ok, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2011-02-18 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 2:49 Axel Lin
2011-02-18 9:05 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01ff01cbcf4b$0e162420$2a426c60$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=axel.lin@gmail.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®