From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbcK1SRd (ORCPT ); Mon, 28 Nov 2016 13:17:33 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35155 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbcK1SR0 (ORCPT ); Mon, 28 Nov 2016 13:17:26 -0500 Subject: Re: [PATCH 1/6] perf tool: Add time-based utility functions To: Jiri Olsa References: <1480109999-36971-1-git-send-email-dsa@cumulusnetworks.com> <1480109999-36971-2-git-send-email-dsa@cumulusnetworks.com> <20161128135832.GB1928@krava> <1edb9bd4-5697-47d4-9ca1-5f359fa00ac4@gmail.com> <20161128181441.GA11055@krava> Cc: David Ahern , acme@kernel.org, mingo@kernel.org, peterz@infradead.org, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org From: David Ahern Message-ID: <020a4b16-91b8-11c4-1db1-8f001737ff66@gmail.com> Date: Mon, 28 Nov 2016 11:17:23 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161128181441.GA11055@krava> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/16 11:14 AM, Jiri Olsa wrote: > there are some time related functions in util.[ch], maybe you > coudl move them as well > > int fetch_current_timestamp(char *buf, size_t sz); > int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz); I'd like to defer that to a follow on patch. I only move parse_nsec_time in this set because there are no other users but the one introduced in patch 1.