From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Ondrej Jirman" <megous@megous.com>, linux-kernel@vger.kernel.org
Cc: "Joel Stanley" <joel@jms.id.au>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"open list:DRM DRIVER FOR ASPEED BMC GFX"
<linux-aspeed@lists.ozlabs.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm: aspeed: Fix GENMASK misuse
Date: Mon, 24 Feb 2020 10:36:47 +1030 [thread overview]
Message-ID: <020e9eb5-4fdc-44d0-b00e-42b6e6435110@www.fastmail.com> (raw)
In-Reply-To: <20200222235152.242816-1-megous@megous.com>
On Sun, 23 Feb 2020, at 10:21, Ondrej Jirman wrote:
> Arguments to GENMASK should be msb >= lsb.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> I just grepped the whole kernel tree for GENMASK argument order issues,
> and this is one of the three that popped up. No testing was done.
I think someone's sent a patch previously, and last time it turned into a
discussion about how the macros aren't actually used and could be
removed.
Regardless:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
next prev parent reply other threads:[~2020-02-24 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 23:51 Ondrej Jirman
2020-02-24 0:06 ` Andrew Jeffery [this message]
2020-10-09 7:47 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=020e9eb5-4fdc-44d0-b00e-42b6e6435110@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megous@megous.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®