From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AF5427A10 for ; Tue, 20 Jan 2026 13:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768915902; cv=none; b=D+L0oPNtEIEUnCT5ZUm1yUb3d0TlHZI/mAJsDxf4qQ1OJuzKNNB6aSSmn5HZl0rHqbiEXhuIyCYiV78DJ/gqV9bh0DVfD7IX8MgjAT2pBYTHALydNK7v+ckPqo0PmipENqv/17T1rULKPvPVl6V0ZjYnySBDb5MCMdxuhynmy9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768915902; c=relaxed/simple; bh=pKiaecLR106cETS89jKSvibc1ARNAkJ+Ib4OsEDFq6U=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=WVzdpL8EJKcJgfTrcIyw6k8+RQRHqzvFurLI4lm3cbnek8NiGvpmwmwUGVlmFtMUuXIcZWXJSe4JhQi7qRL9Adev9QS7XOHb2hG+CjamXr7NZk0aLBKhS1kec5FI3L/mEKr7p8NvrZgXtmhGlxp/aAhAgiubdufDf7zTd4Hdq7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lixblSsd; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lixblSsd" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47ee76e8656so62698065e9.0 for ; Tue, 20 Jan 2026 05:31:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768915899; x=1769520699; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WY2MepLOcFBoPotErcBQzrpiz1/ZQWoYp9n17tDmDMQ=; b=lixblSsdzyEgymfzPAz6J92HAOcHrze6WaUe7H/wb/8oZflkqM7FxLNDq7bbvvQfnq 5pyp6THQETDzFBc3FPWmSJ2WW9otT8q6/xz934PEYTfrlJ6vtGglBQ8RtFdZKcEInTkW Xwr6zreNBTQnsG79+imB9ziI+dweainm7naq/hYFM379REn/bOYhCm9w5+6Udt8RKb0l /A10jnRxrnHrfMb4LtTQornbfjzkf9YSX2f2XoxDwAGPFR+sdZ0thz98fXYgGQOLWbtw GXt5deh2Ww7zwm3QHUGMTwJ7BHWGYQ9JEOYldJExBAq8ffkkCMZH4Drv3zDt2OggLsRh z16g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768915899; x=1769520699; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WY2MepLOcFBoPotErcBQzrpiz1/ZQWoYp9n17tDmDMQ=; b=b1YNxe6P86KX6i8j8uhubEJzeptZn+iMegiUXDTIqBBm4jxkBOhNX4HCw23UsLhsx1 tljWOPh6EvM/FYG8h/Utde03Zx8Uts0HB/cFDgQGicYvi/5NkW6dJMTDQ4i7MH6A5OKD 2awAovbE8ZXUXm+7VHCQJosfTZluC/pWplj6RC7QM9WkejxY1fesbDEsb0i006VdtC9V HDc0sSDNbfRsD5+v06bCQpoI2SsbWutpaKY2RR9RQ2cWixFIFyjF791QWr6BBPfCOumE ELqMSWJxqOlqLR0kVMe0S3qRKdKB2eeTE0SuGS9yKf/N+jYb6Im53/Y0t0m+PYKITkMQ FJBw== X-Forwarded-Encrypted: i=1; AJvYcCX2EjlYy0r9e1bq+qfsEhYwUr8NXlnvauPZgC9zUiS2Vb1aiFUbtVjlGOu3tTyK9u+RqJY5AghNLGWByeg=@vger.kernel.org X-Gm-Message-State: AOJu0YyIq+dO5/Zbxhi2s//Rp3bqh3e9xpyid29iOlu2fz+jsFhNFTuy cUfj+xg2l9PKsOTfUDD8F88heSEiO7Je/QeiE29iExE7m12tRLpWmGkJ X-Gm-Gg: AY/fxX4Ndcmj0PNW9OhWQkplDr92lGcNymoW3+hnq2fdo/tBu4seagaWnQmF02WMioW ng3ndNTCAXhq04V7TJPKIb01itFF00TIfDvHykg3g4fTiPQlwyba7H4VWnYGP3lwLmEL8n8i7Ep kOrGkCQt+dH/Kqw4EFYyOzB+uN2EDGJbhgBvlKOpIuYR6Jie/Ko7twIuUs/JU9A51Ebn+q9kTQC QCZv3NCFimSQZPzR76/Lrey1OcFJfl1ORKY7C0SnG9WcXxqRbnJglfdQl4oPxT/bMHqYsH+8jB1 Z0iRSwNcRGYDz0WAOi9wxjwCOAhFh3l7YtHM9v9TT6uDjE0kvIXe8iM5ALcb4qSQ3QI2qpLfb3M kigkhEYCzHTx53fVNOMOGhnKGZOryr00YZeukVt33gUSp1Jw3M64N0b1ORApmyWzWPE+F13N1HA gQU1liZScVphxCs9NECRVN2EnZkoXW4qFgE90r2lWJYKvnqiTjYdqgJy/hBAmJ/O4zr5wPxoUxf UNYSYyVPrsV/Pg= X-Received: by 2002:a05:600c:620e:b0:47d:73a4:45a7 with SMTP id 5b1f17b1804b1-4803e7e7d75mr25412765e9.24.1768915898715; Tue, 20 Jan 2026 05:31:38 -0800 (PST) Received: from smtpclient.apple (static.253.36.98.91.clients.your-server.de. [91.98.36.253]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fdefed9sm109843355e9.3.2026.01.20.05.31.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2026 05:31:38 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: [PATCH] drm/bridge: dw-hdmi-qp: fix multi-channel audio output From: Christian Hewitt In-Reply-To: <13d33158-b814-4ac1-b8de-ec30ff16c783@collabora.com> Date: Tue, 20 Jan 2026 17:31:22 +0400 Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Detlev Casanova , Douglas Anderson , Andy Yan , Sugar Zhang , Luca Ceresoli , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <021065E9-53DE-40DC-B6FB-CC0AE272FAAE@gmail.com> References: <20251206072718.2039874-1-christianshewitt@gmail.com> <13d33158-b814-4ac1-b8de-ec30ff16c783@collabora.com> To: Cristian Ciocaltea X-Mailer: Apple Mail (2.3864.300.41.1.7) > On 20 Jan 2026, at 4:52=E2=80=AFpm, Cristian Ciocaltea = wrote: >=20 > Hi Christian, >=20 > On 12/6/25 9:27 AM, Christian Hewitt wrote: >> From: Jonas Karlman >>=20 >> Channel Allocation (PB4) and Level Shift Information (PB5) are >> configured with values from PB1 and PB2 due to the wrong offset >> being used. This results in missing audio channels or incorrect >> speaker placement when playing multi-channel audio. >>=20 >> Use the correct offset to fix multi-channel audio output. >>=20 >> Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for = dw-hdmi-qp") >> Reported-by: Christian Hewitt >> Signed-off-by: Jonas Karlman Signed-off-by: Christian Hewitt >> --- >> buffer is a pointer to u8 while data written to PKT_AUDI_CONTENTS >> is u32, so buffer contains audio infoframe header (buffer[0:2]) + >> checksum (buffer[3]) + payload byte 1-10 (buffer[4:13]), e.g. >>=20 >> regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS1, &buffer[3], 1) >> .. will write PB0-PB3 to AUDI_CONTENTS1 >>=20 >> regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[4], 1) >> .. will write PB1-PB4 to AUDI_CONTENTS2, but should be PB4-PB7 >>=20 >> &buffer[4] will point to payload byte 4 not payload byte 1, due >> to u8/u32 and not considering the size of header+checksum (3+1). >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c = b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c >> index f3a13da488e6..7b8a69383dc4 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c >> @@ -845,7 +845,7 @@ static int = dw_hdmi_qp_config_audio_infoframe(struct dw_hdmi_qp *hdmi, >>=20 >> regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS0, &header_bytes, 1); >> regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS1, &buffer[3], 1); >> - regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[4], 1); >> + regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[7], 1); >=20 > Since making use of regmap_bulk_write(), this could be further = optimized as: >=20 > - regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS1, &buffer[3], = 1); > - regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[4], = 1); > + regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS1, &buffer[3], = 2); >=20 > Regardless, >=20 > Reviewed-by: Cristian Ciocaltea >=20 > Please note you also need to provide your SoB, check "Sign your work = ..." > section in [1]. Ahh, I was hoping to just forward Jonas=E2=80=99 patch. If it=E2=80=99s = possible to apply the SoB above when merging, please do. If not I can send a v2 series (someone let me know). Christian > Regards, > Cristian >=20 > [1] = https://www.kernel.org/doc/Documentation/process/submitting-patches.rst