mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jussi Laako <jussi@sonarnerd.net>
To: ilya.pshonkin@netforce.ua
Cc: Sudokamikaze <sudokamikaze@protonmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Allison Randal <allison@lohutok.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Richard Fontana <rfontana@redhat.com>,
	Manuel Reinhardt <manuel.rhdt@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Add Hiby R3 to quirks for native DSD support
Date: Mon, 26 Aug 2019 20:10:28 +0300	[thread overview]
Message-ID: <021132df-8deb-b9f0-2d9e-e934f92c6c7a@sonarnerd.net> (raw)
In-Reply-To: <20190826160953.19402-1-ilya.pshonkin@netforce.ua>

> +	/* ESS Sabre based USB DACs */
> +	case USB_ID(0xc502, 0x0051): /* Hiby R3 */
> +		if (fp->altsetting == 4)
> +			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
> +		break;

Do you know who's vendor id is this? ESS Sabre is a DAC chip with I2S 
input, I'm not aware of any product from ESS under Sabre brand that 
would include USB interface. (?) So likely the USB interface is sourced 
from somewhere else...

It is good to check with "lsusb -vvv" if the device flags DSD altsetting 
as raw. Then you know it'll work with the auto-detection code and 
doesn't break so easily if firmware update changes altsettings (not 
uncommon to happen).


	- Jussi


  reply	other threads:[~2019-08-26 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 16:09 ilya.pshonkin
2019-08-26 17:10 ` Jussi Laako [this message]
     [not found] <DB6PR07MB4296BE759CEDC6F0A6D4E5E3A8A10@DB6PR07MB4296.eurprd07.prod.outlook.com>
2019-08-26 16:12 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=021132df-8deb-b9f0-2d9e-e934f92c6c7a@sonarnerd.net \
    --to=jussi@sonarnerd.net \
    --cc=allison@lohutok.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilya.pshonkin@netforce.ua \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.rhdt@gmail.com \
    --cc=perex@perex.cz \
    --cc=rfontana@redhat.com \
    --cc=sudokamikaze@protonmail.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®