mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tang Bin <tangbin@cmss.chinamobile.com>
To: Felipe Balbi <balbi@kernel.org>, Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] usb: bdc: Remove duplicate error message in bdc_probe()
Date: Mon, 28 Sep 2020 18:55:26 +0800	[thread overview]
Message-ID: <02162cfc-cbe3-4747-e518-7f3b3d7a0e7f@cmss.chinamobile.com> (raw)
In-Reply-To: <87sgb29r3g.fsf@kernel.org>

Hi Balbi:

在 2020/9/28 17:40, Felipe Balbi 写道:
> Hi,
>
> Tang Bin <tangbin@cmss.chinamobile.com> writes:
>> Hi Greg KH:
>>
>> 在 2020/9/27 21:45, Greg KH 写道:
>>> On Sun, Sep 27, 2020 at 09:42:18PM +0800, Tang Bin wrote:
>>>> In this function, we don't need dev_err() message because
>>>> when something goes wrong, devm_platform_ioremap_resource()
>>>> can print an error message itself, so remove the redundant
>>>> one.
>>>>
>>>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
>>>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>>>> ---
>>>>    drivers/usb/gadget/udc/bdc/bdc_core.c | 4 +---
>>>>    1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
>>>> index 02a3a7746..9454f179e 100644
>>>> --- a/drivers/usb/gadget/udc/bdc/bdc_core.c
>>>> +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
>>>> @@ -508,10 +508,8 @@ static int bdc_probe(struct platform_device *pdev)
>>>>    	bdc->clk = clk;
>>>>    
>>>>    	bdc->regs = devm_platform_ioremap_resource(pdev, 0);
>>>> -	if (IS_ERR(bdc->regs)) {
>>>> -		dev_err(dev, "ioremap error\n");
>>>> +	if (IS_ERR(bdc->regs))
>>>>    		return -ENOMEM;
>>> Why not return the error given to us?
>> Because when get ioremap failed, devm_platform_ioremap_resource() can
>> print error message
>>
>> "dev_err(dev, "ioremap failed for resource %pR\n", res)" in it's called
>> function. So I think this's place's
>>
>> dev_err(dev, "ioremap error\n") is redundant.
> that's not what Greg point you at, though. Greg's concern is valid in
> that instead of passing along the error within bdc->regs, you always
> return -ENOMEM. OTW, your code should read like so:
>
> 	if (IS_ERR(bdc->regs))
>          	return PTR_ERR(bdc->regs);

Thanks for your explain,when I send the patch yesterday, my point is at 
dev_err(), and not aimed at IS_ERR() & PTR_ERR(),

if it's Greg's point, I will change this patch after his reply.


Thank you very much.

Tang Bin







  reply	other threads:[~2020-09-28 10:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27 13:42 Tang Bin
2020-09-27 13:45 ` Greg KH
2020-09-28  8:45   ` Tang Bin
2020-09-28  9:40     ` Felipe Balbi
2020-09-28 10:55       ` Tang Bin [this message]
2020-09-28 11:23         ` Greg KH
2020-09-28 11:31           ` Tang Bin
2020-09-28  6:49 ` Chunfeng Yun
2020-09-28  8:40   ` Tang Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02162cfc-cbe3-4747-e518-7f3b3d7a0e7f@cmss.chinamobile.com \
    --to=tangbin@cmss.chinamobile.com \
    --cc=balbi@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®