From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933707AbdKAVS5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 17:18:57 -0400
Received: from mailout.easymail.ca ([64.68.200.34]:53565 "EHLO
        mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933690AbdKAVSz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 17:18:55 -0400
Reply-To: shuah@kernel.org
Subject: Re: [PATCH] selftests/ftrace: Introduce exit_pass and exit_fail
To: Masami Hiramatsu <mhiramat@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Rajvi Jingar <rajvi.jingar@intel.com>,
        Shuah Khan <shuahkh@osg.samsung.com>, Shuah Khan <shuah@kernel.org>
References: <150946150188.23534.2733334352688090372.stgit@devbox>
 <20171031174432.770bd509@gandalf.local.home>
 <20171101132340.f700f0081419897798a4b1f3@kernel.org>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <02195d89-7999-0983-52bf-a0d222e69b38@kernel.org>
Date: Wed, 1 Nov 2017 15:18:41 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171101132340.f700f0081419897798a4b1f3@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/31/2017 10:23 PM, Masami Hiramatsu wrote:
> On Tue, 31 Oct 2017 17:44:32 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> On Tue, 31 Oct 2017 23:51:42 +0900
>> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>>
>>> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
>>> index 74507db8bbc8..b8701fa0b8f2 100644
>>> --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
>>> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
>>> @@ -8,7 +8,7 @@ echo > kprobe_events
>>>  echo p:myevent _do_fork > kprobe_events
>>>  test -d events/kprobes/myevent
>>>  echo 1 > events/kprobes/myevent/enable
>>> -echo > kprobe_events && exit 1 # this must fail
>>> +echo > kprobe_events && exit_fail
>>
>> Should we keep the comment about "this must fail", otherwise it may
>> look like a mistake. Echoing in kprobe_events returns failure here?
> 
> Ah, good catch! I misread the comment is for "exit 1"...
> 
> Thank you,
> 
>>
>> -- Steve
>>
>>
>>>  echo 0 > events/kprobes/myevent/enable
>>>  echo > kprobe_events # this must succeed
>>>  clear_trace
> 
> 

Hi Masami,

Thanks Steve for the catch. I will wait for v2 then.

thanks,
-- Shuah