From: Sekhar Nori <nsekhar@ti.com>
To: Baolin Wang <baolin.wang@linaro.org>,
Franklin S Cooper Jr <fcooper@ti.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>, <linux@armlinux.org.uk>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<grygorii.strashko@ti.com>, <vigneshr@ti.com>
Subject: Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support
Date: Tue, 12 Sep 2017 14:18:08 +0530 [thread overview]
Message-ID: <021a99bb-3670-fff5-6835-b14d28827929@ti.com> (raw)
In-Reply-To: <CAMz4kuLGVes6a4iCF0VbG1ErWPR5at=HKgeGv3cMr1zv7aLzJg@mail.gmail.com>
On Tuesday 12 September 2017 07:28 AM, Baolin Wang wrote:
>> @@ -802,13 +821,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)
>> dev->clk = devm_clk_get(&pdev->dev, NULL);
>> if (IS_ERR(dev->clk))
>> return PTR_ERR(dev->clk);
>> - clk_prepare_enable(dev->clk);
> You removed clk enable here, I think it can not work if we did not
> open CONFIG_PM macro. I think you should keep clk enable here, and set
What do you mean by "open CONFIG_PM macro" ?
> rpm active by pm_runtime_set_active() before issuing
> pm_runtime_enable().
Can you explain why you want to do this instead of relying on
pm_runtime_get_sync() to enable clock?
Thanks,
Sekhar
next prev parent reply other threads:[~2017-09-12 8:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 20:11 [PATCH v4 0/2] i2c: davinci: Add PM Runtime Support needed by 66AK2G Franklin S Cooper Jr
2017-09-11 20:11 ` [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support Franklin S Cooper Jr
2017-09-12 1:58 ` Baolin Wang
2017-09-12 8:48 ` Sekhar Nori [this message]
2017-09-12 9:14 ` Baolin Wang
2017-09-12 9:22 ` Sekhar Nori
2017-10-17 21:46 ` Wolfram Sang
2017-09-11 20:11 ` [PATCH v4 2/2] dt-bindings: i2c: i2c-davinci: Update binding for 66AK2Gx pwr dm property Franklin S Cooper Jr
2017-10-17 21:46 ` Wolfram Sang
2017-09-18 15:58 ` [PATCH v4 0/2] i2c: davinci: Add PM Runtime Support needed by 66AK2G Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=021a99bb-3670-fff5-6835-b14d28827929@ti.com \
--to=nsekhar@ti.com \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®