From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011069.outbound.protection.outlook.com [52.101.62.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E957E36D4E7 for ; Fri, 21 Nov 2025 00:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763684199; cv=fail; b=LZ8dhjUsJwfe4FwYX+RLUoODJuhbW5roEboJ38j7jthTTql25dbyQUBMdIJbojPWe88cpCFZHGD7mTIEXg9FXD1Lp30jC2D0GSMrjf6gkb0qtKPr1hKvtt9DL3ozyI9uab7HObe/ZhUC7I9TeZPmpJYyMWgnutnQmtlo6Nk2fxE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763684199; c=relaxed/simple; bh=r6OmNcvKGRXQuO1wCO0roMBBx9P0fKi3RkfkBeGxmIM=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=N4XC/g0u6TFUFRhYp64CeSpI+3P+cjKdkBOkLWWmW7UqVqBYpP+njb0GBnru4fhIOn8t7Aug4bknwc2hDLIPlYjxZk6HKH6xiKkSrodIvXwLNr+v5BPU+D+JPtOybdWL8C8JhkND5+/RxjOstsb5MhEd9W2DcGYP/bXwvj2khEM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Ow6io0tK; arc=fail smtp.client-ip=52.101.62.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Ow6io0tK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qfnGVNpNE1PAp7HAniyO3PX0xjvzvYi/ZNE4srbcUvGlaWDHwWGcTwjja/zht19iZNVHlEC6wxjViUJjVRbMq35clTtmxby4AdYFPv4mf0d1/2+t75O4OtXDu2fSdx7jq9bJ1NEwAlTSuSOi2kbDoOrq4qxJa68bSG+qQgSmmgS5iiyZ5l8QKdvu+qY+zCG9NG/ZV5RTHjw7S1whB8jxCkWIbPrHCN1nmnr49c+7X+JjLAYTpYI7Ey7ml4JjwVEYfM9llna2wGK5W12YbOSIjQ4F32ZuM7hwxCS+FH3KQ5BNvE0ibJMzXzm2mDm1VEAm7Z/RAWdd6uiRbanC4vDwBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h2vwd1yw4iqvAu3CiROfsYZfFAeO1t0jkl7sT50nxDM=; b=CO4aNMvj/gVDi1cTpPVDhBDjMeU6V2+qJoYMrZUGtr63NEz0Uxrz/v71nbfc09ti7HIMkeHKwQXJ1Cw7lo175I8uUYhBZa5xFjbE45g6zkitSmFDQkdVrcnp6k4XXfWuD3x1qgqdCnTfqP8GUgJYMQ8iRnR03Zm3XE6BdC46p5GCUhlF9xF8rio6eOY6FE8zeRfPv4NXLWAy8nvON86tR/js+LirbQFg3NFOtVRl6aWOC7TEm1duEGsPSMTZqZa+Xz2+JisgnmPFj732r6ELHrGbsOIP1TMmt9SfBVC3oaTGmL+WoQ1XGOsy4zEWtfx08haN8oMbbz8Se7Y11JwIIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2vwd1yw4iqvAu3CiROfsYZfFAeO1t0jkl7sT50nxDM=; b=Ow6io0tKi+gFsIIyogUFzGmmrS8bjNA/NlcUl7HOFc59a8xADfCFqbnrodinkTPhBsp1e9Jo4RIz/VEcYWZSvFH/aPk1rb/j0DZLoNtIv8JSaOc0ecADyy2oJCpRQ165rnu45AGfQwO9D35kGiM2XVfVUEZ8ePaFTWrSTC3vIJG1OCGDL67YosE/ah6OVutLlMr2ROLixQfz09Ho56ab3DdtAJOpQCgjhsvI9Wh3PdjTyfqfaxzTTbWxXs8EkuiKxW2O1Ftuywg2BjF8WpzpMaq2GOH+yd5nYQzPxZDU/4n3wGE54kvwdN6/04lnuqrRUS31qrU66/64CZRtSBwwpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by DS2PR12MB9613.namprd12.prod.outlook.com (2603:10b6:8:276::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Fri, 21 Nov 2025 00:16:32 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8%7]) with mapi id 15.20.9343.009; Fri, 21 Nov 2025 00:16:32 +0000 Message-ID: <021c87cf-03d4-4871-b752-2f2afabf113b@nvidia.com> Date: Thu, 20 Nov 2025 16:16:23 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmalloc: fix build error To: Peng Li , linux-mm@kvack.org, akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, jgg@ziepe.ca, peterx@redhat.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com References: <20251118155034.273696-1-peng8420.li@gmail.com> Content-Language: en-US From: John Hubbard In-Reply-To: <20251118155034.273696-1-peng8420.li@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR05CA0037.namprd05.prod.outlook.com (2603:10b6:a03:33f::12) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|DS2PR12MB9613:EE_ X-MS-Office365-Filtering-Correlation-Id: d0b27ce8-a1d2-4d67-a788-08de28933950 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q3FTSmxRYmJPbm1BZ3FDdG00MVJBay8xanpEM01QQ3RiNDM2MXFuVzdXanZN?= =?utf-8?B?aDc0Q2RrcS9hczFqUTR3cXgvQjlwdjRVV3F1cyt1UC94YzdmQzVPYm4wL2pt?= =?utf-8?B?amF2bW9tZ1VESmwyV2pCVmN0VUtDYVlXd0UwU3pIZnl2SW1lR2JpZDk0MUNs?= =?utf-8?B?ZXJsa1Z0QXVZTHN1UzVKYVluM3prWjlmTXcyM2ZNbWhGQlM4N3hkWSs1eHds?= =?utf-8?B?K1ZpVS9ud0ZsMDEvR3d2dWFob2JPWm1KbmtvaVptVlRkTmpIaXpBdHRMOWhv?= =?utf-8?B?emVXSW1kSGNEU20rRlNnZndqM1RPUWhYOXNxVnZSbXhIWmJzUzFYbjQ2cFR1?= =?utf-8?B?QlgxWFNGbHhCeDJBZGlKY2tReWNQeGpkOEpkdlFzODM5clBiNXpkU1lzcWN2?= =?utf-8?B?c2ZKd2czUndrMW1XRXlCVk5CZXgzYmVhN1FBNDJ6amhubm45ckRaN01SWjNy?= =?utf-8?B?bDBKT0VBUnpGZ2JUWnhHaTFjSGx3ZWc5RnlwOUR1ZDBTL2VQZEMvaWplSllp?= =?utf-8?B?elZyYU5wOTNVSk95ejNIbWJUMmNmSU00SEVWMi9kQ1BSRlloaFBhWGxDcit2?= =?utf-8?B?azByVUprQnUrSzZDRExjYk8zTkllb0pxaEgxaXUxMXhQczlwbGVKNmhySHB1?= =?utf-8?B?SkI1QTJRaThuR3UrTzFDTGl3cVA4WUdsSGEvUDU2c3JlYXlFMlh6UGlZZnlu?= =?utf-8?B?TjVsazVlejA2NFVkTys0eHh2bjQyY2IxZ3kydkRhbVVRcGhNeFhwVkU2a2hO?= =?utf-8?B?N2VGd3FEQ3NZUmJmbEhaTTQ2MkJxRGl5aS9qSnFmb3A3UDhhNkpnc2ZWd0Jt?= =?utf-8?B?ZHVnVTNuckFEOFZDcEI1RWwzNi9kTW9OZTBTVnJqb0NaT3BqZXVmME1JTmxU?= =?utf-8?B?YVhlNCszWGNMbnB3cDlSUDFzcnJXcFRzZm9jYUpTbCtzb2RCY3B4dDZWNzdW?= =?utf-8?B?MzY4aWJzbGM2ZGxMSVc4Y1phSkVyZGQ0bHV3c0puakxXcXExVisvMzdXNWlw?= =?utf-8?B?UmFWVnRLZWo5ZGkzV1h0bm9hL3plbmNNNUlsblFVRmFTN2Rib25vRUVGWlVu?= =?utf-8?B?YVFrc2NRRXhCODdKdFRxMkRFOXp0OXhKSEtmQUp1VUdUdUs3M2IrTStjY0ph?= =?utf-8?B?eFdMcFA4QytuNi8wM1VEQUZFS3VjVlR6Z1pIMnN5UXoxcDBIMWpEK3I3VS9J?= =?utf-8?B?SERaM2dMU2I2ZTFsMDhKQWI3S2xkcm8ycjJWdHdzU2lGSDdxN3IvQnVEWCtD?= =?utf-8?B?MGR0bFNjRnUyOUVHNytMdVpMQXRRNWJOWkp1WU1hL2U4ZS8wc3YzU0Jxb0RU?= =?utf-8?B?R3V6RzA1enJ5bE5STnhPNnM4NkNRSU00OVlxMHczbHhybjB4cmxlM0VUdHhI?= =?utf-8?B?cTR0OXFqaDQxMThNT0JHWmpMMFFoS0ZzenN3ZEVKbnJLZUJ2dVQ2dHU1WldT?= =?utf-8?B?RTgxS1BteE81MEpLci9uTnFhNG1JR1JLaEpkRjFVMm0vazZRMERoTDFYbXZJ?= =?utf-8?B?NnA2MzVTdWt6NWM4ZDhFdXFSTFhtQm1YK1E2QUxoNVlXTzRjQXlQSUJYN3pZ?= =?utf-8?B?UWRFZGtha0p6VndIbWg1dmlaMGtycW9ic284bWxXRlZKS3NqZDE5cnlUcGdB?= =?utf-8?B?UDVaU204ZHYwL2FlVklXeXdmZjVKdmdXRVc4K2lhZVN5cTBmemM0UVFxeGR0?= =?utf-8?B?Ymtqem1CWis0SFRtWVZXUTdtT01QbUpIeTlURXdoSmp2MUxjM3crRmFNa3ZD?= =?utf-8?B?RyttTzk2R3hUVzZjU1hBdGNMTHB4dVVmaWdBRzRWN094em8zdTN0TjVDblZQ?= =?utf-8?B?VTE5aU5taElYNWxwRGtZNGxyL0hEUkZwaEJBclYyeGNWT0dFN2RmUUlRTFRI?= =?utf-8?B?TmczUjlRdDNQNWtvMlQrZXNMc3JsK0JHYjdLRUEraTBFMEd3TFNQd3RiVUFO?= =?utf-8?Q?dov4hy0IyVVkY2iP/Y5yCK2hd7pvT8Rx?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVZPZ3QxSTRzRzJCeFZkZWc3QXVtdlRlaGhLbnljUkY5ZjBiakh4elNmS2g5?= =?utf-8?B?WmVBRUJjenF6aXFlRCtwcjhyK044SnZFNGlKb0dySGtsU3hseGQvR2pIREg0?= =?utf-8?B?UzgzN3oydzZWMmJ3b2NFV0RIbnd4bDduVHVsTWtBOUQyd2JzcTU4VUFhUkNT?= =?utf-8?B?VXFPVDVzamJRVXJraG96dkhUeld0c1ZBRzA1eVBSN0kwTCtBditGSGVXd3k2?= =?utf-8?B?OGE5S1Jrb0pqbWJkS0NYemhqdlZQeHZJVGZXWTArd3BlNDJrTks2alBLS3RZ?= =?utf-8?B?Vi9PZ2hHSjh4ajZDU0RnSWVYRXBtbm15R0NrREVadHRVanR1TnlMUk5uWk14?= =?utf-8?B?TlZQRkpMRWVwY1dyblJRMHllTUtIdnozUTNZLzAvbTk3L0RodWpqYW9sem16?= =?utf-8?B?U3kySFV3a3RUMFF5eDE1RXpJaXFoNjRHU3BjYlk3dVZDSVNHN2lFZEhDejFJ?= =?utf-8?B?aGxRWi84eDFmYWdoZ1V6dFlrT1kyam1SejUrUHltL09XZlRqSWhzZk8rVjdE?= =?utf-8?B?NGtvT3ZrdVJORkpveTdlaUJXQ2VNQ0QvOGViNWU1VW5CUDVKT05SeE1Wdmw0?= =?utf-8?B?c0hxMDk1RTZycjdhMjZodkQ0amNHZGRLZUR2TVB6ZVRNZFBMQXdDUHdPaGlB?= =?utf-8?B?ZWp5QTVpWjhHUFJpY2dJcDd5bFMzZHh1QWFib3JRZkF4Umd1cE5YQTkzWWdn?= =?utf-8?B?S3RBODBnbDlGMm85NEtjQXN2WE43WnpSQUsvYXFSUzlUVzlDZVlmYlpYbzZP?= =?utf-8?B?RzBqNkVCRk1FY1lqSWxuOTlDK2FVTnRPVkFSVDI5VVFZUUhoa05tT0pFTVNV?= =?utf-8?B?NnNrbE0vWVpkRkJDTXNxTDNuajhpK2U4QlUyYkNueXBhTjFEVWcxaytUQ1FD?= =?utf-8?B?YkVHRFMzUk1FMzhPdTNnZTh5WlVqdzFLQ205MkYrWkttUjFQSVh3MHMvYmE2?= =?utf-8?B?b2lpNjNmSXlNU3NNYWs2T1c2UTc1SmJqckphM1hMdThtWC82TGc0cjNsZDJt?= =?utf-8?B?VnlKV25UZ1NXa0Y4ODBZM0xSS1BpL2dOWDJtMHBHM0tFQmZSQ0w4MEJhZjFO?= =?utf-8?B?K0RpdjFOcEVHdFNFUnpJVHFtbWFkR29yVkZXbmR2RVNpampvc21GbEpiK3FW?= =?utf-8?B?Wi90aENHNWwyWkU3bVZTWDVETW5KYnFnUzF5R1ZFZUplRnJWUlExbWxHbVVt?= =?utf-8?B?NW53dUc4T1FqRmpxVGhVTEsydWI3eHRVNi9SdXlEZlpMbzUwMUNFc05wT01F?= =?utf-8?B?NUlPaE1LTXpoQmswajNpQzhiT2ZwZUNxdDV4c0ZsRDR1WEw0V1lpOXhYOVoz?= =?utf-8?B?M204TmQ1RTJhNzlvNkxhTFdUQm42TUNTVGwwSjcxTTQrUUJVK2szRHFnSWRk?= =?utf-8?B?VDhuTFErYWRVa2hNMVhiQndvTDFVWktEazZlVzZaaGZZeC9LZDFZbEJ4dUdS?= =?utf-8?B?ejUzTnF3QVlvMW9JT0MyT3kxSGxpdXBNWmZ0aWo4dm00UFp3N0k1T0M0TzRw?= =?utf-8?B?YzFqcm5lcHc5SmlyUUN2M0FUOU5tRk5abkh2UnpXTUZlVDgrSDBkRWk1WkFG?= =?utf-8?B?NFJndEswNkVnaDB3Q1Q0VXVCU2FiSTJHYjhvSEhRODdxZjJSbDc3Z2UvZWpS?= =?utf-8?B?OGtqN2EwUkhUeDZ5TmZZNDJrVU4ySVJQR3MxR2JUeER2UU1vZ0lFU3VERWRF?= =?utf-8?B?aDFUWWg4aHhtKzNoeUhwWmhJRHJjRjNJSi8xakhqdUlheFdWMUU5VUpFdlNS?= =?utf-8?B?aVY1T0JXRGFXd05Ta3ozZkhmWmdGWW9aN0hOU1hocEE1aGFoc2didmhCbi9i?= =?utf-8?B?bHRZYnc2ckVoeE10ei8wazF1VGp6UUExdzdpODhHL3ZCdzVUbDVkZlJIaTZ3?= =?utf-8?B?WDE5bUMrblpaUzVVUlVyVlFObkszRGRvTGVCZGgvbE1sSEwxQzRtUkVBY0VT?= =?utf-8?B?ZjZ4ellLWjU1cy9PV1V0NTFEVHFMT25ETmFpRis0NGMrSkhQMWlHdi9Ycjl2?= =?utf-8?B?cDNBcHZSRUE1aVNTclA1SDNPeHJqK2VJQzV2c3ZJMk9OSnVxbWZwVlcwdjVn?= =?utf-8?B?TWFMWlVwVzJCYU0waGoyUXF2ditPNVpaNFVvdUlKN2M4ekFMMHQ4QytnYU5Q?= =?utf-8?Q?WQ26VBzvuxilsthLBrjOP0Swp?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0b27ce8-a1d2-4d67-a788-08de28933950 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2025 00:16:32.1927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I9zCJNUR/MAfeWyg6jCgVqBw6S5Wm3qmCVT0WXtVobQ8w/umWeSro4KDHjWgQ4RBRgswiMm7VIaNdXh4ei32jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9613 On 11/18/25 7:50 AM, Peng Li wrote: > From: Peng Li > > commit 056b93566a35 ("mm/vmalloc: warn only once when vmalloc > detect invalid gfp flags") modify the function call from WARN to WARN_ONCE. > > WARN_ONCE input parameter format error, missing ',' tag. > Resulting in the following compilation errors: > > mm/vmalloc.c:3940:19: error: expected ‘)’ before ‘invalid_mask’ > 3940 | invalid_mask, &invalid_mask, flags, &flags); > > After adding the "," tag, the compilation passed. > > Signed-off-by: Peng Li > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: John Hubbard thanks, -- John Hubbard > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d78c4d09d6ea..0469ba2c230e 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3936,7 +3936,7 @@ static gfp_t vmalloc_fix_flags(gfp_t flags) > gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED; > > flags &= GFP_VMALLOC_SUPPORTED; > - WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n" > + WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n", > invalid_mask, &invalid_mask, flags, &flags); > return flags; > }