From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9EFC3A5A1 for ; Thu, 22 Aug 2019 08:18:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26EA02377B for ; Thu, 22 Aug 2019 08:18:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="ppDED/Us" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732231AbfHVISl (ORCPT ); Thu, 22 Aug 2019 04:18:41 -0400 Received: from mail-eopbgr730052.outbound.protection.outlook.com ([40.107.73.52]:43936 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726262AbfHVISk (ORCPT ); Thu, 22 Aug 2019 04:18:40 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RvfFWfDffnNCBi0lBiH7yTwroALkSLJGHbfd6C5sFhLcIPICf1Q+poHMbfKRsDSs8iLCGmczPPmmuD3veUnScIn1XLjYbphtfZrSNN45yhOele98Ul8iZ5ijN+lCRDAIFCJ5aNeIS4KPWlvgy8Gw+dWIBK3Gb7aYTmmbEfEx99r7imjzWsYObgOhi+Jhx1nVaCf7MSjZB4G2F+LfPyQZVTGauK7wpWaz62dgrYmuVUy1kqzzwUCD47tdZ2ljk4ZAbcGs9S5cM2ObNO5LCJ8uatvNmZs85CeHCdZQDWlTQn1XVid+EyiSEe6JTu6Pf8JY9GnZvx1f5gcHmh6sQtc7tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bu7vELTQk1IhUwoDgNE5WLS9pb1I08Z8jEelGuKSKgg=; b=Jey7y3RHwIuoc3iicZqynlynMmPp0MDjyD7bQ+4aXFIJYVisAQbOXEu0F4gM2Ywo1SwyVBe7iZXFS9iWzZxjKaBUwLbscq6INoBrA/Iwf3+1cZ5lIkpZaXdWrhvmatuarutmnyO97pRLOMf7WsoJ6n8JC4Bl4+XoSKRwAuKAGjVw2c3+Fx/DQi5olh6YccIzk/OD5CMny9sB6ApnNLrzmjnLkP04DGSG+lKgWI3LRqP3Q+ApMGCT9LeP/WVRshA/sXrjPZ/8dviVsRqkzK5DYGgunVhR8XOmrYgzVQoJb7BTHgvAq1iXXou1YYA0G96LuBM2J2HnnWEHhbdHpfRXVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.100) smtp.rcpttodomain=oracle.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bu7vELTQk1IhUwoDgNE5WLS9pb1I08Z8jEelGuKSKgg=; b=ppDED/UsXSIl0LFbbyMUGQ/1t2Utdd2dVg0WVgouJqR74EqtNSit1mXHjsJEN4gWLubtf4sxRrTb5svanxRWa7Gs/6xIyuaPUWwh8SXIfYBQwVDYrynSDbioAq8dfHAZ+GhTMHSuWrR2b/IWsJsHJnQ4OJjqJYaTaAVvOetJBd8= Received: from BL0PR02CA0053.namprd02.prod.outlook.com (2603:10b6:207:3d::30) by DM6PR02MB4043.namprd02.prod.outlook.com (2603:10b6:5:9f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Thu, 22 Aug 2019 08:18:34 +0000 Received: from CY1NAM02FT057.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::207) by BL0PR02CA0053.outlook.office365.com (2603:10b6:207:3d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16 via Frontend Transport; Thu, 22 Aug 2019 08:18:33 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT057.mail.protection.outlook.com (10.152.75.110) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2178.16 via Frontend Transport; Thu, 22 Aug 2019 08:18:33 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:49208 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1i0iIi-0008Et-Jd; Thu, 22 Aug 2019 01:18:32 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1i0iId-0003tT-Gd; Thu, 22 Aug 2019 01:18:27 -0700 Received: from xsj-pvapsmtp01 (smtp-fallback.xilinx.com [149.199.38.66] (may be forged)) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id x7M8IM6j005211; Thu, 22 Aug 2019 01:18:22 -0700 Received: from [172.30.17.116] by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1i0iIY-0003sv-Hz; Thu, 22 Aug 2019 01:18:22 -0700 Subject: Re: [PATCH 3/4] misc: xilinx_sdfec: Prevent a divide by zero in xsdfec_reg0_write() To: Dan Carpenter , Derek Kiernan , Dragan Cvetic Cc: Arnd Bergmann , Greg Kroah-Hartman , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20190821070953.GC26957@mwanda> From: Michal Simek Message-ID: <022ae855-828a-9a0e-18fd-73f8c1424dc9@xilinx.com> Date: Thu, 22 Aug 2019 10:18:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190821070953.GC26957@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(396003)(346002)(376002)(136003)(2980300002)(199004)(189003)(44832011)(81166006)(230700001)(54906003)(58126008)(110136005)(2616005)(106002)(52146003)(486006)(476003)(446003)(11346002)(126002)(23676004)(316002)(31686004)(2486003)(14444005)(4326008)(6246003)(305945005)(76176011)(70586007)(70206006)(26005)(356004)(186003)(426003)(336012)(65956001)(8936002)(50466002)(36756003)(65806001)(5660300002)(47776003)(8676002)(2906002)(6636002)(81156014)(36386004)(478600001)(229853002)(9786002)(31696002)(42866002)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR02MB4043;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;LANG:en;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e189d19-f43b-46d8-6a1d-08d726d952cf X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(711020)(4605104)(4709080)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328);SRVR:DM6PR02MB4043; X-MS-TrafficTypeDiagnostic: DM6PR02MB4043: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 01371B902F X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: rFk4518t+alt3y4/uVTD+W4Fb0IIuMXZ0l1dQDYbFRWKZEK6/Y0sMisnbZJJPddDwZk6krIhcwsIDL+c0hBVS47pr5APPYgTNTx7X03x2dqzEMNxjhWXwHqevzky4JisQrDBJSEs3LZ9i9jCZY8BVHXPp4b9hyAZBnhNvgoPSqOJ1J9ue4UGNN0JgCrPmY+Iyq94jC6/rvx6ts7N1xN2IgGOXN7dd09smz+LYhx+clD+uIuayZEmf7gCGjFR26ojJjLphSqYBykx7fq2hkAw6XYmGNw94E+KSF8+L027C5svXCcAXGHzlD8TJ4E1ybFD59vTj/z5nS/kbZsHpyclHOQgBAvI+rUZL+k3JvlytxZop27UWz33YyPEOx/Rtym9EKTR2Hw+D/9xBwltKjVagIsio9xToqXS6fBIdIROs1I= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2019 08:18:33.1514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e189d19-f43b-46d8-6a1d-08d726d952cf X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4043 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21. 08. 19 9:09, Dan Carpenter wrote: > The "psize" value comes from the user so we need to verify that it's > non-zero before we check if "n % psize" or it will crash. > > Fixes: 20ec628e8007 ("misc: xilinx_sdfec: Add ability to configure LDPC") > Signed-off-by: Dan Carpenter > --- > The parentheses in this condition are a no-op. They're just confusing. > Perhaps something else was intended? > > drivers/misc/xilinx_sdfec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > index 813b82c59360..3fc53d20abf3 100644 > --- a/drivers/misc/xilinx_sdfec.c > +++ b/drivers/misc/xilinx_sdfec.c > @@ -460,7 +460,7 @@ static int xsdfec_reg0_write(struct xsdfec_dev *xsdfec, u32 n, u32 k, u32 psize, > { > u32 wdata; > > - if (n < XSDFEC_REG0_N_MIN || n > XSDFEC_REG0_N_MAX || > + if (n < XSDFEC_REG0_N_MIN || n > XSDFEC_REG0_N_MAX || psize == 0 || > (n > XSDFEC_REG0_N_MUL_P * psize) || n <= k || ((n % psize) != 0)) { > dev_dbg(xsdfec->dev, "N value is not in range"); > return -EINVAL; > Reviewed-by: Michal Simek Thanks, Michal