From: linmiaohe <linmiaohe@huawei.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hare@suse.de" <hare@suse.de>
Subject: Re: [PATCH] block: Fix potential page reference leak in __bio_iov_append_get_pages()
Date: Wed, 9 Sep 2020 07:21:29 +0000 [thread overview]
Message-ID: <022b3453c5bf4bbf9fcee79770e0389a@huawei.com> (raw)
Johannes Thumshirn <Johannes.Thumshirn@wdc.com> wrote:
>On 05/09/2020 11:41, Miaohe Lin wrote:
>> When bio_add_hw_page() failed, we left page reference still held in pages.
>
>I'd add "from iov_iter_get_pages()" to the above sentence.
>
Sounds good. Will add it in v2.
>Otherwise
>Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Many Thanks for review.
next reply other threads:[~2020-09-09 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 7:21 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-05 9:40 Miaohe Lin
2020-09-09 7:09 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=022b3453c5bf4bbf9fcee79770e0389a@huawei.com \
--to=linmiaohe@huawei.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®