From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: <zhouxianrong@huawei.com>, <linux-mm@kvack.org>
Cc: <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
<viro@zeniv.linux.org.uk>, <mingo@redhat.com>,
<peterz@infradead.org>, <hannes@cmpxchg.org>,
<mgorman@techsingularity.net>, <vbabka@suse.cz>,
<mhocko@suse.com>, <vdavydov.dev@gmail.com>, <minchan@kernel.org>,
<riel@redhat.com>, <zhouxiyu@huawei.com>,
<zhangshiming5@huawei.com>, <won.ho.park@huawei.com>,
<tuxiaobing@huawei.com>
Subject: Re: [PATCH] bdi flusher should not be throttled here when it fall into buddy slow path
Date: Tue, 18 Oct 2016 17:34:41 +0800 [thread overview]
Message-ID: <022d01d22922$dad86f90$90894eb0$@alibaba-inc.com> (raw)
In-Reply-To: <1476774765-21130-1-git-send-email-zhouxianrong@huawei.com>
> @@ -1908,7 +1908,7 @@ void wb_workfn(struct work_struct *work)
> long pages_written;
>
> set_worker_desc("flush-%s", dev_name(wb->bdi->dev));
> - current->flags |= PF_SWAPWRITE;
If flags carries PF_LESS_THROTTLE before modified, then you
have to restore it.
> + current->flags |= (PF_SWAPWRITE | PF_BDI_FLUSHER | PF_LESS_THROTTLE);
>
> if (likely(!current_is_workqueue_rescuer() ||
> !test_bit(WB_registered, &wb->state))) {
> @@ -1938,7 +1938,7 @@ void wb_workfn(struct work_struct *work)
> else if (wb_has_dirty_io(wb) && dirty_writeback_interval)
> wb_wakeup_delayed(wb);
>
> - current->flags &= ~PF_SWAPWRITE;
> + current->flags &= ~(PF_SWAPWRITE | PF_BDI_FLUSHER | PF_LESS_THROTTLE);
> }
>
thanks
Hillf
next prev parent reply other threads:[~2016-10-18 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 7:12 zhouxianrong
2016-10-18 9:34 ` Hillf Danton [this message]
2016-10-18 9:59 ` Mel Gorman
2016-10-18 11:08 ` zhouxianrong
2016-10-18 11:42 ` Michal Hocko
2016-10-20 12:38 ` zhouxianrong
2016-10-20 13:05 ` Mika Penttilä
2016-10-20 13:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='022d01d22922$dad86f90$90894eb0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tuxiaobing@huawei.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=won.ho.park@huawei.com \
--cc=zhangshiming5@huawei.com \
--cc=zhouxianrong@huawei.com \
--cc=zhouxiyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome