From: Andrew Lunn <andrew@lunn.ch>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: isdn@linux-pingi.de, ricardo@marliere.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] CAPI: return -ENOMEM when kmalloc failed
Date: Thu, 14 Mar 2024 04:17:33 +0100 [thread overview]
Message-ID: <022e6eb0-2fc7-4115-b5b8-046084d845fe@lunn.ch> (raw)
In-Reply-To: <20240314020103.54049-1-jiapeng.chong@linux.alibaba.com>
On Thu, Mar 14, 2024 at 10:01:03AM +0800, Jiapeng Chong wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to specify
> that a buffer allocation failed.
>
> drivers/isdn/capi/capi.c:154 capiminor_add_ack() warn: returning -1 instead of -ENOMEM is sloppy.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8522
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
The patch itself looks reasonable. The caller only cares about is the
return code negative or not. So returning -ENOMEM or -1 makes no
difference.
Please take a look at:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
You need to specify a tree you want this merged via.
If you consider this a fix, you need to add a Fixes: tag. However, i
don't see this patch meeting stable requirements.
If this is just normal development, net-next is closed at the moment
for the merge window. Please repost in two weeks time.
Andrew
prev parent reply other threads:[~2024-03-14 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 2:01 Jiapeng Chong
2024-03-14 3:17 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=022e6eb0-2fc7-4115-b5b8-046084d845fe@lunn.ch \
--to=andrew@lunn.ch \
--cc=abaci@linux.alibaba.com \
--cc=isdn@linux-pingi.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ricardo@marliere.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®