mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luigi Santivetti <luigi.santivetti@imgtec.com>
To: Gyeyoung Baek <gye976@gmail.com>,
	Alessio Belle <alessio.belle@imgtec.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: Alexandru Dadu <alexandru.dadu@imgtec.com>,
	Brajesh Gupta <brajesh.gupta@imgtec.com>,
	Frank Binns <frank.binns@imgtec.com>,
	<imagination@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] drm/imagination: Switch the GPUVM to immediate mode
Date: Tue, 17 Nov 2026 09:27:50 +0000	[thread overview]
Message-ID: <023177c465539fa87c8ff08ab0ea5051e75547d8.camel@imgtec.com> (raw)
In-Reply-To: <20261011-pvr-gpuvm-immediate-v2-0-744ddc6644c3@gmail.com>

Hi Gyeyoung,

Thank you for these patches, and sorry for the slowness in responding. These two
seem okay to me - I also run IGT.

What I can do is to kick a run of CTS with them applied while I'll look at the
series for adding the VM bind ioctl.

Thanks,
Luigi

On Sun, 2026-10-11 at 18:45 +0900, Gyeyoung Baek wrote:
> Switch the GPUVM to immediate mode, as a prerequisite for asynchronous
> VM_BIND. A revised VM_BIND series will follow separately; v1 [1] is
> linked only for context.
> 
> The switch also fixes an issue Sashiko reported on [1]: the GPUVA lists
> of other objects are updated without holding their reservations [2].
> 
> Based on drm-misc-fixes (depends on 196d4d10c1b3).
> 
> Tested on BeagleY-AI with lockdep, KASAN and failslab enabled:
> - All IGT imagination tests pass, including pvr_vm_map [3].
> - The fail-nth reproducer in patch 1 no longer warns.
> 
> [1] https://lore.kernel.org/r/20260817-pvr-vm-bind-v1-0-0a0f21be7d38@gmail.com
> [2] https://sashiko.dev/#/patchset/20260817-pvr-vm-bind-v1-0-0a0f21be7d38@gmail.com?part=1
> [3] https://lore.kernel.org/igt-dev/20260930125057.1837788-1-gye976@gmail.com/
> 
> Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
> ---
> Changes in v2:
> - Patch 1: drain the vm_bo that fini() deferred when map_init() fails.
>   (Sashiko)
> - Link to v1: https://patch.msgid.link/20261011-pvr-gpuvm-immediate-v1-0-5b298dfce4f8@gmail.com
> 
> ---
> Gyeyoung Baek (2):
>       drm/imagination: Switch the GPUVM to immediate mode
>       drm/imagination: Stop locking reservations around map and unmap
> 
>  drivers/gpu/drm/imagination/pvr_vm.c | 82 +++++++++++++-----------------------
>  1 file changed, 30 insertions(+), 52 deletions(-)
> ---
> base-commit: 6ccf996a0dec1852dab94ad865f27b4904750e12
> change-id: 20261011-pvr-gpuvm-immediate-f7ea8edc2e7f
> 
> Best regards,
> --  
> Gyeyoung Baek <gye976@gmail.com>
> 


      parent reply	other threads:[~2026-11-17  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11  9:45 Gyeyoung Baek
2026-10-11  9:45 ` [PATCH v2 1/2] " Gyeyoung Baek
2026-10-31 16:44   ` Gyeyoung Baek
2026-10-11  9:45 ` [PATCH v2 2/2] drm/imagination: Stop locking reservations around map and unmap Gyeyoung Baek
2026-11-17  9:27 ` Luigi Santivetti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=023177c465539fa87c8ff08ab0ea5051e75547d8.camel@imgtec.com \
    --to=luigi.santivetti@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=alessio.belle@imgtec.com \
    --cc=alexandru.dadu@imgtec.com \
    --cc=brajesh.gupta@imgtec.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=gye976@gmail.com \
    --cc=imagination@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®