From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 526E1CCA480 for ; Sat, 16 Jul 2022 07:13:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbiGPHN0 (ORCPT ); Sat, 16 Jul 2022 03:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiGPHNY (ORCPT ); Sat, 16 Jul 2022 03:13:24 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C3531A38E; Sat, 16 Jul 2022 00:13:21 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LlK995nTnzVfmC; Sat, 16 Jul 2022 15:09:33 +0800 (CST) Received: from dggpemm500019.china.huawei.com (7.185.36.180) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 16 Jul 2022 15:13:18 +0800 Received: from [10.67.109.184] (10.67.109.184) by dggpemm500019.china.huawei.com (7.185.36.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 16 Jul 2022 15:13:18 +0800 Subject: Re: [PATCH bpf-next v2 0/3] Use lightweigt version of bpftool To: Quentin Monnet CC: bpf , Networking , open list , Alexei Starovoitov , "Daniel Borkmann" , Andrii Nakryiko , "Martin KaFai Lau" , Song Liu , Yonghong Song , John Fastabend , KP Singh , Jean-Philippe Brucker References: <20220714024612.944071-1-pulehui@huawei.com> <21cec7bd-e4fb-73f7-a6a6-7f52c03ae7e9@isovalent.com> From: Pu Lehui Message-ID: <0235c3d5-30dd-8c80-b532-00c1590bbb58@huawei.com> Date: Sat, 16 Jul 2022 15:13:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <21cec7bd-e4fb-73f7-a6a6-7f52c03ae7e9@isovalent.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.184] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500019.china.huawei.com (7.185.36.180) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/16 1:15, Quentin Monnet wrote: > On 15/07/2022 17:56, Andrii Nakryiko wrote: >> On Wed, Jul 13, 2022 at 7:16 PM Pu Lehui wrote: >>> >>> Currently, samples/bpf, tools/runqslower and bpf/iterators use bpftool >>> for vmlinux.h, skeleton, and static linking only. We can uselightweight >>> bootstrap version of bpftool to handle these, and it will be faster. >>> >>> v2: >>> - make libbpf and bootstrap bpftool independent. and make it simple. >>> >> >> Quentin, does this patch set look good to you? > > [Apologies, the mail server has been filtering Pu's emails as spam for > some reason and I had missed the discussion :s] > > Looks OK to me: > Acked-by: Quentin Monnet > > Although I'm a bit sorry to see the sharing of libbpf between bpftool > and libbpf go away. But OK. We can maybe reintroduce it through > bpftool's Makefile or a separate include Makefile in the future. > > Quentin > . Hi, Quentin, so much thanks for your review and ack. and apologies for not receiving your advice in time due to the misconfiguration of mail server[0]. and looking forward to your improvement for bpftool. [0]https://lore.kernel.org/all/20220523152516.7sr247i3bzwhr44w@quack3.lan/ >