Re: [PATCH v5 0/3] arm64: dts: qcom: add dts for sa8540p-ride board

[Konrad Dybcio <konrad.dybcio@somainline.org>]

On 03/10/2022 14:54, Parikshit Pareek wrote:
> Change in v5:
> - Moved the usb and ufs nodes from sa8540p-adp.dtsi file to respective
>    board specific dts files: sa8295p-adp.dts and sa8540p-adp-ride.dts.

Is there any benefit in this? USB0/2 and UFS (not UFS card) nodes are 
identical

in the 2 files.


Konrad

>    Took inputs from Shazad Hussain in this regard(John)
> - Added more description of the board differences(John)
> - Not including Reviewed-by for Krzysztof, because of the new changes to
>    be reviewed.
> - Removed Reported-by tag(John).
>
> Changes in v4:
>   - Removed the ufs_card_hc node, as it is not mounted on Qdrive-3 board.
>   - Removed usb_1 relared nodes, as usb1 doesn't have any port connected on
>     Qdrive3 board.
>   - Added Reported-by tag for Shazad(for ufs and usb_1 node removals)
>
> Changes in v3:
>   - Added Acked-by tag (Krzysztof)
>   - Renamed dtsi to sa8540p-adp.dtsi (John)
>   - Removed copyright from sa8295-adp.dts and sa8295-adp.dtsi(John)
>   - Added cover letter
>
> change in v2:
> - Make dt-binding patch as the first one in the patch set
> - Add , after year 2022, in the license header
>
> Initial version:
> - Move the common nodes to sa8540p-adp.dtsi, and create qrive-3 board
>    specific file sa8540p-adp-ride.dts.
>
>
> Parikshit Pareek (3):
>    dt-bindings: arm: qcom: Document additional sa8540p device
>    arm64: dts: qcom: sa8295p: move common nodes to dtsi
>    arm64: dts: qcom: introduce sa8540p-ride dts
>
>   .../devicetree/bindings/arm/qcom.yaml         |   1 +
>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   arch/arm64/boot/dts/qcom/sa8295p-adp.dts      | 528 +++++-------------
>   arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts |  71 +++
>   .../{sa8295p-adp.dts => sa8540p-adp.dtsi}     | 133 -----
>   5 files changed, 219 insertions(+), 515 deletions(-)
>   rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (70%)
>   create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
>   copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (72%)
>