From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 507C31E495 for ; Fri, 24 Jan 2025 06:13:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737699228; cv=none; b=EvI0Fc6XzZAw0JjRss2heuxZtA9rvXmoVfa05ZQwiPADi79AEK9k4fi7200X1ooXBet4+SD/DUbk+78eTFXH7kNycpt7DYKACDpGaL54p/7VMaH/cLm5kw/xiMX13ehotH/7xJW2vF8p1TYAbtomuj78aAn9uiAB2C5+jqGKf0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737699228; c=relaxed/simple; bh=YFp2Z+t7xRk8x6Kl4lGeCcICjLIDtCSj1ebVoHWStQ8=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=Ngs255QfwwPTb/S4Iwso5O5Fqr0sioYmKiIIN9SXvq1gjHQJ8wFC8Nx1+hPIJwvwElttx0ovXM0f8mUwExWdLr0BJqwBsdqGaTRtnQJgcLPTJeve76CYsXS3oyXOFx+Y6XNVKLSExT36Wua77PLcv5gXPDQjflaZyf8cMzvamHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Px4YBk9W; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Px4YBk9W" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50O1LJZk022865 for ; Fri, 24 Jan 2025 05:53:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pBPYiLdDRBIgHv762UtSJ+rwIwHEn2m5Ux7Jpgicu1A=; b=Px4YBk9WlcwPI82I lRe6/pRpKzevtY4sqsHQFpRb8Z9kE2oPHAA+M458Rn04sg/oPQsP8OxxxZFNl2nB OmDdPG1XBds6qdS+GYKuxpsLBRQzOoCvVDZ3EgnEfQffCHFvMbKGvNOFe4Lrl42m Y6nvmdOfYwAgayCjG6+X/5s3TwUdIajJGD4Amm3zkMymSfr8Cg3HzrGCuk4YyKmd EJBfI+aBiSXpOrlxh9hc+6+NjIREkJYkyb6xVlN6wFK6SJijepLdZTu8jMAFdN4Z Vj2jGOF40EtrBdFUHK+sYOSR2vNGYDZ6NuwrozpkvUBEtc/w3Fqcxv2R/bP+h8sM /XJX8Q== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44c147rg5w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 24 Jan 2025 05:53:08 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2165433e229so34880515ad.1 for ; Thu, 23 Jan 2025 21:53:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737697987; x=1738302787; h=content-transfer-encoding:in-reply-to:cc:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pBPYiLdDRBIgHv762UtSJ+rwIwHEn2m5Ux7Jpgicu1A=; b=vs854ppnFR/C1BMnkapAyprr38+VtsrnUzDfrUM3L4kybLWX0p8PMe8AUj8IjETItS H4l1LtuFqQONqcCyBjlYCzlgqfw44G+eI6rUXVJsY6in0qsjhTR7WmIzzttIx3Hh04Yy gMINVyR1VLRpfGOd8ODVbPBFDEJbr0jUUeJvvnQM4d6vPdZqhn3D9tXrmIvovbdnRg6Z RGveo+U4pco3r9Hf/xY3ctb9P2cTcL/fedYxxu2y57/YsWZo4a7PvLS9GcOSR7UBHTFN syTyu/ij2uaLaunpqaO9DJwSKmAsnjmW5eQSrsYdngcH2jDbxrKNxBjWDAIlW6s2XBy1 MrwA== X-Forwarded-Encrypted: i=1; AJvYcCWTDgoUCmJVX4Q5QlNOGH5KBDVYlETA1Jkb19TkVALGJeJzZE5EIA6saLiXI7i04e8w5g7Sp5HWamaSe3s=@vger.kernel.org X-Gm-Message-State: AOJu0YwSEX7YryfpeessWII0ZFmjtV60DKGCN6ihrXOmajPTxU//SFSt xI48Nbe0xQAQt6PLw/EQXnIk7sLeMN3ux6ixj5bjDM1we7T7LAUpV4sSsdMTQNTK6EbiyL36Jba z0RNY/5KzcsElYveaIsMxZ52/t12ttHAD5omXPD3fdVFuC4bUYIE3aG5X748MQ0s= X-Gm-Gg: ASbGncu1nHQSM+BKlawi551mx1zJZPXu87GVOqbo8HQKFlRlYALTHQb875ip6mVG+T0 PSm1mYnsce6VwzQcH7fxCSPAcJNMmRowGS9GMJVmIMaSj5a1e+RbOnRQhV8uPl7mz/tHOUfKzi6 HXPWvU09u1KLHMoysstCXoNYDP9Lfl9kcqLlbJOmAFLRfUwQuHEuguAPZKeSue7GR4B+2SPjVvl urzpE7C93t1rloevVeo14GKJbTsCZYkcqbPpxSeGikIvpR4mCNpZYyuN9zalemtucOGeOaBEU9E yKmJanX7WPaBLWTvVfR/p1Po03fFjk0= X-Received: by 2002:a17:902:db11:b0:216:6283:5a8c with SMTP id d9443c01a7336-21c355bac6amr396498875ad.39.1737697987340; Thu, 23 Jan 2025 21:53:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYAFMYrY3EVMSXVYrxo+bvXExncjT3+v/7gOAOzdbB00h/JmBc+AibN1Dw5PqcIQM/o4Opsg== X-Received: by 2002:a17:902:db11:b0:216:6283:5a8c with SMTP id d9443c01a7336-21c355bac6amr396498425ad.39.1737697986895; Thu, 23 Jan 2025 21:53:06 -0800 (PST) Received: from [10.81.24.74] (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da424e85esm8354345ad.250.2025.01.23.21.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 21:53:06 -0800 (PST) Message-ID: <02396f29-5d1c-4595-8c31-c67cf70fdffe@oss.qualcomm.com> Date: Thu, 23 Jan 2025 21:53:04 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 0/2] mailbox: tmel-qmp: Introduce QCOM TMEL QMP mailbox driver To: Sricharan R , jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, manivannan.sadhasivam@linaro.org, dmitry.baryshkov@linaro.org References: <20241231054900.2144961-1-quic_srichara@quicinc.com> From: Jeff Johnson Content-Language: en-US Cc: Aditya Kumar Singh In-Reply-To: <20241231054900.2144961-1-quic_srichara@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: TMWhYDeCdLmWClbeXxgiHHGT9J_bJH9a X-Proofpoint-GUID: TMWhYDeCdLmWClbeXxgiHHGT9J_bJH9a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-24_02,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 bulkscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501240040 On 12/30/24 21:48, Sricharan R wrote: > From: Sricharan Ramabadhran > > The QMP mailbox is the primary means of communication between TME-L SS > and other subsystem on the SoC. A dedicated pair of inbound and outbound > mailboxes is implemented for each subsystem/external execution environment > which needs to communicate with TME-L for security services. The inbound > mailboxes are used to send IPC requests to TME-L, which are then processed > by TME-L firmware and accordingly the responses are sent to the requestor > via outbound mailboxes. > > It is an IPC transport protocol which is light weight and supports > a subset of API's. It handles link initialization, negotiation, > establishment and communication across client(APPSS/BTSS/AUDIOSS) > and server(TME-L SS). > > ----------------------------------------------- --------------------------------------------------- > | | | | > | SOC CLIENT | SOC | TME-L SS | > | | AHB | | > | ---------- --------- --------- | | ------ ------- -------- ------------ | > | | | | | | | | WO | | | R | | | | |SERVICES | | > | | APPS |<-->| TMEL |<->| |------------->| | IN |-->| | | TMEL | |-------- | | > | | | | COM | | QMP | | RO | | | W | QMP |<--->| COM |<-->| a) ATTEST | | > | | | | | | |<-------------| | OUT |<--| | | | | b) CRYPTO | | > | | | | | | | | | | | | | | | | .. more | | > | --------- --------- --------- | | ------ ------- ------- ------------ | > | | | | > ----------------------------------------------- -------------------------------------------------- > > TME-L SS provides different kinds of services like secureboot, remote image authentication, > key management, crypto, OEM provisioning etc. This patch adds support for remote image > authentication. Support for rest of the services can be added. > > Remote proc driver subscribes to this mailbox and uses the mbox_send_message to use > TME-L to securely authenticate/teardown the images. > > Since clients like same rproc driver use SCM/TMEL across socs, the goal here was to abstract the > TMEL-QMP SS functionality, so that clients should be able to connect and send messages with > a common API. > > [v1] RFC Post > > [v2] > Added HW description in the bindings patch. > Fixed review comments for bindings from Krzysztof and Dmitry > Changed patch#2 driver to add work for mailbox tx processing > Cleaned up patch#2 for some checkpatch warnings. > There are some checkpatch [CHECK] like below, which looks like false positive. > > CHECK: Macro argument 'm' may be better as '(m)' to avoid precedence issues > #1072: FILE: include/linux/mailbox/tmelcom-qmp.h:40: > +#define TMEL_MSG_UID_CREATE(m, a) ((u32)(((m & 0xff) << 8) | (a & 0xff))) > > > Sricharan Ramabadhran (2): > dt-bindings: mailbox: Document qcom,tmel-qmp > mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver > > .../bindings/mailbox/qcom,tmelite-qmp.yaml | 65 ++ > drivers/mailbox/Kconfig | 7 + > drivers/mailbox/Makefile | 2 + > drivers/mailbox/qcom-tmel-qmp.c | 969 ++++++++++++++++++ > include/linux/mailbox/tmelcom-qmp.h | 157 +++ > 5 files changed, 1200 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/qcom,tmelite-qmp.yaml > create mode 100644 drivers/mailbox/qcom-tmel-qmp.c > create mode 100644 include/linux/mailbox/tmelcom-qmp.h > This series was listed as a prerequisite for a WLAN patch I'm reviewing, and when I used my WLAN automation to pull into my workspace the following issues were flagged. >From kernel-doc: drivers/mailbox/qcom-tmel-qmp.c:153: warning: Function parameter or struct member 'qwork' not described in 'qmp_device' drivers/mailbox/qcom-tmel-qmp.c:153: warning: Function parameter or struct member 'data' not described in 'qmp_device' drivers/mailbox/qcom-tmel-qmp.c:153: warning: Function parameter or struct member 'ch_in_use' not described in 'qmp_device' drivers/mailbox/qcom-tmel-qmp.c:304: warning: Function parameter or struct member 'mdev' not described in 'qmp_send_data' drivers/mailbox/qcom-tmel-qmp.c:304: warning: Excess function parameter 'chan' description in 'qmp_send_data' drivers/mailbox/qcom-tmel-qmp.c:394: warning: Function parameter or struct member 'mdev' not described in 'qmp_recv_data' drivers/mailbox/qcom-tmel-qmp.c:394: warning: Excess function parameter 'mbox' description in 'qmp_recv_data' drivers/mailbox/qcom-tmel-qmp.c:438: warning: Function parameter or struct member 'mdev' not described in 'qmp_rx' drivers/mailbox/qcom-tmel-qmp.c:438: warning: Excess function parameter 'mbox' description in 'qmp_rx' drivers/mailbox/qcom-tmel-qmp.c:859: warning: No description found for return value of 'tmel_qmp_mbox_of_xlate' 10 warnings as Errors >From checkpatch --codespell: 1d333d61d25de60704447c9b2dbee165927696d3:16: WARNING:TYPO_SPELLING: 'requestor' may be misspelled - perhaps 'requester'? 1d333d61d25de60704447c9b2dbee165927696d3:76: WARNING:TYPO_SPELLING: 'requestor' may be misspelled - perhaps 'requester'? total: 0 errors, 2 warnings, 65 lines checked cb1085a6ed62b0d1c7400ff9257490e431afe7b0:313: WARNING:TYPO_SPELLING: 'initated' may be misspelled - perhaps 'initiated'? cb1085a6ed62b0d1c7400ff9257490e431afe7b0:316: WARNING:TYPO_SPELLING: 'succes' may be misspelled - perhaps 'success'? cb1085a6ed62b0d1c7400ff9257490e431afe7b0:357: WARNING:TYPO_SPELLING: 'succes' may be misspelled - perhaps 'success'? cb1085a6ed62b0d1c7400ff9257490e431afe7b0:910: WARNING:TYPO_SPELLING: 'controlls' may be misspelled - perhaps 'controls'? total: 0 errors, 4 warnings, 1144 lines checked /jeff