From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED01B33BBBA for ; Fri, 26 Jun 2026 21:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.136 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782511144; cv=none; b=D+74SeikV3ktLhyBPvYrpWMaHgxypMVMT+xag2w6NBWeoHUtLS8spC5MUwAn4ctz3zUwh3C7zDaRQXdEDXn0x1SgO/YyDClaIvHZ369Cb114UJ7qMgvFoj9FDajrAwepo6RysbF1W/Oiq3xGHcHJwZPmWMqfUBox5G/00xpDhX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782511144; c=relaxed/simple; bh=5Zk3kHBmz+/TOVSvXvQJOv8m5PwN+2909oY5v0fcs88=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=cesi+1DIVa4JtJQnqd3CPUKim2IqivIp8xs6xiryOmgE2XwuXFMWSFSdmfMl9KlYQUw1Z88A9Z1bUFVYwz4CAMIVgT+s1X5i+z3yz9JHDIJ/eaQ0hcjdMxV/6zVvHVVgdRNmKKIO66uO/6fbZ/TxJJSyIefQAgvHh9IBSOs1M70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zytor.com; spf=pass smtp.mailfrom=zytor.com; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b=g+U1vZij; arc=none smtp.client-ip=198.137.202.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zytor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zytor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="g+U1vZij" Received: from [IPV6:2601:646:8081:7da1:dcd4:e1f8:5d79:bdb4] ([IPv6:2601:646:8081:7da1:dcd4:e1f8:5d79:bdb4]) (authenticated bits=0) by mail.zytor.com (8.18.1/8.17.1) with ESMTPSA id 65QLgb8l1917301 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Fri, 26 Jun 2026 14:42:37 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 65QLgb8l1917301 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2026052701; t=1782510158; bh=vkN/uofXom6qfFU+UQ9KABVRY9HmzSV3/asbAq2bU1U=; h=Date:Subject:To:References:From:In-Reply-To:From; b=g+U1vZijAugQMDBSVBkDPYVwiBK1jYECbtG65xaynMS4FsO6fW25zojHAXFgJQoos UjBVMleD5XdZh05WEBCkkJHvw6RPyOCPPn7fI3Kxmnsz9GRD98kS6SJRmcEeRF7kOT TmNcQYxDaj3AahXBUn/Nx7z/twlSlUb1zbKCkdVv3IFxE+UY854lMNFzA74jVHKkNR gXTrsgC/iC4WXuYgJa7hXL/TkOruqwS71l+X/kInjSl5qrI+YNW6O/cuVjRWKSG0mg jzbpAMKuy/tUs8GzTiu9eT3ohnYBrbO0ZwqvckFupA2e0j+yl0Jtuh/XRXPXZ/O2Pt SmSi6R+At6Kzg== Message-ID: <0239cda7-b638-44df-9739-746a7173a577@zytor.com> Date: Fri, 26 Jun 2026 14:42:32 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] x86/msr: Document I/O-like MSR semantics in /dev/cpu/*/msr driver To: Tim Wiederhake , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org References: <20260626174037.1128563-1-twiederh@redhat.com> <20260626202323.1169433-2-twiederh@redhat.com> <03245373bd3912bb7421b93c383c9e07454aadd2.camel@redhat.com> Content-Language: en-US, sv-SE From: "H. Peter Anvin" In-Reply-To: <03245373bd3912bb7421b93c383c9e07454aadd2.camel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2026-06-26 13:33, Tim Wiederhake wrote: > > This version splits the change in two: > > 1/2 adds a comment explaining why the driver loops over the same > register, so future readers don't have to rediscover the > rationale. > 2/2 removes only the read loop, where repeated access to the same > register is less obviously useful. > The same applies to the read loop, although the use case(s) are obviously different. Either way, you risk breaking working tools for no reason. -hpa