From: "Guan Xuetao" <guanxuetao@mprc.pku.edu.cn>
To: "'Arnd Bergmann'" <arnd@arndb.de>
Cc: <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCHv1 02/12] unicore32 core architecture: generic headers stuff
Date: Sat, 8 Jan 2011 18:02:41 +0800 [thread overview]
Message-ID: <023a01cbaf1b$3022b5b0$90682110$@mprc.pku.edu.cn> (raw)
In-Reply-To: <201101070055.53996.arnd@arndb.de>
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Friday, January 07, 2011 7:56 AM
> To: Guan Xuetao
> Cc: linux-arch@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCHv1 02/12] unicore32 core architecture: generic headers stuff
>
> On Saturday 25 December 2010, Guan Xuetao wrote:
> > diff --git a/arch/unicore32/include/asm/sizes.h b/arch/unicore32/include/asm/sizes.h
> > new file mode 100644
> > index 0000000..3720307
> > --- /dev/null
> > +++ b/arch/unicore32/include/asm/sizes.h
> > @@ -0,0 +1,47 @@
> > +/*
> > + * linux/arch/unicore32/include/asm/sizes.h
> > + *
> > + * Code specific to PKUnity SoC and UniCore ISA
> > + *
> > + * Copyright (C) 2001-2010 GUAN Xue-tao
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +#ifndef __UNICORE_SIZES_H__
> > +#define __UNICORE_SIZES_H__
> > +
> > +/* handy sizes */
> > +#define SZ_16 0x00000010
> > +#define SZ_256 0x00000100
> > +#define SZ_512 0x00000200
> > ...
>
> This would be nice to have in include/asm-generic. Please make a patch that
> adds the file there and use it with your scripts.
Ok, my pleasure.
>
> > --- /dev/null
> > +++ b/arch/unicore32/include/asm/stat.h
> > @@ -0,0 +1,71 @@
> > +/*
> > + * linux/arch/unicore32/include/asm/stat.h
>
> I think we discussed this particular header before. There should be no reason
> to have your own version instead of using the generic file like you do for the
> rest of the API headers.
The generic-version stat.h can't work for existing binary file systems in unicore32.
I will submit a patch for generic-version stat.h for discussion.
>
> Arnd
Thanks arnd.
Guan Xuetao
next prev parent reply other threads:[~2011-01-08 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-25 18:43 Guan Xuetao
2011-01-06 23:55 ` Arnd Bergmann
2011-01-08 10:02 ` Guan Xuetao [this message]
2011-01-09 0:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='023a01cbaf1b$3022b5b0$90682110$@mprc.pku.edu.cn' \
--to=guanxuetao@mprc.pku.edu.cn \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®