mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>,
	Jonathan Cameron <jic23@kernel.org>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: dac: add support for mcp47a1
Date: Sat, 25 Jul 2026 10:41:30 -0500	[thread overview]
Message-ID: <023a4c95-4dd5-4405-bc73-2171a2292f29@baylibre.com> (raw)
In-Reply-To: <20260725101208.06f60b70@systembl0wer>

On 7/25/26 3:12 AM, Joshua Crofts wrote:
> On Sat, 25 Jul 2026 00:04:51 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
>> On Tue, 21 Jul 2026 20:24:38 +0200
>> Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>>
>>> The Microchip MCP47A1 is a 6-bit volatile Digital-to-Analog converted
>>> which communicates via I2C.
>>>
>>> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
>>> ---
>>>  .../bindings/iio/dac/microchip,mcp47a1.yaml        | 56 ++++++++++++++++++++++
>>>  MAINTAINERS                                        |  6 +++
>>>  2 files changed, 62 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml
>>> new file mode 100644
>>> index 000000000000..3322fca03b3a
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml  
>>
>>> +
>>> +examples:
>>> +  - |
>>> +    i2c {
>>> +          #address-cells = <1>;
>>> +          #size-cells = <0>;
>>> +
>>> +          dac@2e {
>>> +              compatible = "microchip,mcp47a1";
>>> +              reg = <0x2e>;
>>> +              vref-supply = <&vref_regulator>;
>>> +              vdd-supply = <&vdd_regulator>;
>>> +          };
>>> +
>>> +          dac@3e {
>>> +              compatible = "microchip,mcp47a1";  
>> Hi Joshua,
>>
>> What is the advantage of the second example?  I'd drop it.
>>
> 
> Hi Jonathan,
> 
> Per the datasheet, the MCP47A1 can have two different I2C slave
> addresses (0x2e and 0x3e), which allows two DACs to share the
> same bus, something I thought would be good to illustrate in the
> example.
> 

I know we haven't done this much historically, but we could make
that more obvious with this instead:

  reg:
    items:
      - enum: [0x2e, 0x3e]

Then the bindings validator would actually check for a valid
address.

  reply	other threads:[~2026-07-25 15:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 18:24 [PATCH 0/2] iio: dac: mcp47a1: add support for new device Joshua Crofts
2026-07-21 18:24 ` [PATCH 1/2] dt-bindings: iio: dac: add support for mcp47a1 Joshua Crofts
2026-07-22 16:47   ` Conor Dooley
2026-07-24 23:04   ` Jonathan Cameron
2026-07-24 23:04     ` Jonathan Cameron
2026-07-25  8:12     ` Joshua Crofts
2026-07-25 15:41       ` David Lechner [this message]
2026-07-25 21:54         ` Jonathan Cameron
2026-07-21 18:24 ` [PATCH 2/2] iio: dac: mcp47a1: add support for new device Joshua Crofts
2026-07-21 20:47   ` Andy Shevchenko
2026-07-22  6:30     ` Joshua Crofts
2026-07-25 16:52       ` David Lechner
2026-07-24 23:14   ` Jonathan Cameron
2026-07-25 10:17     ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=023a4c95-4dd5-4405-bc73-2171a2292f29@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®