From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03CE12FD672 for ; Wed, 10 Dec 2025 08:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765354915; cv=none; b=VkkonBbcr6o9O0iu0QEoJrvQ81NkAHPPYZbb1kYd9iFijLo88RUt+fwnJcLyS2iepFCH19hE20TE7AC2vKPgVGZ7G57ihQqZPQNCie8aQnuHl7o3sCX2Ru87GANOTCj1r1RYHlGgQgmd8NhqMr7Ukg4PJ+BYCjSRsm67/eXNoQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765354915; c=relaxed/simple; bh=UO5R4ISps+SdV2TiPf7w8ec9+xIFI4520fnD1HzQP9E=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=cNmiwMfFyah1kM9Q7ocoDz0ffc1TBXK7cpKyU4ILx0T4F3/Kbk0kEIYoLEjLKAcNHKke9tT9/0ZswUg5Lt469OPmb/422siAhfVd8S50dZDXQDnkMo3n842x0pv8KpDZBW20Mvl6U9yonLmxQxM8/JhyLuaSx0eg41B/tE1s7R0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BGKqoe1d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gr+1IVIG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BGKqoe1d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gr+1IVIG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BA6E1Qd1047181 for ; Wed, 10 Dec 2025 08:21:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Hxb6Hfleya0YfAM8HHd/h/maKftZ6nHvrFKsgbEF88E=; b=BGKqoe1dGevOtRE6 /Z2PKLqj053l0F4AFKQJKbbnNzyil7dmCd+rv0kVP8KmmQvRprQFZq6GsCEaYWEy xftPx7K3ehkQVOfjStnTsiFOBqlIZroWdHU3gIn0+z6qABqj7D6DzgtEOLl3dr8G jntgo5FlsKGOzA3Ydk+8vKbXYESYa9CC8qrFxdjXERTt9rtbBmvipbdq0IasYEQx 8DNCVGRh1j04Mfyi4PxqBDKDDu0GPDL1SnIgQH09YC9w77u1GBglfzYkJxBUDmYc zeoNDGmtNAQCxQpd1Pu+jiWIGaWykise2CQoEAcVnjoba9tuT1En3caz2ExX28y7 MkrzKw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4axwbf1jp1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 08:21:52 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed6ceab125so13160161cf.1 for ; Wed, 10 Dec 2025 00:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765354912; x=1765959712; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Hxb6Hfleya0YfAM8HHd/h/maKftZ6nHvrFKsgbEF88E=; b=gr+1IVIGrdZr1BpderCis6b59Sv5HTjql8XH4nNPfrtCp5J0UszPBJYzFc704jYXsb zrDgylFadi3J7nyny19ebVEaH6/Y5iW+5J+5TGIqTvRoTjqERxPcIB2/GmwB/QSCw1y3 R3JSLasHwNJ/SYQQVA5ge7/zK1SlCxLHOKFV4HJmjmI+tnezcr4jX5TGa8bwWM7ePWiQ y9o1POQy0TjZbLQFHKOmExZrzyKg96iFXohYOJwIpLr/nA7TuJG/58XiLKh+szZoLRTt kefZHsfQgPPPc8tSjMVbp3F10/2BcgkGlx2hKUjCyHlSdBATFE6yOFD9LrAo6xUCL1ZP cGYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765354912; x=1765959712; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hxb6Hfleya0YfAM8HHd/h/maKftZ6nHvrFKsgbEF88E=; b=ILYhoo8wb8+1xoOqRf7FsJ5hWSZqg7xFE3Qx1aoupIZteCsz+1pK5/R73BCGhdUTIB LwbDIBAG2VYreSfF1M1xbB2pCCgMGwDk5nacwYYCP0+SXhS+EDKMQM78dlOLTR12861L PklxQwBwjB4+52//istkg0dAc/9f1gpbwDpDYgPBPzK+NWDcXk0MwdYkQMTDzzV8PhFU u1FhMSkQ4clESufZy1bA4UMggnfYWv3biOaDyJJ+PHMGeE4Zu4hIKe6k+a1iNDj7a183 WqDiXsZOGI5p1MxkM9xgMd/ipa0aECp5hjROHz5VjXgRdymZeKEjpHci66aU02NvCSfV lpwA== X-Forwarded-Encrypted: i=1; AJvYcCXuG9CeoQZkABPBSaOxrq8b4DN9bHSxSzEehFMEzOyKHT64TG3smfMIoQ2zRgeGL87kYunhbNlokDtx3P8=@vger.kernel.org X-Gm-Message-State: AOJu0YyUSkloimpf30eLQ+Ig92s137Nj+6Q77GFTbY0T4F1hemtY5WkV 87OJPK3hgFtQ/TCTSoc0HIBfulIGs0PlPutyEd0fotldAPAb8LZSNJ7XZf/YSH9Pm4CgREgCs32 equadTXh/dk7b7/QVFFg6mpagwS+BGscVLAYXdr2AnObwnAvdXtZwht/0qTt0U/qG78M= X-Gm-Gg: ASbGnctUsEHG5+hcDAzyhrUwUjX7sEusYwwIyYUw2Ea4APhQa2i6F1o/XB8177C+Rx/ cpQmK1mxI32z91n/e+Vu7sfm0aotgYcTcaRHmXwWAdCGheIBT6QqDZ+DiV+chfgOC7DBi1dKnZ+ xUUU34K0J7nOJOkGnrofGBLiHC2Xk4eKaYJz4xTmcDIwZkp/IJ9Nf59b0iy/ZG8fGAkFi6o0iAF XbM1gijju/uY4WnPTM+XY+ESDkSjCfN3pxFx4t/Pwn3cuKtI8VQsrM3aJED/WmxgFmANhvJVyam g1sqh2HBQX/Y9T3Uoq+QviaalDBNKULI4PWASveQkd+mwIDy3sSsf208NQS+/igoAJmTh4xtbY6 YRAwaz4lSvh8/OLzBPpqSeCPDfKM1RuZDXRswQxe8mNydG8QZa+YLlb7LiQjmBxsco+eDh1sjjz XmEHquqq0Mz2/WtlCAFze2Y4fu3aH/lTP19O6BFtEMt0B/We0/I0rPcr11sOT74HE9r4diBXsng MQZ X-Received: by 2002:ac8:5ccf:0:b0:4f0:2b7e:c5c5 with SMTP id d75a77b69052e-4f1b1947c54mr20000541cf.0.1765354911858; Wed, 10 Dec 2025 00:21:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEt5hHH1XmxzyGPV2DuSarJveef/bWqsC0tPz9tuqzLf4WEb0nH5V2QLsZulrLYRPVHhG40DA== X-Received: by 2002:ac8:5ccf:0:b0:4f0:2b7e:c5c5 with SMTP id d75a77b69052e-4f1b1947c54mr20000381cf.0.1765354911437; Wed, 10 Dec 2025 00:21:51 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f4457f91sm1649069366b.7.2025.12.10.00.21.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 00:21:50 -0800 (PST) Message-ID: <023d20e6-23ef-4f64-8ea6-31f973b33c95@oss.qualcomm.com> Date: Wed, 10 Dec 2025 09:21:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH] media: dw9714: Fix powerup sequence To: Ricardo Ribalda , Sakari Ailus , Mauro Carvalho Chehab , Ondrej Jirman , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251210-dw9174-timing-v1-1-4a5036465727@chromium.org> Content-Language: en-US, nl In-Reply-To: <20251210-dw9174-timing-v1-1-4a5036465727@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: hIUCRbhd5E1xbhiPz8kaNMDwWI1LbVnu X-Proofpoint-ORIG-GUID: hIUCRbhd5E1xbhiPz8kaNMDwWI1LbVnu X-Authority-Analysis: v=2.4 cv=f/dFxeyM c=1 sm=1 tr=0 ts=69392da1 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KtRVGM7OAAAA:8 a=cm27Pg_UAAAA:8 a=EUspDBNiAAAA:8 a=p84Ubd_8bvLkjSw0z5YA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=fO9at-cOa0qPyS5aOM0m:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDA3MSBTYWx0ZWRfX1hemM5k6t05s 5FtK3y2hjhjNPEjmY3heAnOQ/h3QJHehc6Hzxz+zFv2g4bD2dhqtSjnJ3YpD90RQ3RvfmGv49yW BPEB5ulTrIklm59cc3mlpxU2A2HlwDCcTv2vUWuMf6/5nUyAeYzS1UN8evcQnaN+eyb5p3Poc0B MBRQ8zEfqqulBPS8Uv1kj1T6YTkruIGG354gi0fYcnM0blP5S1RPeP2LmMS2asqQeVVaQGuRmcN JpFyOvcVj0mN+12bJj527RCS1cdKOgKbfHruzljtcTHxZ03GiVGxS2wLNzgoVBMhSAxw5enQHDf f74QKWcVF/txx5uDiEBN18MFiN1FteL16CcCPqIsRgJdtoqseeHgdi6FdpAUG2I8/YBMIfdEUEP l786daz1znJie0k+UMt8U3UXtwsTHw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_05,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100071 Hi, On 10-Dec-25 8:53 AM, Ricardo Ribalda wrote: > We have experienced seen multiple I2C errors while doing stress test on > the module: > > dw9714 i2c-PRP0001:01: dw9714_vcm_resume I2C failure: -5 > dw9714 i2c-PRP0001:01: I2C write fail > > Inspecting the powerup sequence we found that it does not match the > documentation at: > https://blog.arducam.com/downloads/DW9714A-DONGWOON(Autofocus_motor_manual).pdf > > """ > (2) DW9714A requires waiting time of 12ms after power on. During this > waiting time, the offset calibration of internal amplifier is > operating for minimization of output offset current . > """ > > This patch increases the powerup delay to follow the documentation. > > Fixes: 9d00ccabfbb5 ("media: i2c: dw9714: Fix occasional probe errors") > Signed-off-by: Ricardo Ribalda Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/media/i2c/dw9714.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c > index 1e7ad355a388cfc37253bd764ec8df98f59beeea..3288de539452ebae41daa0988b2d52f27a790da7 100644 > --- a/drivers/media/i2c/dw9714.c > +++ b/drivers/media/i2c/dw9714.c > @@ -149,7 +149,7 @@ static int dw9714_power_up(struct dw9714_device *dw9714_dev) > > gpiod_set_value_cansleep(dw9714_dev->powerdown_gpio, 0); > > - usleep_range(1000, 2000); > + usleep_range(12000, 14000); > > return 0; > } > > --- > base-commit: f7231cff1f3ff8259bef02dc4999bc132abf29cf > change-id: 20251210-dw9174-timing-9e58903399c9 > > Best regards,