From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21A753446C3; Mon, 18 May 2026 10:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099830; cv=none; b=mzutUTij6nmkuOx8tN+unSg50xtdWzNje13LlwajkEuPQpHPKDnfScaGFJrcrJw5JYkvS9xKgQzlNMJdvHe5Uk58SlrYivSDLeB+MihO85xHXFD7xRm3eQrkFaenCr2MRUJb6+r+vBjOz7/0RIJThyQvzq1m5jKv5QQ0rO4FTZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099830; c=relaxed/simple; bh=i3wWInKnlNmS1++USwfTN3VrDNZNb25BYuiRZlvBVTU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A9mLnV8rAX3unni0aKeCAL0Mh5T4asjnjwJJw6u8+TWvh+Nd+rk2jUnZGrE1oHjDZge72pvNxf9YeCNMnmf56HGVQWU6FYpZbrIwjyPGAWei6x3s/IFzEFHAAEZ4QaqyvSgGgdhlThzg+z6mR2yHPC4MKcBnvA+ZL2ahJ6/nX9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FxRbxLuC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FxRbxLuC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23D2FC2BCB7; Mon, 18 May 2026 10:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779099829; bh=i3wWInKnlNmS1++USwfTN3VrDNZNb25BYuiRZlvBVTU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FxRbxLuC8iHMdlc1vHRfGL9A7KBIs60PIa+KTnQHNO+Y4RrTjfJMNGC7T342cQwf2 5/HOCdkgxctAf6gikwBTMscIie3XogVjobo469GooUJXjnfzQ1E3Exm5GRart6m33x yehATdXLhnfzR19KjgQeFT8zMcf6zL20ym9JbobjhfD7lwiIqGF8cI3AsIg99POMYn V02N9reGzPs0/I4IVUzlGi9xyTauLnkdrUa99pNpg/lda5Tgy8yCsWsVGgPHF0maGV A41aJpwbO4bcb8Yk2ZDSyJmD8zeiaPh+ywwnGydNLVjtt3wmGOKMh8sdW9Uko0oH2V ZivAF31LcheVQ== Message-ID: <0240eb13-6c56-4879-8db7-b990a220a78f@kernel.org> Date: Mon, 18 May 2026 12:23:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/11] dt-bindings: mfd: add documentation for S2MU005 PMIC To: Conor Dooley , Kaustabh Chakraborty Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet , Shuah Khan , Nam Tran , =?UTF-8?B?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org References: <20260515-s2mu005-pmic-v6-0-1979106992d4@disroot.org> <20260515-s2mu005-pmic-v6-3-1979106992d4@disroot.org> <20260515-justly-recite-6028f4bfb24a@spud> <20260516-esquire-chitchat-0fffa597e2f3@spud> <20260517-corrode-tuesday-a598ca734b38@spud> <20260518-succulent-plethora-2dba60fad426@spud> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260518-succulent-plethora-2dba60fad426@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/05/2026 11:45, Conor Dooley wrote: > On Mon, May 18, 2026 at 09:15:11AM +0200, Krzysztof Kozlowski wrote: >> On 17/05/2026 22:52, Conor Dooley wrote: >>> On Sun, May 17, 2026 at 06:39:37PM +0530, Kaustabh Chakraborty wrote: >>>>>>>>> + >>>>>>>> + properties: >>>>>>>> + compatible: >>>>>>>> + const: samsung,s2mu005-rgb >>>>>>>> + >>>>>>>> + required: >>>>>>>> + - compatible >>>>>>>> + >>>>>>>> + unevaluatedProperties: false >>>>>>>> + >>>>>>>> + reg: >>>>>>>> + maxItems: 1 >>>>>>> >>>>>>> Move this above the child nodes please. >>>>>> >>>>>> But properties are sorted in lex order? >>>>> >>>>> Typically the binding is sorted in the same order as properties go in >>>>> nodes. Common stuff like reg/clocks/interrupts therefore send up above >>>>> child nodes. >>>> >>>> So, do I change this? For one, I don't see the same being followed in >>>> other schemas of samsung in the same dir (not that I'm trying to pose it >>>> as an argument against your suggestion), and this was reviewed by >>>> Krzysztof and is adderssed in v7. >>> >>> If Krzysztof doesn't care, then I won't ask you to change it. >> >> This builds on top of bindings for previous Samsung PMIC devices, so >> that's why it keeps the compatibles for children, I guess. No one >> complained about this at v1-v2 reviews, so when I joined reviewing in v3 >> I did not, either. >> >> I don't think the compatible should be here, but I also don't want to >> stall that patchset. I understand that it is inconsistent review from my >> side, because other similar patchsets receive comment to drop the >> compatible. But I don't think we will be fair asking to drop the >> compatible now, when we did not ask for that in the early versions at all. > > > I think you misunderstood, we were talking about the ordering of the > properties in the binding file being alphanumerical, rather than the > more typical approach of approximately following the order of > dts-coding-style. Ah, then I misunderstood and, even though it is a nit, I do care because old code is then used for new patches. Bindings follow DTS rules, thus should be: 1. compatible 2. reg 3. core properties 4. vendor properties Kaustabh, can you change it please? Best regards, Krzysztof