From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026C1158DD4 for ; Mon, 14 Oct 2024 10:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728900529; cv=none; b=sKfA8A/uoicujsKgxZQHOqzCgHObGVkImpaSsZQSYv6KrMn63IJ28dYO1lZWnB/QkK7V2j0eO78BIF0QTopEIkLiNjhxVXbxtbcNWEmxF4AOc++lC3TOS69xD024cQ2PaOb0WfPnMORmeQN9O9Y5zwBQIZ32ntg8EUuixSKaXKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728900529; c=relaxed/simple; bh=/sWlEGgfHHX9djG/FSb50XLkDF+y1KqaTESwoXdZHSs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U6WcJFTcJJHl0tO23MdfnRaSiDujw2nBnbuwSWcU+9dTvPWI2fp3JnAoKfqE8bXIubmjpS8oaDYh0u3CiZv8jYp4/dyyGct4tgTNo4lz7k9BVCi1vhIRD7j8qEj41Ewx5Qfd1GYHsWYC6PIAwU5dGUMqk7Pav1HmdLmIpDEG6nI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bBV9IsKr; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bBV9IsKr" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5c94dd7e1c0so3783742a12.0 for ; Mon, 14 Oct 2024 03:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728900526; x=1729505326; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FWUSe6Dna6tclDo/Nzgx/0TudE4bBGcoklr8vby/lzw=; b=bBV9IsKr8UqJv708BP/R7LOJWTtRDlsUMKQ+SNWIjeqa78UzM5Rwvtax9xpXkLHSXj j+CKXgNFIQWtD7afS6hsH+gB6FUGl1PI5QsWjjrw0jcYf/zPcdkJIna1YnL6KO3mDu4G aaCw7rpzsxpnB43RgzBIflrrofve/WhD4rKkV1ES7vQYb+wZrxqH+e/hx2tyYhMKae1T 48gAjORiNJusW9oc0woSiwIz3dN8gcKJh0Z2Xfz9yNhLQDOyamse8pLLt1xFuP8S9mSw I86JxGG5KNcAkwDLSaTSIPo3nWdc01a2aJOxzwYgTaKWnE8tuKtV0AOAZFDFD+4q8Cfz RntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728900526; x=1729505326; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FWUSe6Dna6tclDo/Nzgx/0TudE4bBGcoklr8vby/lzw=; b=t6uIAkv5vqJegowKPOJoHEgIpFH9xnnz/GhGi9D7AlR0PTN2PU9OZ5ZwfUbI60pVw7 1w9hglH+XVqZp8SdAENd69odq76YtlJKvkRX9HbD4dVpXZIae5nJgM6oNPN+qlQ1kQy0 MDicYRouMxGvOH+IIpOBy5oqpeLJgXJ/nP53owg+Xs0fswTVRBnkDq0N/1hISn+cMFiW gfkBup4hH1oTT5VcMgkzd0NneA8PKcS1UeJo3aUBRYE95n62PbNN694Oj5X+AAllQvxZ pDS0DByQhqGVefJ4pfwIEN5m6kgTGVJmjeenY4JkPfUcNrk8Y/ewKTyTcElcclIJYjP9 FZuQ== X-Forwarded-Encrypted: i=1; AJvYcCXFVwxlcmPZbKxFBGBqrr50mEb3YVKguDDlF7Du7wkrDy8zPy8MaYAr79WDguerTE30Y8nFFE+0mHSUwzM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4518lc4NFHuN8gfCBs2ua5W/NgqwSQkINn655f/5RqWCax1RP flUxLNlHF2NWtNtQN7aFkm0euTssXq8PiQSEhtE7zN7WWiyEyE6lYAz/A41iEqY= X-Google-Smtp-Source: AGHT+IESQDbU2/QoUk/jd6BnyeOUUPQzo77RwiIkyssfzTbI61MYXbPAfDvLUJDHZOc5ItYRiz14Fw== X-Received: by 2002:a05:6402:5191:b0:5c9:5e43:9480 with SMTP id 4fb4d7f45d1cf-5c95e43f157mr4714225a12.7.1728900526354; Mon, 14 Oct 2024 03:08:46 -0700 (PDT) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c937152f12sm4802674a12.44.2024.10.14.03.08.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 03:08:45 -0700 (PDT) Message-ID: <0240feca-541d-4aa9-abde-c0b0b0b477e5@linaro.org> Date: Mon, 14 Oct 2024 11:08:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema To: Krzysztof Kozlowski Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dave Stevenson , Sakari Ailus , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Martin Kepplinger , Paul Kocialkowski , "Paul J. Murphy" , Daniele Alessandrelli , Tommaso Merciai , Martin Hecht , Zhi Mao , Alain Volmat , Mikhail Rudenko , Ricardo Ribalda , Kieran Bingham , Umang Jain , Manivannan Sadhasivam , Vladimir Zapolskiy , Dongchun Zhu , Quentin Schulz , Todor Tomov , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-0-a2bb12a1796d@linaro.org> <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-1-a2bb12a1796d@linaro.org> <9e3d86b4-fad7-4467-af7c-9195855cd318@kernel.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <9e3d86b4-fad7-4467-af7c-9195855cd318@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/10/2024 09:44, Krzysztof Kozlowski wrote: > On 14/10/2024 10:29, Bryan O'Donoghue wrote: >> On 14/10/2024 08:43, Krzysztof Kozlowski wrote: >>>> - - assigned-clocks >>>> - - assigned-clock-rates >>> That's not extraneous, but has a meaning that without assigned-clocks >>> this device or driver will not operate. >>> >>> File should rather stay as is. >> >> Hmm, I've obviously missed a trick here. >> >> I'll check it out. > > My response was probably not complete: this still might be extraneous, > because maybe the driver/device do not care. But in general requiring > assigned-clocks could have a meaning. No I see what you mean Even though assigned-clock* is a property of the SoC this driver.. drivers/media/i2c/hi846.c mclk_freq = clk_get_rate(hi846->clock); if (mclk_freq != 25000000) dev_warn(&client->dev, "External clock freq should be 25000000, not %u.\n", mclk_freq); doesn't support setting the clock. So it actually is a requirement, yes. --- bod