From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106FEC433B4 for ; Tue, 20 Apr 2021 09:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBDE861363 for ; Tue, 20 Apr 2021 09:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbhDTJ1A (ORCPT ); Tue, 20 Apr 2021 05:27:00 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42468 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbhDTJ07 (ORCPT ); Tue, 20 Apr 2021 05:26:59 -0400 Received: from [IPv6:2a02:810a:880:f54:f1d0:e988:975e:70e9] (unknown [IPv6:2a02:810a:880:f54:f1d0:e988:975e:70e9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9A3271F41F0F; Tue, 20 Apr 2021 10:26:27 +0100 (BST) Subject: Re: [PATCH] media: rkisp1: rkisp1-params.c: Fix typos To: Sebastian Fricke , linux-media@vger.kernel.org Cc: Helen Koike , Mauro Carvalho Chehab , Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210419060224.44353-1-sebastian.fricke@posteo.net> From: Dafna Hirschfeld Message-ID: <02425403-5b44-62f8-4cab-a677fe317dbe@collabora.com> Date: Tue, 20 Apr 2021 11:26:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210419060224.44353-1-sebastian.fricke@posteo.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19.04.21 08:02, Sebastian Fricke wrote: > s/when the camera active/when the camera is active/ > s/thus not isr protection/thus no ISR protection/ > > Signed-off-by: Sebastian Fricke > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > index b6beddd988d0..ead948a2d01e 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > @@ -1258,7 +1258,7 @@ void rkisp1_params_configure(struct rkisp1_params *params, > rkisp1_params_config_parameter(params); > } > > -/* Not called when the camera active, thus not isr protection. */ > +/* Not called when the camera is active, thus no ISR protection. */ I think it would better to write /* Not called when the camera is active, therefore there is no need to acquire a lock */ Thanks, Dafna > void rkisp1_params_disable(struct rkisp1_params *params) > { > rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DPCC_MODE, >