mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jakub Kicinski" <kuba@kernel.org>, "Chen Ni" <nichen@iscas.ac.cn>
Cc: andrew+netdev@lunn.ch, "David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Dave Jiang" <dave.jiang@intel.com>,
	"Lukas Wunner" <lukas@wunner.de>, Netdev <netdev@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] myri10ge: Convert comma to semicolon
Date: Wed, 11 Feb 2026 22:07:56 +0100	[thread overview]
Message-ID: <0244faa4-763c-4ccd-b98e-59a0ee6b346b@app.fastmail.com> (raw)
In-Reply-To: <20260211103308.4d6263bf@kernel.org>

On Wed, Feb 11, 2026, at 19:33, Jakub Kicinski wrote:
> On Tue, 10 Feb 2026 09:37:33 +0800 Chen Ni wrote:
>> Replace comma between expressions with semicolons.
>> 
>> Using a ',' in place of a ';' can have unintended side effects.
>> Although that is not the case here, it is seems best to use ';'
>> unless ',' is intended.
>> 

Fixes: fd24173439c0 ("myri10ge: avoid uninitialized variable use")
Acked-by: Arnd Bergmann <arnd@arndb.de>

> ## Form letter - net-next-closed
>
> We have already submitted our pull request with net-next material for v7.0,
> and therefore net-next is closed for new drivers, features, code refactoring
> and optimizations. We are currently accepting bug fixes only.

This is a regression fix for a mistake I made in a patch you merged
for 7.0. This was not very clear since Chen forgot to add a 'Fixes'
tag and labeled it as [net-next] when it should (now) have been
[net].

     Arnd

  reply	other threads:[~2026-02-11 21:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  1:37 Chen Ni
2026-02-11 18:33 ` Jakub Kicinski
2026-02-11 21:07   ` Arnd Bergmann [this message]
2026-02-13  1:54     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0244faa4-763c-4ccd-b98e-59a0ee6b346b@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=pabeni@redhat.com \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®