From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966417AbcKLCZa (ORCPT ); Fri, 11 Nov 2016 21:25:30 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35925 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966389AbcKLCZZ (ORCPT ); Fri, 11 Nov 2016 21:25:25 -0500 Subject: Re: [GIT PULL] SCSI fixes for 4.9-rc3 To: Kashyap Desai , James Bottomley , Andrew Morton , Linus Torvalds References: <1478352591.2858.5.camel@HansenPartnership.com> <1eee17da-1166-6a48-8a21-0ad5d6a0660a@gmail.com> <024723a1-3dec-f644-277b-4178118cc241@gmail.com> <8275700b8bd4c457dab7b6e7260fce00@mail.gmail.com> Cc: linux-scsi , linux-kernel , stable@vger.kernel.org From: Gabriel C Message-ID: <02467dd3-21ab-9807-d516-87cc75b793a1@gmail.com> Date: Sat, 12 Nov 2016 03:05:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8275700b8bd4c457dab7b6e7260fce00@mail.gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.11.2016 02:08, Kashyap Desai wrote: >> -----Original Message----- >> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi- >> owner@vger.kernel.org] On Behalf Of Gabriel C >> Sent: Friday, November 11, 2016 9:40 AM >> To: James Bottomley; Andrew Morton; Linus Torvalds >> Cc: linux-scsi; linux-kernel; stable@vger.kernel.org >> Subject: Re: [GIT PULL] SCSI fixes for 4.9-rc3 >> >> >> >> On 11.11.2016 04:30, Gabriel C wrote: >>> >>> On 05.11.2016 14:29, James Bottomley wrote: >>> >>> >>> ... >>> >>>> Kashyap Desai (1): >>>> scsi: megaraid_sas: Fix data integrity failure for JBOD >>>> (passthrough) devices >>>> >>>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >>>> b/drivers/scsi/megaraid/megaraid_sas_base.c >>>> index 9ff57de..d8b1fbd 100644 >>>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c >>>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c >>>> @@ -1700,16 +1700,13 @@ megasas_queue_command(struct Scsi_Host >> *shost, struct scsi_cmnd *scmd) >>>> goto out_done; >>>> } >>>> >>>> - switch (scmd->cmnd[0]) { >>>> - case SYNCHRONIZE_CACHE: >>>> - /* >>>> - * FW takes care of flush cache on its own >>>> - * No need to send it down >>>> - */ >>>> + /* >>>> + * FW takes care of flush cache on its own for Virtual Disk. >>>> + * No need to send it down for VD. For JBOD send >> SYNCHRONIZE_CACHE to FW. >>>> + */ >>>> + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && >>>> +MEGASAS_IS_LOGICAL(scmd)) { >>>> scmd->result = DID_OK << 16; >>>> goto out_done; >>>> - default: >>>> - break; >>>> } >>>> >>>> return instance->instancet->build_and_issue_cmd(instance, scmd); >>> >>> This patch breaks my box.. I'm not able to boot it anymore. >>> It seems with this patch I have /dev/sda[a-z] to /dev/sdz[a-z] ?!? >>> >>> I'm not sure how to get an log since dracut times out and I'm dropped >>> , after a very long time of probing 'ghost devices', in a emercency >>> shell, >> journalctl doesn't work also.. >>> >>> After reverting this one I can boot normal. >>> >>> Box is a FUJITSU PRIMERGY TX200 S5.. > > Please check now commit. Below commit has complete fix. > > http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=5e5ec1759dd663a1d5a2f10930224dd009e500e8 > This patch fixes the problem for me. Thank you. Regards, Gabriel C