From: Sagi Grimberg <sagi@grimberg.me>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Ming Lei <ming.lei@redhat.com>,
Hannes Reinecke <hare@suse.de>, Wen Xiong <wenxiong@us.ibm.com>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH v6 3/3] nvme-fc: Remove freeze/unfreeze around update_nr_hw_queues
Date: Tue, 24 Aug 2021 13:38:20 -0700 [thread overview]
Message-ID: <025942a6-4f57-b005-eb77-e9eed143522c@grimberg.me> (raw)
In-Reply-To: <20210823112351.82899-4-dwagner@suse.de>
> From: James Smart <jsmart2021@gmail.com>
>
> Remove the freeze/unfreeze around changes to the number of hardware
> queues. Study and retest has indicated there are no ios that can be
> active at this point so there is nothing to freeze.
>
> This patch primarily reverts 883837ed0f1f
Bogus commit ID.
"nvme-fc: wait for queues to
> freeze before calling update_hr_hw_queues". It's not an exact revert as
> it leaves the adjusting of hw queues only if the count changes.
I see that fc doesn't freeze the queues, so it obviously wrong to
unfreeze them. But is it correct to not freeze the queues?
next prev parent reply other threads:[~2021-08-24 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 11:23 [PATCH v6 0/3] Handle update hardware queues and queue freeze more carefully Daniel Wagner
2021-08-23 11:23 ` [PATCH v6 1/3] nvme-fc: Update hardware queues before using them Daniel Wagner
2021-08-23 11:23 ` [PATCH v6 2/3] nvme-fc: avoid race between time out and tear down Daniel Wagner
2021-08-23 11:23 ` [PATCH v6 3/3] nvme-fc: Remove freeze/unfreeze around update_nr_hw_queues Daniel Wagner
2021-08-24 20:38 ` Sagi Grimberg [this message]
2021-08-25 13:04 ` Daniel Wagner
2021-08-25 16:03 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=025942a6-4f57-b005-eb77-e9eed143522c@grimberg.me \
--to=sagi@grimberg.me \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®