From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexander Steffen <Alexander.Steffen@infineon.com>,
jarkko@kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org
Cc: peterhuewe@gmx.de, jgg@ziepe.ca,
krzysztof.kozlowski+dt@linaro.org,
Johannes Holland <johannes.holland@infineon.com>,
Amir Mizinski <amirmizi6@gmail.com>
Subject: Re: [PATCH v3 1/2] tpm: Add tpm_tis_i2c backend for tpm_tis_core
Date: Sun, 22 May 2022 10:30:11 +0200 [thread overview]
Message-ID: <02596f22-3d19-8872-75fd-2a8f563c8270@linaro.org> (raw)
In-Reply-To: <20220520172422.4309-2-Alexander.Steffen@infineon.com>
On 20/05/2022 19:24, Alexander Steffen wrote:
>
> +MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id of_tis_i2c_match[] = {
> + { .compatible = "infineon,slb9673", },
> + { .compatible = "tcg,tpm_tis-i2c", },
Please run checkpatch on your patches. You add undocumented compatibles.
Without bindings, new compatibles and properties cannot be accepted, so NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-22 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 17:24 [PATCH v3 0/2] tpm_tis_i2c Alexander Steffen
2022-05-20 17:24 ` [PATCH v3 1/2] tpm: Add tpm_tis_i2c backend for tpm_tis_core Alexander Steffen
2022-05-22 8:30 ` Krzysztof Kozlowski [this message]
2022-05-23 8:55 ` Alexander Steffen
2022-05-23 9:32 ` Krzysztof Kozlowski
2022-05-23 9:44 ` Krzysztof Kozlowski
2022-05-23 16:10 ` Alexander Steffen
2022-05-23 16:18 ` Alexander Steffen
2022-05-23 20:07 ` Jarkko Sakkinen
2022-05-20 17:24 ` [PATCH v3 2/2] tpm: Add tpm_tis_verify_crc to the tpm_tis_phy_ops protocol layer Alexander Steffen
2022-05-23 20:08 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02596f22-3d19-8872-75fd-2a8f563c8270@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Alexander.Steffen@infineon.com \
--cc=amirmizi6@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=johannes.holland@infineon.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®