Re: [PATCH v3 0/4] media: qcom: flip the switch between Venus and Iris drivers

[Vikash Garodia <vikash.garodia@oss.qualcomm.com>]

On 1/29/2026 8:02 PM, Dmitry Baryshkov wrote:
> On Thu, Jan 29, 2026 at 03:32:28PM +0530, Vikash Garodia wrote:
>>
>> On 1/29/2026 5:51 AM, Dmitry Baryshkov wrote:
>>> On Wed, Jan 28, 2026 at 06:35:01PM +0530, Vikash Garodia wrote:
>>>>
>>>> On 1/27/2026 5:52 PM, Dmitry Baryshkov wrote:
>>>>> As the Venus and Iris drivers are close to the "feature parity" for the
>>>>> common platforms (SC7280, SM8250), in order to get more attention to
>>>>> squashing bugs from the Iris driver, flip the switch and default to the
>>>>> Iris driver if both are enabled. The Iris driver has several
>>>>> regressions, but hopefully they can be fixed through the development
>>>>> cycle by the respective team. Also it is better to fail the test than
>>>>> crash the device (which Venus driver does a lot).
>>>>>
>>>>> Note: then intention is to land this in 6.21, which might let us to
>>>>> drop those platforms from the Venus driver in 6.22+.
>>>>>
>>>>> Testing methodology: fluster test-suite, single-threaded mode, SM8250
>>>>> device (RB5).
>>>>
>>>> Could you run fluster on SC7280 as well ? Also please share the v4l2
>>>> compliance results.
>>>
>>> Okay, the SC7280 is a bit more interesting. For H.264 and VP9 the
>>> results are the same. For H.265 Iris errors out for all tests except for
>>> the one, WPP_E_ericsson_MAIN_2.
>>>
>>> The kernel prints the following message:
>>>
>>> [   82.573112] qcom-iris aa00000.video-codec: session error for command: d0000000, event id:1009, session id:52ef2000
>>>
>>
>> 0x1009 corresponds to HFI_ERR_SESSION_INSUFFICIENT_RESOURCES
>>
>> Below patch would enable firmware logs and make it print in kernel logs, you
>> can apply and share to know more about insufficient resource error.
> 
> Added it. BTW: would it make sense to land it in some way (I saw that
> earlier you posted the same one for gen2). Would it make sense to land
> it in some way upstram?

yes, for sure. It was pending, before we enable, to check firmware do 
not emit any default message which are type "err | warn" and those gets 
emitted in kernel logs everytime, even in success cases.

> 
> Anyway:
> 
> $ gst-launch-1.0 --no-fault filesrc location=/home/debian/fluster/fluster/../resources/JCT-VC-HEVC_V1/AMP_A_Samsung_7/AMP_A_Samsung_7.bin ! parsebin ! v4l2h265dec ! video/x-raw ! videoconvert dither=none ! video/x-raw,format=I420 ! videocodectestsink -m
> Setting pipeline to PAUSED ...
> Pipeline is PREROLLING ...
> Got message #19 from element "videocodectestsink0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #20 from element "capsfilter1" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #21 from element "videoconvert0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #22 from element "capsfilter0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #23 from element "v4l2h265dec0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #24 from element "typefind" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #25 from element "parsebin0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #26 from element "filesrc0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #27 from element "pipeline0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)paused;
> Got message #29 from element "capsfilter1" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #30 from element "videoconvert0" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #31 from element "capsfilter0" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #32 from element "v4l2h265dec0" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #35 from pad "typefind:sink" (stream-status): GstMessageStreamStatus, type=(GstStreamStatusType)create, owner=(GstElement)"\(GstTypeFindElement\)\ typefind", object=(GstTask)"\(GstTask\)\ typefind:sink";
> Got message #36 from element "typefind" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #37 from element "parsebin0" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #38 from element "filesrc0" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #39 from pad "typefind:sink" (stream-status): GstMessageStreamStatus, type=(GstStreamStatusType)enter, owner=(GstElement)"\(GstTypeFindElement\)\ typefind", object=(GstTask)"\(GstTask\)\ typefind:sink";
> Got message #51 from element "h265parse0" (state-changed): GstMessageStateChanged, old-state=(GstState)null, new-state=(GstState)ready, pending-state=(GstState)void-pending;
> Got message #67 from pad "h265parse0:sink" (stream-status): GstMessageStreamStatus, type=(GstStreamStatusType)create, owner=(GstElement)"\(GstH265Parse\)\ h265parse0", object=(GstTask)"\(GstTask\)\ task1";
> Got message #68 from element "h265parse0" (state-changed): GstMessageStateChanged, old-state=(GstState)ready, new-state=(GstState)paused, pending-state=(GstState)void-pending;
> Got message #69 from pad "h265parse0:sink" (stream-status): GstMessageStreamStatus, type=(GstStreamStatusType)enter, owner=(GstElement)"\(GstH265Parse\)\ h265parse0", object=(GstTask)"\(GstTask\)\ h265parse0:sink";
> Got message #74 from element "parsebin0" (stream-collection): GstMessageStreamCollection, collection=(GstStreamCollection)"\(GstStreamCollection\)\ unparented";
> Got message #70 from element "pipeline0" (stream-start): GstMessageStreamStart, group-id=(uint)2;
> Got message #83 from pad "v4l2h265dec0:src" (stream-status): GstMessageStreamStatus, type=(GstStreamStatusType)create, owner=(GstElement)"\(v4l2h265dec\)\ v4l2h265dec0", object=(GstTask)"\(GstTask\)\ task2";
> ERROR: from element /GstPipeline:pipeline0/GstParseBin:parsebin0/GstH265Parse:h265parse0: Internal data stream error.
> Additional debug info:
> ../libs/gst/base/gstbaseparse.c(3703): gst_base_parse_loop (): /GstPipeline:pipeline0/GstParseBin:parsebin0/GstH265Parse:h265parse0:
> streaming stopped, reason error (-5)
> ERROR: pipeline doesn't want to preroll.
> Got message #85 from pad "v4l2h265dec0:src" (stream-status): GstMessageStreamStatus, type=(GstStreamStatusType)enter, owner=(GstElement)"\(v4l2h265dec\)\ v4l2h265dec0", object=(GstTask)"\(GstTask\)\ v4l2h265dec0:src";
> Setting pipeline to NULL ...
> ERROR: from element /GstPipeline:pipeline0/v4l2h265dec:v4l2h265dec0: Could not read from resource.
> Additional debug info:
> ../sys/v4l2/gstv4l2object.c(6253): gst_v4l2_object_poll (): /GstPipeline:pipeline0/v4l2h265dec:v4l2h265dec0:
> poll error 1: Success (0)
> ERROR: pipeline doesn't want to preroll.
> Freeing pipeline ...
> 
> 
<snip>

> [   68.592482] qcom-iris aa00000.video-codec:
> [   68.592482] <VFW_M:HostDr:265d:6eea4000:00000000> Set buffer type 0x7 addr 0xd0000000 num 1 size 135967744
> [   68.605612] qcom-iris aa00000.video-codec:
> [   68.605612] <VFW_H:HostDr:265d:6eea4000:00000000> HFI_BUFFER_COMMON_INTERNAL_SCRATCH_1, Driver macro size = 135967744 vs FW HFI macro size = 136623360 vs FW golden buffer size = 13640960
> [   68.616954] qcom-iris aa00000.video-codec:
> [   68.616954] <VFW_E:HostDr:265d:6eea4000:00000000> vDec_SetBuffers(2017): Dec_SetBuffers, Insufficient 7 buffer

One of the internal buffer size (135967744 bytes) fails to meet the size 
desired by firmware (136623360 bytes) to decode this specific test 
vector, hence resource insufficient.

We need to compare if iris is calculating any les size for scratch_1.

scratch_1 venus - 
https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c#L647

scratch_1 iris - 
https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/media/platform/qcom/iris/iris_vpu_buffer.c#L552

> [   68.628259] qcom-iris aa00000.video-codec:
> [   68.628259] <VFW_L:HostDr:unkn:--------:-> Host cmd: HFI_CMD_SESSION_LOAD_RESOURCES
> [   68.640602] qcom-iris aa00000.video-codec:
> [   68.640602] <VFW_L:HostDr:265d:6eea4000:00000000> Output2 Dimensions 1:1 : NO_SCALING
> [   68.653195] qcom-iris aa00000.video-codec:
> [   68.653195] <VFW_E:HostDr:265d:6eea4000:00000000> vDec_LoadResources(1392): Load Resources Command received without complete buffer set 16/14
> [   68.665510] qcom-iris aa00000.video-codec:
> [   68.665510] <VFW_L:HostDr:265d:6eea4000:00000000> Load Resource with core id: 0
> [   68.678699] qcom-iris aa00000.video-codec:
> [   68.678699] <VFW_M:HostDr:265d:6eea4000:00000000> cabac_direct_mode = 0
> [   68.692300] qcom-iris aa00000.video-codec:
> [   68.692300] <VFW_E:HostDr:265d:6eea4000:00000000> vDec_AttachInternalBuffers(1760): mem->vsp_buf: pty->size_vsp:461056,total_size:0
> [   68.704271] qcom-iris aa00000.video-codec:
> [   68.704271] <VFW_E:HostDr:265d:6eea4000:00000000> vDec_LoadResources(1486): Load Resources failed with error code: 4105 due to internal buffer attachment
> [   68.722196] qcom-iris aa00000.video-codec:

...
> [   68.892229] qcom-iris aa00000.video-codec: session error for command: d0000000, event id:1009, session id:6eea4000

Regards,
Vikash