From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22A6D256C93 for ; Thu, 29 May 2025 07:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502882; cv=none; b=o5CimlVH6IX+qkKpEN5yAHcBOTswlXqg7x6y4WrMZLWKj56D/J5f8+L6GqsIhz630n17F2BGUnWYKiNBny3GzUHf6vbV9d8WUUvJGxZQSXGQz0WpxKbMUl7Ga/H9BmlZmarUS4vmSa4KoElICVlrkzIowJUOL3B6JBdbnitvWIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502882; c=relaxed/simple; bh=07UXbYCn7cRZ5NxV/3AidW5vV7Ee9BWX17yIvYRrP0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O4TteYkFZW30BqkZKquqvwJtnNgIC2R5cXndcxzvLy2EN+vgULhK2yfy83FjWQpTXnNAmV77TxCp8wf7XH50xstmQsjC7ubDF9tJ+r5ljm4RkDNRy6eq95kPGHHcOjVQWwTj73/bqtLp8+O7tE8zI2/J3uThl10qdOWVndci8Mw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XStj0sft; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XStj0sft" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54SL5aEX012585 for ; Thu, 29 May 2025 07:14:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jVa35T4wQfLgVUHuSEEbWi7ckEE/l+jqbxBz8uhNkac=; b=XStj0sftasNbddO2 bDBUY6bfwxC47/yRNwbYDQkUY7QkHyw7AZ8Wfw5rz/m/vsfdEV1nuMC/iW0gcQhl aScEitpwW3ybCvYyrbb27R7DuNT2JkMCtWbADMGyuWTSHcEk4MVFqe46wSIETJ05 S+kmazugXM6VRKZBGXQ7QxNYcqI2JPhdEQMEmKkykiyf4OHTgPQ7wRuLYPNtp+Vt gMiwOTaiQOnczya7j+jMNjHdy7ekHTMD8J1479bjj8gD3KxvfX+E1xtItnJd1RMK XYw9m1IcKjTNfMkPyOjvFi2FtxxWthuOxr/04RsZSHRflQysp0/Zk2G3+Y9BDqet 7jRcGg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46w691fbxk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 29 May 2025 07:14:39 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2350804a43eso5889355ad.0 for ; Thu, 29 May 2025 00:14:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748502879; x=1749107679; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jVa35T4wQfLgVUHuSEEbWi7ckEE/l+jqbxBz8uhNkac=; b=P/6K88EZKzYY7TC7Cicd29ylqAklZezVG6Qj9G51mMT732jWiuO9WcYXO7akOZ8497 APMef6wT7EWxC8zmnEVEQwI7iMj1uel5vayUzSCY+9YLeyEOM+wiCXU9ZgfAoi6KJ7YO RTlYw3r5sL/opBZp1dVcBRRwbrK4N2FERKHH3pTn9wmXVu1s2zrDYkhA5Snkq8FvK46H tJKgeM/vuAl5m3FBWIf8QLQfPJrJn25iieEiv76Z9OSYjAsnsjTE1NR1X0TvLiHBSeDE NrZaQXbQwnhkOPV+JlGwF0HUz8DluKTbjsamBgkgb9UUmgax13/4TUHkDh6DzLB570pb YGyQ== X-Forwarded-Encrypted: i=1; AJvYcCX0VIbmvVuLnohQMNihG2cV4RbsmYCNbSlxTini/WyEPJISEiWnXFxdztCvVDpzCsLAdiNG9Zi25hkYI5k=@vger.kernel.org X-Gm-Message-State: AOJu0YxdRvsSb6kPRxQATwWncMbcZHFoamX0ai1CsV/enojQkKedHYy3 Meh1rFIRUKGHcaJcCJ5adHM6UsW0MWrhf4eELygY3RryGUuEJSRUrs14K/S2LEnV6BqLjoOLNEn zDsIJggVzI7HXV8x4WyoYmaGWnQwNdapGpGhcrRVf79RmHBfmGiR1aaN8KQUO4Ku0aNnEgg8HdD I= X-Gm-Gg: ASbGncuiNn4G1e3ehzOYD6T4MWsobdUHiQdySDx+x8BDNFmcwQ4Vn53FF1j+OJGE0+N v/51pQoFNBw7U4mSX1cDM4BudiSD2yLTf+JtrFmg7cQizb3Xc6eBphF1zBsHHbJexWNADOMCweH DtWT7cjTN/m1bDEK4s88JrOISxK+xHG4or1jXYqwB5PPYeAdEtNqFGhhUVurIrumz5hzBfKmZgU 2rufAMD318aZAxSF8ckjGPDtnvXGWHXDuoQKLYAhEifLfv+ovmWg6tSQidf+uDdh0zTTRacMn2V YSX9bgTTgJoqbZYsm+iKY3pi5S1WwgcvHjHlvaV4F8EP7FkVpc0A6mAFmhhHMDZeJnS/SIcmiD7 M X-Received: by 2002:a17:903:3c2b:b0:22e:3c2:d477 with SMTP id d9443c01a7336-23414f9127dmr335319275ad.25.1748502878840; Thu, 29 May 2025 00:14:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEueHsRRqEM+24t4WlwUoH2u9RMoXV+6e02OQb8YFrStUMU8UnD6bIOHM3t/Mu6fcD1Hx2keg== X-Received: by 2002:a17:903:3c2b:b0:22e:3c2:d477 with SMTP id d9443c01a7336-23414f9127dmr335318965ad.25.1748502878502; Thu, 29 May 2025 00:14:38 -0700 (PDT) Received: from [10.133.33.104] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506cf4730sm6464155ad.168.2025.05.29.00.14.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 May 2025 00:14:37 -0700 (PDT) Message-ID: <025c297a-de13-49ee-81ea-2290df0f6843@oss.qualcomm.com> Date: Thu, 29 May 2025 15:14:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] power: supply: qcom-battmgr: Add charge control support To: me@kuruczgy.com, Sebastian Reichel , Bjorn Andersson Cc: Subbaraman Narayanamurthy , David Collins , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com References: <20250523-qcom_battmgr_update-v1-0-2bb6d4e0a56e@oss.qualcomm.com> <20250523-qcom_battmgr_update-v1-5-2bb6d4e0a56e@oss.qualcomm.com> <1b1c4617-0e5b-40c8-9a66-d243b48c0977@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=WfoMa1hX c=1 sm=1 tr=0 ts=6838095f cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=hOspveqpAAAA:8 a=ukq9x2Ni-G2YEArqOW4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=3Os_Ld9iau9Fc9k96hWO:22 X-Proofpoint-GUID: ExsNL5yd92kN_zz6wZ8IOulS9L6B33YD X-Proofpoint-ORIG-GUID: ExsNL5yd92kN_zz6wZ8IOulS9L6B33YD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI5MDA3MCBTYWx0ZWRfXyrroovV4IcVl BDCpVq8N+b9OnkallK6XpDnrTV9JdZx0N1YaxtUzaD2tC+g3jNexd2aHOTMdOWXfPhhmJg0QWO4 WzB0KlozqiIWUK09zhzC3dm9AiKirjfi7a+5AvnW1Kp/DvXlFVNNa9i4H8UcLVjxePV3irhqncA FnlxEihLJ1KToAByWC8ofGDEa1+92g65Hu/EsTT6lbpPakmO6jz9bwdDaPFdyjUmbyUOIzucyfl BY5X+pxRvancYgHwkx6vKhFNz2BNQW2/L+olCrYJmdrM+jx+i71TwXq4D2X/6NgcjOqUnXOLSLr GgXOVIffe3jxgP5MwSTepp9LiQur9cByzefhO0KAz7RIfTMWFPzjeLH+oR29OXVF6a/FFs8hXmz zkE1CG1wxsUvk8FHvkbkLN7cjgdyGCaaVqD1/h78K6GlnNYr1vSUJpynUH9GtIqDHuPHkeJP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-29_03,2025-05-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505290070 On 5/28/2025 12:42 AM, me@kuruczgy.com wrote: >> No, sc8280xp and x1e80100 don't support it. So I didn't add the support for them. > Hm... From what I heard charge limiting works on some X1E laptops, e.g. the ThinkPad T14s on Windows using Lenovo Vantage. > > Do you happen to know how that works? Is that some vendor specific solution? Or does it depend on the version of the battery management firmware? (AFAIK this is part of the adsp firmware?) > > Thanks, > György Thank you for the information. I confirmed with our battery management firmware team that the X1E80100 platform does support charge control using the same scheme, opcode, and request and response data messages. I will add charge control support for X1E80100 in V2. Thanks Fenglin