From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbcF1J5g (ORCPT ); Tue, 28 Jun 2016 05:57:36 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:42713 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbcF1J5e (ORCPT ); Tue, 28 Jun 2016 05:57:34 -0400 X-AuditID: cbfec7f4-f796c6d000001486-ff-57724a0a9d33 From: Kamil Debski To: "'Shuah Khan'" , kyungmin.park@samsung.com, jtp.park@samsung.com, mchehab@osg.samsung.com Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <1465847114-7427-1-git-send-email-shuahkh@osg.samsung.com> In-reply-to: <1465847114-7427-1-git-send-email-shuahkh@osg.samsung.com> Subject: RE: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove() Date: Tue, 28 Jun 2016 11:57:29 +0200 Message-id: <025e01d1d123$7c14e620$743eb260$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQJs5z4gmYkYzFa5fWZd0ol0Pvxt4Z7Id0ug Content-language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xK7pcXkXhBvM3mlocWXuVyeJs0xt2 i02Pr7FaXN41h82iZ8NWVovVzyospn75wOLA7rF5Sb3Hlv677B59W1YxenzeJBfAEsVlk5Ka k1mWWqRvl8CVseRXI3PBM4GKDUcXMTYwzuPrYuTkkBAwkfg+dyUbhC0mceHeeiCbi0NIYCmj xKv23ywQzmdGiYNf3zB2MXJwsAloSqy65wFiigiUSTx5GwTSyyyQKjHj42N2EFtIwE1i0YqV zCA2p4C7xN9zLWC2MJDd1HGREcRmEVCVuH3nC9heXgFLiRNt+xghbEGJH5PvsUDM1JJYv/M4 E4QtL7F5zVtmiDsVJHacfQ1WLyJgJHG9aQ9UvYjE3YbnrBMYhWYhGTULyahZSEbNQtKygJFl FaNoamlyQXFSeq6hXnFibnFpXrpecn7uJkZIdHzZwbj4mNUhRgEORiUe3h11heFCrIllxZW5 hxglOJiVRHgdPIvChXhTEiurUovy44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbL xMEp1cCYnWl2zP7JzBzlA/N3nHrT2D+r8hbzK0V+qyzpU+nMl2+Vd4pGudzhPPpHQ11qQsWj 4/v3vtWYe6KypIlD4rywu0eIWlD9oU/vFfa/P2j5m/WCO0dneeSliND+dLbZ6SHi0dm/+05q WeZdETPySfuu5p4zw282m+LvJ2mHPs67dWvL8b/89g1KLMUZiYZazEXFiQADolLVigIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Shuah, Which branch do you base your patches on? I have trouble applying this path (https://patchwork.linuxtv.org/patch/34577/) and "s5p-mfc fix null pointer deference in clk_core_enable()" (https://patchwork.linuxtv.org/patch/34751/) onto current linuxtv/master. The top commit of linuxtv/master is : "commit 0db5c79989de2c68d5abb7ba891bfdb3cd3b7e05 Author: Mauro Carvalho Chehab Date: Thu Jun 16 08:04:40 2016 -0300 [media] media-devnode.h: Fix documentation" Could you please rebase the two patches mentioned above to the linuxtv/master? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -----Original Message----- > From: Shuah Khan [mailto:shuahkh@osg.samsung.com] > Sent: Monday, June 13, 2016 9:45 PM > To: kyungmin.park@samsung.com; k.debski@samsung.com; > jtp.park@samsung.com; mchehab@osg.samsung.com > Cc: Shuah Khan; linux-arm-kernel@lists.infradead.org; linux- > media@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove() > > s5p_mfc_remove() fails to release encoder and decoder video devices. > > Signed-off-by: Shuah Khan > Reviewed-by: Javier Martinez Canillas > --- > > Changes since v1: > - Addressed comments from Javier Martinez Canillas and added > his reviewed by: > > drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c > b/drivers/media/platform/s5p-mfc/s5p_mfc.c > index 274b4f1..f537b74 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c > @@ -1318,6 +1318,8 @@ static int s5p_mfc_remove(struct platform_device > *pdev) > > video_unregister_device(dev->vfd_enc); > video_unregister_device(dev->vfd_dec); > + video_device_release(dev->vfd_enc); > + video_device_release(dev->vfd_dec); > v4l2_device_unregister(&dev->v4l2_dev); > s5p_mfc_release_firmware(dev); > vb2_dma_contig_cleanup_ctx(dev->alloc_ctx[0]); > -- > 2.7.4