From: "Arnd Bergmann" <arnd@arndb.de>
To: "Justin Stitt" <justinstitt@google.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"laurent.pinchart" <Laurent.pinchart@ideasonboard.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Mark Brown" <broonie@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] media: dvb-frontends: avoid stack overflow warnings with clang
Date: Fri, 16 Feb 2024 21:11:25 +0100 [thread overview]
Message-ID: <025f63f5-9114-439b-ad49-c37dffd1ea2f@app.fastmail.com> (raw)
In-Reply-To: <CAFhGd8qmR+EPVUDt0DVttxm3aBQpdL2i4XbFZ3_ko6Li=mVH3A@mail.gmail.com>
On Fri, Feb 16, 2024, at 19:56, Justin Stitt wrote:
> On Fri, Feb 16, 2024 at 8:32 AM Arnd Bergmann <arnd@kernel.org> wrote:
>> -
>> - buf[0] = MSB(reg);
>> - buf[1] = LSB(reg);
>> - memcpy(buf + 2, data, len);
>
> I'm curious why a copy was made at all.
>
> Reviewed-by: Justin Stitt <justinstitt@google.com>
I guess the idea was to allow writing arbitrarily long
contents to a single register with a single decriptor.
The current version of the driver only ever writes a single
byte value, but maybe it either used to have other writes,
or it was meant to support them later but never did.
Arnd
prev parent reply other threads:[~2024-02-16 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 16:31 Arnd Bergmann
2024-02-16 18:56 ` Justin Stitt
2024-02-16 20:11 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=025f63f5-9114-439b-ad49-c37dffd1ea2f@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®