From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD31C286D52; Thu, 14 Aug 2025 07:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755157796; cv=none; b=MDpSWlIJJg343YqiHrwjfX7mwIu3R5/dV78pBwxwFwSIyzb/sgu9UWI9b7i/73Jsv2uiRRDIAUA6Kv/4hGQGpxJ3r96GuntYwlvf7eCKXYftjJtvro1TNwsUGL932pg/Cyf7AK7oUQuM43GNoMzP+Bgn83Fj0BOKHWxtCwtGQo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755157796; c=relaxed/simple; bh=f35AnSEo6H6Mj8LPGStUWaOusqBiWbWyTlU3soOSje4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ic0qKuHh4WHZyoOQxmZx/kgCbRxOxSmn3eTHeyA3CH7p0XbEY9nppQFbCxgOT8HWshQGgE+Gfunb2Iu/uCeLnTtTNGEGJFo6EoFLwQsQYHQTwrD2rpcfqHGFqOBuSJaOhNGUUpKEgrbksVCqOYs+TWTvlLNDcFRaCmd8wLGteTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AblpmqcX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AblpmqcX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 585FDC4CEEF; Thu, 14 Aug 2025 07:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755157796; bh=f35AnSEo6H6Mj8LPGStUWaOusqBiWbWyTlU3soOSje4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AblpmqcXAN4ysoqlSXpI2+ce7BroJRKBqENO6jOU8nbQ1sWveX0r75s4ALXlEDAAR 8mR61mUCUsjNonJRaMp6ttbamG8Pp9VfNXBjVbeItoBFdRWbEvvVidFXOPHV6+om96 Xa7Ik0Aj6APGF4HuTd56kHnDxFfcR2JoHI4O49I2kvCIOEhs9wyylg2fpM4YQ1ZGT7 3F1xigHsaH2t6HzqRYPVxKIPC0sgD8U6GuA5T3MKBnqgpEc1Z1uzIz6gqpyNe27esM MUZXs96VAjJtRnW33VuXnzT0WubpZQbG9Vet2r635PaqVC1miOxC1YmUQC36pWAQpt cjI7rgK2HoKHA== Message-ID: <026419bc-c0f8-4891-a348-311f51cb999f@kernel.org> Date: Thu, 14 Aug 2025 09:49:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/4] dt-bindings: firmware: thead,th1520-aon: add a mailbox name for SBI To: Icenowy Zheng , Drew Fustini , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Michal Wilczynski Cc: Han Gao , Inochi Amaoto , Yao Zi , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250814070757.2267325-1-uwu@icenowy.me> <20250814070757.2267325-3-uwu@icenowy.me> <1b63d1872f5b2c89f2fafdf717bda5ec29589b69.camel@icenowy.me> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <1b63d1872f5b2c89f2fafdf717bda5ec29589b69.camel@icenowy.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 14/08/2025 09:30, Icenowy Zheng wrote: > 在 2025-08-14星期四的 09:18 +0200，Krzysztof Kozlowski写道： >> On 14/08/2025 09:07, Icenowy Zheng wrote: >>> The SBI firmware might want to communicate to the AON firmware too. >>> >>> Add a mbox-name item to allow to allocate a mailbox for SBI. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>>  .../devicetree/bindings/firmware/thead,th1520-aon.yaml     | 7 >>> ++++--- >>>  1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml >>> b/Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml >>> index 3365124c7fd47..555465f4aab4e 100644 >>> --- a/Documentation/devicetree/bindings/firmware/thead,th1520- >>> aon.yaml >>> +++ b/Documentation/devicetree/bindings/firmware/thead,th1520- >>> aon.yaml >>> @@ -26,11 +26,12 @@ properties: >>>      const: thead,th1520-aon >>>   >>>    mboxes: >>> -    maxItems: 1 >>> +    maxItems: 2 >> >> >> ABI break without explanation why ("allow" is not a reason to affect >> ABI) and its impact. > > Is adding items an ABI break? Adding required items is ABI break. You can easily test it. Apply patch #1 and test your DTS. Apply patch #2 and test your DTS. New warnings appear, so that's a proof of ABI impact. > > Or should I explicitly say "minItems: 1" here? Yes, but you should clearly explain the impact. Is it working? Not working? Are you fixing something? Best regards, Krzysztof