From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Oliver Neukum <oneukum@suse.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
netdev@vger.kernel.org
Cc: Dean Jenkins <Dean_Jenkins@mentor.com>
Subject: Re: inconsistent lock state with usbnet/asix usb ethernet and xhci
Date: Mon, 05 Mar 2018 08:45:00 +0100 [thread overview]
Message-ID: <02679502-cf6e-8714-e879-50a922c5d976@samsung.com> (raw)
In-Reply-To: <1519747675.2649.3.camel@suse.com>
Hi Oliver,
On 2018-02-27 17:07, Oliver Neukum wrote:
> Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet:
>> On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote:
>>>
>>> Note that for this one, it seems we also could perform stats updates in
>>> BH context, since skb is queued via defer_bh()
>>>
>>> But simplicity wins I guess.
>> Thinking more about this, I am not sure we have any guarantee that TX
>> and RX can not run on multiple cpus.
>>
>> Using an unique syncp is not going to be safe, even if we make lockdep
>> happy enough with the local_irq save/restore.
> Unfortunately you are right. It is not guaranteed for some hardware.
Does it mean that the fix proposed by Eric is not the proper solution?
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2018-03-05 7:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180227072602eucas1p28dcdba711b3153820bd409d838cc63bd@eucas1p2.samsung.com>
2018-02-27 7:26 ` Marek Szyprowski
2018-02-27 10:37 ` Oliver Neukum
2018-02-27 10:59 ` Marek Szyprowski
2018-02-27 14:07 ` Eric Dumazet
2018-02-27 14:42 ` Marek Szyprowski
2018-02-27 15:09 ` Eric Dumazet
2018-02-27 15:13 ` Eric Dumazet
2018-02-27 16:07 ` Oliver Neukum
2018-03-05 7:45 ` Marek Szyprowski [this message]
2018-03-05 11:46 ` Oliver Neukum
2018-03-05 19:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02679502-cf6e-8714-e879-50a922c5d976@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=Dean_Jenkins@mentor.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®