From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965270AbdJRJuu (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Oct 2017 05:50:50 -0400
Received: from smtp11.infineon.com ([217.10.52.105]:22303 "EHLO
        smtp11.infineon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932934AbdJRJus (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Oct 2017 05:50:48 -0400
X-SBRS: None
From: <Alexander.Steffen@infineon.com>
To: <joe@perches.com>, <elfring@users.sourceforge.net>,
        <linux-integrity@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>
CC: <James.Bottomley@HansenPartnership.comg>, <dan.carpenter@oracle.com>,
        <jarkko.sakkinen@linux.intel.com>, <andriy.shevchenko@linux.intel.com>,
        <benh@kernel.crashing.org>, <clabbe.montjoie@gmail.com>,
        <jgunthorpe@obsidianresearch.com>, <jsnitsel@redhat.com>,
        <kgold@linux.vnet.ibm.com>, <mpe@ellerman.id.au>,
        <nayna@linux.vnet.ibm.com>, <paulus@samba.org>, <PeterHuewe@gmx.de>,
        <stefanb@linux.vnet.ibm.com>, <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
Subject: RE: char-TPM: Adjustments for ten function implementations
Thread-Topic: char-TPM: Adjustments for ten function implementations
Thread-Index: AQHTR/AMDk4GC/dUGkChaZD4klU53qLpMssAgAAoH7A=
Date: Wed, 18 Oct 2017 09:50:46 +0000
Message-ID: <026d582729b849b780fbaa06fb8bc79e@infineon.com>
References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net>
         <20171016183139.otyh3m5c5yurtmow@linux.intel.com>
         <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com>
         <20171017085124.pkrjzghcf5wmcydc@mwanda>
         <f9b35a67-bd7f-b140-bdc1-cb4886a6b1ea@users.sourceforge.net>
         <1508255833.3129.33.camel@HansenPartnership.com>
         <1508280210.6530.32.camel@perches.com>
         <bf7fc26c-bdc9-c752-72c7-f44c22f4a328@users.sourceforge.net>
 <1508318326.6806.1.camel@perches.com>
In-Reply-To: <1508318326.6806.1.camel@perches.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.23.8.247]
Content-Type: text/plain; charset="Windows-1252"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9I9otwk008811

> On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote:
> > > The printk removals do change the objects.
> > >
> > > The value of that type of change is only for resource limited systems.
> >
> > I imagine that such small code adjustments are also useful for other
> systems.
> 
> Your imagination and mine differ.
> Where do you _think_ it matters?
> 
> For instance, nothing about
> 
> 	sizeof(type)
> vs
> 	sizeof(*ptr)
> 
> makes it easier for a human to read the code.

If it does not make it easier to read the code for you, then maybe you should consider that this might not be true for all humans. For me, it makes it much easier to see at a glance, that code like ptr=malloc(sizeof(*ptr)) is correct.

Alexander