From: John Garry <john.garry@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "xuwei (O)" <xuwei5@huawei.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
gregkh <gregkh@linuxfoundation.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Robin Murphy <robin.murphy@arm.com>,
Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>,
<bogdan.purcareata@nxp.com>, "Tony Lindgren" <tony@atomide.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Olof Johansson <olof@lixom.net>,
Kevin Hilman <khilman@kernel.org>, <tanxiaojun@huawei.com>
Subject: Re: [PATCH] HISI LPC: Add Kconfig MFD_CORE dependency
Date: Thu, 19 Apr 2018 14:08:33 +0100 [thread overview]
Message-ID: <026e9f13-7201-57a5-a4b3-8c48a89bf134@huawei.com> (raw)
In-Reply-To: <CAK8P3a1nen_EoyZ63p_EfSu51wUAbLigzbrv3K4byS2gUo9CjQ@mail.gmail.com>
On 19/04/2018 13:00, Arnd Bergmann wrote:
> On Thu, Apr 19, 2018 at 1:55 PM, John Garry <john.garry@huawei.com> wrote:
>> For ACPI support of the HiSilicon LPC driver we depend
>> on MFD_CORE config.
>>
>> Currently the HiSi LPC Kconfig entry does not define this
>> dependency, so add it.
>>
>> Fixes: e0aa1563f894 ("HISI LPC: Add ACPI support")
>> Reported-and-tested-by: Tan Xiaojun <tanxiaojun@huawei.com>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>
> Can you explain the specific dependency? Normally MFD_CORE gets
> selected by an MFD driver but not other drivers.
>
For each device on the LPC bus we create an MFD.
The reason we do this is that we need to set the resources of the
derived MFD, as we should not modify the original ACPI device created in
ACPI scan. Details are in the log for e0aa1563f894.
Shall I update commit message updated with this info? Or were you just
interested in the motivation for using MFD?
Thanks,
John
> Arnd
>
> .
>
next prev parent reply other threads:[~2018-04-19 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 11:55 John Garry
2018-04-19 12:00 ` Arnd Bergmann
2018-04-19 13:08 ` John Garry [this message]
2018-04-19 13:29 ` Arnd Bergmann
2018-04-19 13:42 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=026e9f13-7201-57a5-a4b3-8c48a89bf134@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=bogdan.purcareata@nxp.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=horms+renesas@verge.net.au \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=robin.murphy@arm.com \
--cc=sebastien.bourdelin@savoirfairelinux.com \
--cc=tanxiaojun@huawei.com \
--cc=tony@atomide.com \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®